docs(hooks): record the post-program hook budget accounting - #3679
Conversation
The hook-budget convention gains a dated reference-figures section in spawn-equivalents with the harness sha256, and the four plugins that lacked an accounting row (typos-format, eol-normalizer, markdown-format, context-guard) gain one under Requirements. Documentation only. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…e3d749 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
#3678 landed Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Claude finished @kyle-sexton's task in 4m 46s —— View job Code review complete
This is a documentation-only PR (139/-4 across 13 files: the hook-budget convention doc, and CHANGELOG/README/plugin.json for four plugins). Scope matches the stated intent — no hook, script, or registration changes touched. Verified independently:
Two findings posted inline (both documentation self-consistency gaps, not caught by markdownlint):
Both are minor and easy to fix; neither blocks the doc-recording intent of this PR. No correctness, security, or test-coverage issues found — this PR has no test surface (docs only), consistent with Not independently verified (author-claimed in the PR body, no tool access in this lane to re-run): the dotfiles harness run itself, |
|
Claude finished @kyle-sexton's task in 37s —— View job Security review — skipped (no security-relevant surface)
This PR is documentation-only: it adds a "Reference figures" section to Per the skip gate in |
|
Last security-reviewed head: |
|
Claude has reviewed this PR 2 times. The lane skips further automatic reviews after 5; deleting this comment resets the count. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 13d58f7aa5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…nd add the Edit rows The compliance paragraph now sums PreToolUse and PostToolUse per tool call and states the reference-host reading plainly: no per-tool-call surface meets the budget, and on the reference host no per-turn surface does either; the program shrank the overage. The context-guard table gains the UserPromptSubmit row and states PostCompact in spawn-equivalents. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Claude finished @kyle-sexton's task in 2m 6s —— View job Code review complete
Scope of this pass: this is a re-review triggered by a new push. The only commit since the last completed review ( Both of my earlier findings and both of Codex's findings are now resolved, and I independently re-verified the fix:
I also checked the new "guardrails plugin's remediation work, named in its README" claim (hook-budget/README.md:78) against No new findings. Nothing in |
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Pre-prune commit: bac012f (PLAN.md with the restated goal, the constraint 1 mapping table and the final run block; DEVIATIONS.md with every ruling, finding and evidence run). Durable outcomes graduated to: the outcome and follow-up comments on issue #3623, docs/conventions/hook-budget/README.md and the six plugin READMEs (#3679), docs/conventions/hook-telemetry/README.md (#3678), and issues #3680 to #3685. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
No related issue: phase 8 of the hook-performance program, tracking issue #3623
Summary
The hook-performance program landed nine PRs today (#3621, #3662, #3666, #3668, #3671, #3675, #3676, #3677, #3678, plus dotfiles #620). This PR records the outcome where the convention says it lives: the hook-budget convention gains a dated reference-figures section in spawn-equivalents with the harness sha256, and the four plugins that lacked a hook budget accounting row gain one under Requirements. Documentation only; no hook, script or registration changes.
Fix
docs/conventions/hook-budget/README.md: a "Reference figures (2026-09-02, after the hook-performance program)" section with the harness identity, the before-and-after spawn-equivalents per surface (before at S = 33 ms, after at S = 18 ms onmain5e3d749cb), the reference-host conversion, and a plain reading against the budget table: per-turn rows meet the 500 ms ceiling; per-tool-call rows sit at 1.4 to 1.9 s against the 1 s typical ceiling, with the guardrails dispatcher named as the whole of the remainder.plugins/typos-format/README.md,plugins/eol-normalizer/README.md,plugins/markdown-format/README.md,plugins/context-guard/README.md: a "Hook budget accounting" section each, carrying the measured rows their CHANGELOG entries already state (36.3 to 26.0, 41.0 to 21.5, 41.6 to 32.0 spawn-equivalents; 11 to 2, 9 to 4 and 6 to 1 processes for context-guard), what changed, and the residual. guardrails and rate-limit-guard already carried one.Verification
main5e3d749cb,--runs 3, S = 18 ms, valid, quiet host; every measured plugin's cache directory byte-compared againstorigin/main(0 stale files in 17);enabledPluginsunchanged against the pre-program snapshot; 52hooks.jsonentries listed, every onetype: command, noasyncrow. The per-event block, the STATED CHECK and the reading against goal (B) are in the program's PLAN.md and DEVIATIONS.md onperf/hook-performance-program.markdownlint-cli20 issues on the five files; em dash counts unchanged;scripts/check-changelog-parity.sh --check-bump origin/mainexit 0;scripts/affected-tests.sh --explainselects no suites (every changed file is a recorded no-suite class covered by a non-shell CI lane).Related
🤖 Generated with Claude Code