fix(claude-memory): count newline-named topic files once in scope-report - #3631
Conversation
scope-report.sh piped find output through wc -l, which counts newlines in the stream rather than files, so a topic filename with an embedded newline was counted twice. Switch to the null-delimited idiom already used by the sibling enumerate-all-projects.sh. Add a fixture file with a newline in its name and assert the report counts it once. Co-authored-by: ksextonmelodic <ksextonmelodic@gmail.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Claude finished @kyle-sexton's task in 54s —— View job Security review complete
No security issues found. This PR only touches Notes from review, none rising to a reportable finding:
Skip-gate condition 2 (no security-relevant surface after reading the diff) applies here. |
|
Last security-reviewed head: |
|
Claude finished @kyle-sexton's task in 1m 7s —— View job Code review complete
Scope: Summary: The fix replaces The regression test ( I read the full diff and the surrounding script/test files. I was not able to execute the test suite myself in this sandboxed environment ( No high-signal findings. The change is small, targeted, matches the high-signal bar's exclusions (no style nits, no pre-existing-issue scope creep), and correctly limits itself to the one broken counting path. One non-blocking note already disclosed in the PR body: this PR and #3374 both touch |
|
Claude has reviewed this PR 1 time. The lane skips further automatic reviews after 5; deleting this comment resets the count. |
Rebased onto origin/main after #3631. Keep both the isolation cases and the 0.11.12 newline-count fixture (now routed through iso_env). Add a new ## [0.11.13] heading above the published 0.11.12 release. Co-authored-by: ksextonmelodic <ksextonmelodic@gmail.com>
Closes #3444
Summary
scope-report.shcounted topic files withfind | wc -l, which counts newlines in the stream, so a filename containing an embedded newline was counted twice.Fix
Replaced the pipeline with the sibling null-delimited idiom:
find -print0plusread -r -d ''. Plugin bumped to 0.11.12.Verification
Added a fixture whose name contains a literal newline and asserted
topic files: 2. Confirmed the new assertion fails against the pre-fix script and passes after.scripts/affected-tests.sh --runselected the co-located suite; all 22 checks passed.Related
N/A
Note: this PR and #3374 both touch
scope-report.test.sh. Merge #3374 first, then rebase this one.