fix(scripts): consolidate org-agnosticism token sets - #3250
Conversation
Hold fleet, setup, autonomy, and github token classes in one data file. Every enforcement site reads that file or is a documented extension of it. Enforcement scope is deliberately those classes, not agent content or a fleet-wide bare organization name. Closes #3136 Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
|
Claude finished @kyle-sexton's task in 53s —— View job Security review (
|
|
Last security-reviewed head: |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8e7e9a25dd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…hub.test.sh A typo class name no longer silently drops tokens. The github plugin's agnostic-conformance test is required when the plugin exists. Closes #3136 Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
|
Claude finished @cursor[bot]'s task in 35s —— View job Code review (
|
|
Claude has reviewed this PR 1 time. The lane skips further automatic reviews after 5; deleting this comment resets the count. |
Closes #3136
Summary
Org-agnosticism was enforced by two independent token sets in the same
plugin-gatejob, plus a stricter autonomy sweep, none of which shared data. The doctrine also named classes the gates did not check.Fix
scripts/org-agnosticism-tokens.txtis the single token file.validate-plugin-contracts.mjsreadsfleet-id,fleet-key,setup, andautonomyfrom it.plugins/github/github.test.shstays the documentedgithubextension (melodic/medley/pulumi plus github-iac); the validator fails if that regex drifts. Enforcement is deliberately those classes — agent content, schema files, and a fleet-wide bare organization name stay ungated.docs/PLUGIN-PHILOSOPHY.mdnow states that scope. The staged portability-lint publisher class is pointed at this file so it cannot become a third set.Verification
node scripts/validate-plugin-contracts.mjs— 51 setup skills and 2912 plugin files checkedbash plugins/github/github.test.sh— PASS=36 FAIL=0scripts/check-changelog-parity.sh --check-bump origin/main— passRelated
Refs #3127, #3139, #3115, #3182