fix(docs-hygiene): run under/at/on through the document-locator predicate (0.21.5)

[kyle-sexton]

Closes #3192

Summary

conversational-antecedent narrowed in from a blanket exemption to a document-locator check in #3162, but under, at, and on still exempted unconditionally. Conversational residue phrased with those prepositions escaped: "as we agreed on Tuesday", "as we decided at the standup", "as we agreed under time pressure".

Fix

All three now defer to audit_noise_follower_is_document_locator, the same predicate in already uses. The anaphoric-adverb followers (above / below / earlier / later / previously / elsewhere) stay unconditional.

Corpus measurement (1154 tracked .md files, minus **/evals/fixtures/** and CHANGELOG.md): conversational-antecedent count is 2 before and 2 after. T1 stayed 13. Routing on through the locator adds no new findings on this repo — the high-traffic on idioms (based on, depends on, on disk, on the other hand) never matched the antecedent pattern. The choice to narrow all three is therefore justified: recall goes up on the issue's own table, with a measured zero false-positive delta on the fleet corpus.

Verification

• detect.test.sh — 143 checks passed, covering the issue table plus high-traffic on idioms and the unchanged anaphoric above exemption
• Corpus sweep vs origin/main detector: conversational-antecedent 2→2; other shapes unchanged
• skill-quality:check docs-hygiene:audit-noise — PASS
• SKILL.md treatment row updated so it stays true

Related

• Refs feat(docs-hygiene): audit-noise gains three residue shapes (0.20.0) #3162 — narrowed in; recorded this as a deferred recall gap

[claude]

Claude finished @kyle-sexton's task in 1m 16s —— View job

---

Security review — no issues found

• Load /review:security-review skill instructions
• Fetch PR diff (commit a86d9dd, single-commit PR)
• Review changed files for security-relevant surface
• Apply skip gate / report findings

Skip gate: change has no security-relevant surface.

This PR touches only plugins/docs-hygiene/.claude-plugin/plugin.json (version bump), CHANGELOG.md, the SKILL.md treatment-table prose, a test fixture (detect.test.sh), and the regex-based classifier logic in noise-shapes.sh.

The functional change widens audit_noise_line_has_conversational_antecedent's case statement so under/at/on route through audit_noise_follower_is_document_locator (the same predicate in already used) instead of exempting unconditionally. This is pure [[ =~ ]] pattern matching over markdown prose already read by the auditing tool — no eval, no command execution built from file content, no new file writes, no path handling of externally controlled input, and no change to trust boundaries, permissions, or CI workflow files. The test file only adds static fixture strings and assertions.

No CRITICAL, IMPORTANT, or SUGGESTION findings.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a86d9dda9f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[github-actions]

Last security-reviewed head: a86d9dda9f78b6667b942a46a5188f0c8d72a513. On the next push, the relevance gate compares only the commits since this SHA; delete this comment to force a full re-review.

[claude]

Claude finished @cursor[bot]'s task in 24s —— View job

---

Code review — skipped (skip gate)

• Load /review:code-review skill instructions
• Check skip gate

Skip gate triggered: PR is closed (merged), not open.

Per the skill's skip gate, review stops here for a merged/closed PR — no findings are posted. (This run was triggered by a pull_request synchronize event on PR #3228, which is already MERGED.)

For context, Codex's automated review already flagged one point worth a look if this surfaces again on an open PR: noise-shapes.sh:185 — when the document locator after on/at/under is entirely inline code followed by punctuation (e.g. on `docs/design.md`,), the inline-code stripper can leave an empty head before the emptiness check runs, potentially causing a false-positive conversational-antecedent finding. Not independently verified here since review stopped at the gate.

[github-actions]

Claude has reviewed this PR 1 time. The lane skips further automatic reviews after 5; deleting this comment resets the count.