docs(ci): separate the absence and replay windows in the canary comment - #3066
Conversation
.github/workflows/silent-revert-canary.yml charged the whole 31h28m content-absence window to the replay's silence, so the workflow contradicted the two scripts its own job invokes. scripts/check-silent-revert.sh (#2930) and scripts/silent-revert-incidents.txt (#2986) already separate the two windows; this brings the last of the three sites into agreement. Both figures re-measured here from committer dates (%ct): absence f603880 1786752447 -> 534eac1 1786865745 = 113298s = 31h28m presence 7b47d22 1786843322 -> 534eac1 1786865745 = 22423s = 6h13m Both floored to the minute (113298s is 31h28m18s, 22423s is 6h13m43s), matching the convention the two sibling files already use. 7b47d22 (#2808, this canary's own merge) is an ancestor of main and its committer epoch falls strictly inside the absence interval, so the lane covered only the tail of that window. The load-bearing point is kept rather than deleted: across that tail the replay still printed `ok` and exited 0 with the content gone, because it answered the other question. Comment text only -- no executable YAML changed. Closes #2988 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LwdkpWf6bptu3AqTMoeg2H
|
Claude finished @kyle-sexton's task in 2m 9s —— View job Code review:
|
|
Claude finished @kyle-sexton's task in 44s —— View job Security review (
|
|
Last security-reviewed head: |
|
Claude has reviewed this PR 1 time. The lane skips further automatic reviews after 5; deleting this comment resets the count. |
Summary
.github/workflows/silent-revert-canary.ymlwas the third site of the claim #2917 set out to remove. Its comment charged the whole31h28mcontent-absence window to the replay's silence — so the workflow contradicted the twoscripts/files the job it documents actually invokes. This brings the last of the three sites into agreement.Fix
Comment text only, in one hunk. No
run:,uses:,with:, or any other executable YAML was touched (git diff --numstat=6 3on that one file; every+/-line begins with#).Before:
After:
The load-bearing point is preserved rather than deleted: the replay's silence still did not mean the content was present. What changes is which window that silence is charged to. "Both are needed" is kept deliberately — the
ORDER IS LOAD-BEARINGparagraph immediately below reads off it. The wording is the workflow's own rather than a lift from either sibling; in particular it keeps this file's "not this lane" voice instead of the scripts' "not this canary" / "not this file".Verification
Both figures re-derived here from committer dates (
git show -s --format=%ct), not carried over from the issue:f603880da1786752447534eac13817868657451132987b47d22531786843322534eac138178686574522423113298s= 31h28m18s and22423s= 6h13m43s; both are floored to the minute, matching the convention the two sibling files already use.7b47d2253is an ancestor ofmain(git merge-base --is-ancestorexit 0) and its committer epoch falls strictly inside the absence interval, which is what makes "only the tail" true.Repo-wide sweep for further sites: swept all tracked files for
31h28m,31h,6h13m,113298,22423, the three incident shas, and numberless restatements (exited 0 for,printed `ok`,while the replay,absence window). No fourth site exists. The only near-hit outside the three known files isplugins/claude-ops/skills/lanes/scripts/restart-consumer.test.sh:572— "lock-heldand exited 0 forever" about a Task Scheduler consumer — an unrelated sentence that merely shares the words. No follow-up issue needed.The change is comment-only, so no test asserts it; CI is the verification of record for the surrounding workflow, and the shell suites were not run locally (they run badly on this machine's platform).
The other two sites
Both siblings are already on
mainand untouched here — #2930 correctedscripts/check-silent-revert.sh, and #2986 (merged as0e9ed8eb0) correctedscripts/silent-revert-incidents.txt. This branch is merged up to amainthat carries both, so all three passages can be read side by side in one tree. The workflow was the last holdout.Related
scripts/check-silent-revert.shscripts/silent-revert-incidents.txtCloses #2988