refactor(guardrails): source shared machine-path pattern bodies by kyle-sexton · Pull Request #305 · melodic-software/claude-code-plugins

kyle-sexton · 2026-07-17T21:45:43Z

The guardrails lib's per-OS regex bodies were a hand-synced copy of the same bodies carried by ci-workflows' machine-specific-paths action and medley's tools/shared/path-detection. The bodies now live in machine-path-patterns.sh — the standards-managed materialization added by melodic-software/standards#172 — and the lib keeps only its own scan wrapping (OS-context suppression, exclusion pipes). Byte-identical to the canonical, so the first sync reconciles as a no-op. Guardrails bumped to 0.4.1.

Closes #301

feat(distribution): add path-detection component with shared machine-path regex bodies standards#172 (canonical component + manifest)
Source the standards-managed machine-path pattern bodies in the machine-specific-paths action ci-workflows#138, melodic-software/medley#1566 (sibling consumer refactors)

🤖 Generated with Claude Code

https://claude.ai/code/session_01S3Gt4Q3aggmM2Gb72aRmkr

The per-OS regex bodies were a hand-synced copy of the same bodies carried by ci-workflows' machine-specific-paths action and medley's tools/shared/path-detection. They now live in machine-path-patterns.sh — the standards-managed materialization (melodic-software/standards#171) — and the lib keeps only its own scan wrapping. Closes #301 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01S3Gt4Q3aggmM2Gb72aRmkr

claude · 2026-07-17T21:52:37Z

Claude finished @kyle-sexton's task in 1m 46s —— View job

Code Review

Gather context and read changed files
Review plugin.json version bump
Review hardcoded-path-patterns.sh changes
Review machine-path-patterns.sh new file
Assess correctness, security, and alignment with CLAUDE.md guidelines

Summary

Clean, correct refactor. The five HPP_* pattern bodies move from hardcoded-path-patterns.sh into a new define-only machine-path-patterns.sh, and the lib sources it with a ${BASH_SOURCE[0]%/*} relative path. Patterns are byte-identical to the originals; no behavior change. One observation worth noting and one minor nit.

Observations

Source chain is correct

hardcoded-path-check.sh sources hardcoded-path-patterns.sh, which now sources machine-path-patterns.sh:

hardcoded-path-check.sh → hardcoded-path-patterns.sh → machine-path-patterns.sh

When a script is sourced, BASH_SOURCE[0] in the sourced file resolves to the sourced file itself — so ${BASH_SOURCE[0]%/*} in hardcoded-path-patterns.sh correctly gives the directory where both files live. No path confusion with the call stack.

Pattern values are byte-identical

Comparing the old inline definitions (visible in git show b924796:…/hardcoded-path-patterns.sh) against machine-path-patterns.sh:

HPP_WIN_USER_BODY    ✓ identical
HPP_MACOS_USER_BODY  ✓ identical
HPP_LINUX_USER_BODY  ✓ identical
HPP_WIN_REPO_BODY    ✓ identical
HPP_ESCAPED_WIN_REPO_BODY  ✓ identical

The PR description's "byte-identical" claim checks out; no silent regex change.

SC2034 / SC1003 directives are correctly scoped

# shellcheck disable=SC2034 at file-level in machine-path-patterns.sh correctly suppresses the "appears unused" false positive for a define-only include. (line 4)
# shellcheck disable=SC1003 scoped to HPP_ESCAPED_WIN_REPO_BODY is correct — the doubled backslashes are deliberate ERE body, not a botched escape. (lines 35–38)

`# shellcheck source=` directive helps static analysis

The # shellcheck source=machine-path-patterns.sh annotation in hardcoded-path-patterns.sh (line 18) lets shellcheck resolve the sourced file and type-check the $HPP_* expansions downstream. Good hygiene.

Plugin-form safety (CLAUDE.md compliance)

${BASH_SOURCE[0]%/*} resolves within the plugin bundle — no ../ reach-outs, no assumption about CLAUDE_PLUGIN_ROOT. Complies with the repo's "Plugin-form-safe" rule.

Version bump is appropriate

0.4.0 → 0.4.1: a patch bump is right for a refactor with no interface change or new user-visible behavior.

One observation worth flagging

No in-repo sync mechanism for the upstream canonical.

The file header says this is "the standards-managed materialization" sourced from melodic-software/standards#172, but the plugin has no tooling (cron, CI job, or documented procedure) to pull updates when the canonical changes upstream. If standards#172 adds a new pattern body, this file silently drifts until someone notices.

This is outside the scope of a single PR to solve — the sibling consumer PRs (ci-workflows#138, medley#1566) have the same consideration. Worth a follow-up issue on the sync story (a renovate-style update job, a CI diff check, or at minimum a comment pointing to the update procedure). Not a blocker for merging.

Minor nit (non-blocking)

Module header ordering in machine-path-patterns.sh is slightly inverted: the # shellcheck disable=SC2034 pragma falls on line 4, before the module description block starting on line 5. Convention is # shellcheck shell=bash → description → pragmas → code. Functionally correct either way (file-level disables apply regardless of order), but the description-before-pragma order reads more naturally.

Verdict: approve. The refactor is correct, safe, and well-documented. The sync-mechanism gap is a known trade-off acknowledged by the PR scope.

Resolve plugin.json conflict in guardrails: compose main's minor bump (0.6.0, block-dangerous-git guard + eight-guard description) with this branch's patch bump for the path-detection refactor, giving 0.6.1. The version bump is the delivery vehicle for the shared-source .sh refactor; resolving to a bare 0.6.0 would not deliver it to consumers already on 0.6.0. Description takes main's eight-guard text (unchanged by this branch).

claude · 2026-07-18T21:44:16Z

Claude finished @kyle-sexton's task in 2m 1s —— View job

Code Review

Gather context and read changed files
Review plugin.json version bump
Review hardcoded-path-patterns.sh changes
Review machine-path-patterns.sh new file
Assess correctness, security, and CLAUDE.md alignment

Summary

Clean, correct refactor. The five HPP_* pattern bodies move from hardcoded-path-patterns.sh into a new define-only machine-path-patterns.sh, and the lib sources it with a ${BASH_SOURCE[0]%/*} relative path. Patterns are byte-identical to the originals; no behavior change.

Findings

Source chain is correct

hardcoded-path-check.sh → hardcoded-path-patterns.sh → machine-path-patterns.sh

When a script is sourced, BASH_SOURCE[0] in the sourced file resolves to the sourced file itself — so ${BASH_SOURCE[0]%/*} in hardcoded-path-patterns.sh correctly gives the directory where both files live. No path confusion with the call stack.

Pattern values are byte-identical

Comparing the removed inline definitions against machine-path-patterns.sh:

HPP_WIN_USER_BODY         ✓ identical
HPP_MACOS_USER_BODY       ✓ identical
HPP_LINUX_USER_BODY       ✓ identical
HPP_WIN_REPO_BODY         ✓ identical
HPP_ESCAPED_WIN_REPO_BODY ✓ identical

The PR description's "byte-identical" claim checks out; no silent regex change.

Shellcheck directives are correctly scoped

# shellcheck disable=SC2034 at file level in machine-path-patterns.sh correctly suppresses the "appears unused" false positive for a define-only include.
# shellcheck disable=SC1003 scoped to HPP_ESCAPED_WIN_REPO_BODY is correct — the doubled backslashes are deliberate ERE body.
# shellcheck source=machine-path-patterns.sh in hardcoded-path-patterns.sh lets shellcheck resolve the sourced file and type-check $HPP_* expansions downstream.

Plugin-form safety (CLAUDE.md compliance)

${BASH_SOURCE[0]%/*} resolves within the plugin bundle — no ../ reach-outs, no hardcoded CLAUDE_PLUGIN_ROOT. Complies with the repo's "Plugin-form-safe" rule.

Test coverage

hardcoded-path-check.test.sh uses black-box subprocess invocation through the full source chain, so the new machine-path-patterns.sh is exercised indirectly by the existing tests. No new test files needed.

Version bump

The PR commit bumps 0.4.0 → 0.4.1 (patch; correct for a behavior-preserving refactor). After the merge with main, the current plugin.json reflects 0.6.1 from subsequent feature additions on main — the merge correctly takes the higher version. The PR description's "Guardrails bumped to 0.4.1" is now stale but that's just a description artifact; the code is correct.

Carry-over observation (non-blocking)

No in-repo sync mechanism for the upstream canonical. The file header says this is "the standards-managed materialization" sourced from melodic-software/standards#172, but there is no tooling (cron, CI diff check, or documented procedure) to pull updates when the canonical changes upstream. The sibling consumer PRs (ci-workflows#138, medley#1566) have the same gap. Worth a follow-up issue on the sync story — not a blocker for merging.

Minor nit (non-blocking)

Module header ordering in machine-path-patterns.sh: the # shellcheck disable=SC2034 pragma on line 4 falls before the description block beginning on line 5. Convention is # shellcheck shell=bash → description → pragmas → code. Functionally correct either way (file-level disables apply regardless of order).

Verdict: approve. The refactor is correct, safe, and well-documented. The sync-mechanism gap is a known trade-off acknowledged by the PR scope.

… (0.6.2) Move the SC2034 pragma (with its rationale comment) after the module description block per shell=bash -> description -> pragma -> code convention, per claude[bot] review nit on PR #305. Comment-only change; patterns are unchanged.

claude · 2026-07-18T22:03:52Z

Claude finished @kyle-sexton's task in 1m 5s —— View job

Code Review

Gather PR diff and changed files
Review machine-path-patterns.sh (header fix commit)
Review hardcoded-path-patterns.sh
Verify version bump in plugin.json
Assess correctness, security, and CLAUDE.md alignment

Summary

The previous nit has been addressed. The commit 96a803a moves the SC2034 rationale comment and # shellcheck disable=SC2034 pragma to the end of the description block — the correct # shellcheck shell=bash → description → pragma → code ordering. This is a comment-only change; pattern bodies are unmodified.

Findings

Header ordering nit — resolved ✓

Before (f8ed920):

# shellcheck shell=bash
# SC2034 "appears unused" …    ← pragma before description
# shellcheck disable=SC2034
# Machine-specific path detection — shared per-OS regex BODIES …

After (96a803a):

# shellcheck shell=bash
# Machine-specific path detection — shared per-OS regex BODIES …
# …
# SC2034 "appears unused" …    ← rationale immediately before pragma
# shellcheck disable=SC2034
HPP_WIN_USER_BODY=…

The pragma now sits immediately before the code it guards, with its own rationale comment as context. This is the idiomatic placement.

Version bump

plugin.json: 0.6.1 → 0.6.2. Correct: patch bump for a comment-only change with no interface or behavior delta.

Carry-over (non-blocking, same as prior reviews)

No in-repo sync mechanism for the upstream canonical (melodic-software/standards#172). Still outside the scope of this PR; acknowledged by the author. Worth a follow-up issue on a renovate-style update job or CI diff check.

Verdict: approve. Prior nit addressed correctly; patterns are unchanged; version bump is appropriate. No new concerns.

kyle-sexton · 2026-07-18T22:05:16Z

Classification of the 2026-07-17 review findings:

#	Finding	Classification	Evidence	Reacted
1	No in-repo sync mechanism for pulling updates from the upstream canonical (`melodic-software/standards#172`)	VALID (defer) — out of scope for this PR	Sync tooling (a CI diff check, renovate-style update job, or documented procedure) is infrastructure owned by `melodic-software/standards`, the source-of-truth repo for shared policy per this repo's `CLAUDE.md` cross-repo ownership rules. This PR's scope is sourcing the shared pattern bodies into this consumer, not building the upstream sync mechanism. Noted for a follow-up issue in `standards`, not patched locally.	👍
2	Minor nit: `# shellcheck disable=SC2034` pragma (with its rationale comment) precedes the module description block in `machine-path-patterns.sh`, inverting the `shell=bash → description → pragma → code` convention	VALID — fixed	Reordered in commit `96a803a`: the SC2034 pragma + rationale comment now falls after the description block, immediately before the pattern definitions. Comment-only change — pattern bodies are byte-identical (verified via `git diff`), and `hardcoded-path-check.test.sh` still passes 28/28.	👍

kyle-sexton · 2026-07-18T22:05:22Z

Classification of the 2026-07-18 review findings (carry-over of the same 2 findings from the prior review, plus a non-actionable description-staleness note):

#	Finding	Classification	Evidence	Reacted
1	Carry-over: no in-repo sync mechanism for the upstream canonical (`melodic-software/standards#172`)	VALID (defer) — out of scope for this PR	Same reasoning as the prior review's classification — sync tooling belongs in `melodic-software/standards`, the source-of-truth repo, not this consumer PR.	👍
2	Carry-over: minor nit on `machine-path-patterns.sh` header/pragma ordering	VALID — fixed	Fixed in commit `96a803a` — see the classification reply on the prior review comment for detail.	👍
3	PR description's "Guardrails bumped to 0.4.1" is stale after the merge with `main`	INCORRECT (not a code issue)	The bot's own verdict already notes this is "just a description artifact; the code is correct" — `plugin.json` correctly carries the higher version through the merge (now `0.6.2` after this PR's fix commit). No code change needed.	👍

kyle-sexton · 2026-07-18T22:06:16Z

Acknowledged — the 2026-07-18 22:03 re-review confirms the header-ordering fix in commit 96a803a is correct, and reiterates the sync-mechanism observation as non-blocking/out of scope for this PR (tracked upstream in melodic-software/standards, not patched here). Both findings from this review cycle are settled; no further code changes needed.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 96a803a29d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Both versions bumped plugin.json without a changelog entry, so consumers updating deliberately (per docs/MIGRATION-PLAYBOOK.md's version-pinning model) had no way to see what changed. Per chatgpt-codex-connector's review on PR #305: document the SSOT refactor (0.6.1) and the header-ordering fix (0.6.2).

claude · 2026-07-18T22:08:43Z

Claude finished @kyle-sexton's task in 1m 16s —— View job

Code Review

Gather PR diff and identify changed files
Review CHANGELOG.md additions (0.6.1 + 0.6.2 entries)
Confirm all prior review findings settled
Verify plugin.json version and machine-path-patterns.sh header ordering
Post final verdict

Summary

The triggering commit (4f975df) adds the CHANGELOG entries flagged as missing by the Codex P2 review. All prior open findings are now settled.

CHANGELOG additions — correct ✓

CHANGELOG.md lines 6–26:

0.6.2 entry accurately describes the comment-only header ordering fix (SC2034 pragma + rationale comment moved after the description block). Scoped correctly as ### Changed.

0.6.1 entry accurately describes the machine-path body extraction: names all five HPP_* variables, references the upstream standards PR (melodic-software/standards#172), and correctly notes the patterns are byte-identical with no behavior change. The "hand-synced copy" framing matches the PR description. Scoped correctly as ### Changed.

Both entries are placed in descending-version order above the existing 0.6.0 entry — format is consistent with the rest of the file.

Prior findings status

Finding	Status
CHANGELOG missing 0.6.1 + 0.6.2 entries (Codex P2)	✅ Fixed — `4f975df`
Header ordering nit (`SC2034` pragma before description)	✅ Fixed — `96a803a`
No in-repo sync mechanism for upstream canonical	✅ Deferred — out of PR scope, acknowledged
Pattern byte-identity	✅ Verified in prior reviews
Plugin-form safety (`${BASH_SOURCE[0]%/*}`, no `../`)	✅ Compliant

Verdict: approve. The Codex P2 finding is addressed with accurate, well-scoped entries. No new concerns.

…#355) ## Summary Tranche 2 of wave #314 (epic #313, dim 8): the battle-tested markdown-format exemplar from #342 (six adversarial review rounds), cloned to the nine collision-free shape-A plugins. | Plugin | Version | apply write path | |---|---|---| | actionlint | 0.4.0 | none — guidance only | | bash-format | 0.5.0 | none — guidance only | | powershell-format | 0.4.0 | none — guidance only (module install is user-scope guidance) | | eol-normalizer | 0.4.0 | none — guidance only | | desktop-notification | 0.4.0 | none — probes only the current OS family's channel deps | | biome-format | 0.4.0 | `apply install-biome` — repo package manager (lockfile → packageManager → npm; Plug'n'Play → guidance) | | ruff-format | 0.4.0 | `apply install-ruff` — only into a managed env the repo already uses; never creates one | | firecrawl | 0.3.0 | none — defers to the plugin's lazy-install design; reports `FIRECRAWL_API_KEY` presence without printing it | | playwright | 0.3.0 | `apply install-cli` — stated-before-running global npm install | Contract invariants everywhere: `check` reads the plugin's own hook/skill source as single source of truth and probes what it actually does (no hand-copied lists to drift); `apply` re-checks first, names every write path in the argument-hint, states it before running, re-verifies after every remediation; never writes the plugin cache, user settings, or `pluginConfigs`; non-interactive when the action is supplied; `disable-model-invocation: true`. Also backfills the undocumented `[0.3.1]` CHANGELOG entries in actionlint and powershell-format (#298's hook-utils resync, verified via `git log -S`). **Deferred for lane ownership** (per the org WIP survey): disk-hygiene (PR #286 touches its plugin.json/CHANGELOG) and guardrails (PR #305 ditto) — they join a later tranche after those PRs land. ## Verification - `validate-plugins.sh`, `validate-plugin-contracts.mjs` (28 setup skills, 1513 files), markdownlint (55 files), `typos`: all green locally. ## Related - Part of #314 - Part of #313 No linked issue: tranche 2 of #314 — the issue closes with the wave's final tranche. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

## Summary Tranche 3 of wave #314 (epic #313, dim 8): all 17 remaining shape-B setups onto the uniform check/apply contract — refactors that preserve each plugin's own verification logic, plus two creates where the audit showed the listing was imprecise (claude-config shipped no setup; kindle-dedrm's setup was a router action, now a dedicated skill with the router delegating to it). | Plugin | Version | Notable | |---|---|---| | machine-health | 0.6.0 | interview → apply path; non-interactive disable/deprecate/demote/approve args | | source-control | 0.9.0 | carry-in: stale `install --config` reconfigure advice → fresh-install-only semantics | | toolchain | 0.4.0 | delivers the apply action its 0.3.0 entry forecast; per-ecosystem non-interactive scope | | claude-config | 0.6.0 | CREATE (audit: no setup shipped); README gains the bash prereq (dim-10 nit) | | claude-ops | 0.12.0 | freshness riders preserved verbatim; evals re-routed to explicit `apply` | | skill-quality | 0.5.0 | fixes README's dim-6 mis-framing of settings writes | | songwriting | 0.5.0 | one deliberate interactive exception: destructive-collision confirmation | | ai-briefing | 0.6.0 | verify+install fusion split (`apply install-build-deps`); 4 stale cross-refs in generate updated | | context7 | 0.4.0 | CLI/MCP dual-path check; `apply install-cli` gated | | discovery | 0.7.0 | gains the missing non-interactive arg path | | knowledge | 0.8.0 | ingest provisioners behind `apply install-deps` (verified standalone + idempotent) | | code-tidying / codebase-health | 0.5.0 | lanes / merged-config checks split from interview | | kindle-dedrm | 0.4.0 | dedicated setup skill; pinned-tag + Key_Finder guards untouched (referenced, not restated) | | planning | 0.20.0 | two-concern check incl. standards-index version delta; toggle carries `--config` semantics | | repo-fleet-hygiene | 0.2.0 | check split over existing arg grammar | | work-items | 0.11.0 | probes the tracker-seam gates as authoritative, never restates them | Contract refinements from tranches 1–2 embedded throughout: opt-in absence = INFO vs broken = FAIL; verify-after-remediation; secrets presence-only; env-var changes defer verification to a fresh session; `--config` fresh-install-only reconfigure guidance; non-interactive with complete arguments. Write-behavior evals re-routed to explicit `apply`. Root README catalog regenerated. With this PR, 27 of 31 plugins conform. Remaining: bug-report + miro (check-only carve-out PR with its one-line doctrine sanction), disk-hygiene + guardrails (deferred for the #286/#305 lanes), then the contract-gate check/apply rule as the closing tranche. ## Verification - `validate-plugins.sh` (incl. regenerated catalog), `validate-plugin-contracts.mjs` (31 setup skills, 1537 files), markdownlint (725 files), `typos`: all green locally. Agents additionally ran skill-quality checks on the six plugins in group D (all PASS). ## Related - Part of #314 - Part of #313 No linked issue: tranche 3 of #314 — the issue closes with the wave's final tranche. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

…ort, miro) (#361) ## Summary Resolves the wave #314 design question (raised in the issue before mass-refactoring bug-report/miro): where a plugin's **entire** configuration surface is native `userConfig` — no tracked project config, no prerequisite an install could resolve — an `apply` action would have nothing to write except the `pluginConfigs` the setup contract itself forbids. - **Doctrine** (`docs/PLUGIN-PHILOSOPHY.md`, setup section): one added sentence sanctioning the check-only shape for exactly that case. Kept in its own PR so the doctrine change is reviewable in isolation. - **bug-report 0.5.0**: `check` is the sole action; the interactive "ask whether reports should be private or repo-resident" step becomes a stated tradeoff with a recommendation (non-interactive); reconfigure guidance states `--config`'s fresh-install-only semantics; rechecks defer to a fresh session since the rendered value is injected at load. - **miro 0.2.0**: `check [verify-api]` — the optional read-only credential probe (list one board, count only) becomes an explicit argument instead of an in-flow question; token never read, printed, or persisted (unchanged). MCP server version realigned across `package.json`, the server `Implementation` version, the lockfile, and the rebuilt committed bundle (drift check + typecheck green; lockfile delta is the two version fields). With this, 29 of 31 wave plugins conform. Remaining: disk-hygiene + guardrails (deferred behind the #286/#305 lanes) and the closing contract-gate rule. ## Verification `validate-plugins.sh`, `validate-plugin-contracts.mjs`, markdownlint, `typos`, miro bundle drift check + typecheck: all green locally. ## Related - Part of #314 - Part of #313 No linked issue: carve-out slice of #314 — the issue closes with the wave's final tranche. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

) ## Summary Closing tranche of wave #314 (epic #313, dim 8) — with this PR, every plugin in the fleet conforms to the uniform setup contract and the contract is machine-enforced. - **disk-hygiene 0.4.0** — setup skill created (deferred until #286 landed): `check` probes Python 3.11+ (absolute-interpreter note), conditional Git, and the current OS family's documented lane (Linux `lsof` optional-execution note, macOS audit-only by design as INFO); guidance-only `apply`; disabled-toggle downgrade. - **guardrails 0.7.0** — setup skill created (deferred until #305 landed): `check` reads the guard scripts + `hooks.json` as truth and probes Bash 5.0+, `jq` (absence = every guard fails open — surfaced as FAIL), all eight guard toggles, the `cli-flag-verify` scan surface, and the `block-dangerous-git` allowlist; guidance-only `apply`. - **review 0.14.0** — its setup sat outside the wave list and was caught by the new gate on first run: adopts `check | apply` while keeping the standards-contract binding's by-reference discipline and explicit-confirmation gates intact. - **Contract gate** — `validate-plugin-contracts.mjs` now enforces the shape on every `skills/setup/SKILL.md`: `check` leads the `argument-hint`, the read-only check action is documented, and `apply` exists unless the skill declares the doctrine's check-only userConfig-only carve-out (#361). 33 setup skills pass fleet-wide; future setups are gated, not hand-reviewed. ## Verification `validate-plugins.sh`, `validate-plugin-contracts.mjs` (33 setup skills, 1541 files), markdownlint, `typos`: green locally. The gate change was validated by its own first catch (review). ## Related - Closes #314 - Part of #313 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

kyle-sexton mentioned this pull request Jul 18, 2026

feat: adopt the uniform setup contract across 9 formatter/CLI plugins #355

Merged

chatgpt-codex-connector Bot reviewed Jul 18, 2026

View reviewed changes

Comment thread plugins/guardrails/.claude-plugin/plugin.json

kyle-sexton merged commit 6d46311 into main Jul 18, 2026
14 checks passed

kyle-sexton deleted the refactor/path-detection-ssot branch July 18, 2026 22:11

This was referenced Jul 19, 2026

Conformance wave: setup-contract adoption (31 plugins) #314

Closed

feat: adopt the uniform setup contract across 17 shape-B plugins #360

Merged

kyle-sexton mentioned this pull request Jul 19, 2026

feat: check-only setup carve-out for userConfig-only plugins (bug-report, miro) #361

Merged

kyle-sexton mentioned this pull request Jul 19, 2026

feat: close the setup-contract wave — final setups + contract gate #362

Merged

Navigation Menu

Uh oh!

refactor(guardrails): source shared machine-path pattern bodies - #305

refactor(guardrails): source shared machine-path pattern bodies#305
kyle-sexton merged 4 commits into
mainfrom
refactor/path-detection-ssot

kyle-sexton commented Jul 17, 2026

Uh oh!

claude Bot commented Jul 17, 2026 •

edited

Loading

Uh oh!

claude Bot commented Jul 18, 2026 •

edited

Loading

Uh oh!

claude Bot commented Jul 18, 2026 •

edited

Loading

Uh oh!

kyle-sexton commented Jul 18, 2026

Uh oh!

kyle-sexton commented Jul 18, 2026

Uh oh!

kyle-sexton commented Jul 18, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

claude Bot commented Jul 18, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

kyle-sexton commented Jul 17, 2026

Related

Uh oh!

claude Bot commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review

Summary

Observations

Source chain is correct

Pattern values are byte-identical

SC2034 / SC1003 directives are correctly scoped

# shellcheck source= directive helps static analysis

Plugin-form safety (CLAUDE.md compliance)

Version bump is appropriate

One observation worth flagging

Minor nit (non-blocking)

Uh oh!

claude Bot commented Jul 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review

Summary

Findings

Source chain is correct

Pattern values are byte-identical

Shellcheck directives are correctly scoped

Plugin-form safety (CLAUDE.md compliance)

Test coverage

Version bump

Carry-over observation (non-blocking)

Minor nit (non-blocking)

Uh oh!

claude Bot commented Jul 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review

Summary

Findings

Header ordering nit — resolved ✓

Version bump

Carry-over (non-blocking, same as prior reviews)

Uh oh!

kyle-sexton commented Jul 18, 2026

Uh oh!

kyle-sexton commented Jul 18, 2026

Uh oh!

kyle-sexton commented Jul 18, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

claude Bot commented Jul 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review

Summary

CHANGELOG additions — correct ✓

Prior findings status

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

claude Bot commented Jul 17, 2026 •

edited

Loading

`# shellcheck source=` directive helps static analysis

claude Bot commented Jul 18, 2026 •

edited

Loading

claude Bot commented Jul 18, 2026 •

edited

Loading

claude Bot commented Jul 18, 2026 •

edited

Loading