feat(work-items): decompose prefactor, window sizing, integration-branch fallback - #2978
Conversation
…ment (#2944) Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
The confinement note in the local-markdown provider comparison pushed the file to 503 lines. Compress it so the skill-quality hard cap still passes. Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
…sue triggers (#2947) Work item stays canonical; ticket and issue are invocation synonyms on track/work. Cross-link the Shipping-course SSOT from the skills-repo record and make to-tickets/triage/wayfinder absorptions traceable on the v1.2 map. Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
…nch fallback (#2935) Adopt C5–C8 and C17: prefactor blockers, one-fresh-window sizing without token folklore, integration-branch fallback when expand-contract batches cannot land green alone, work-the-frontier reporting, and a PR-variant agent brief. Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
Security review — skipped (no security-relevant surface)
I reviewed the full diff (
Per the skip gate, stopping here with no further findings. |
|
Last security-reviewed head: |
Promote prefactor/window/fallback into short subsections, present unblocked slices first, name current-behavior-of-the-diff and finish-what-exists on the PR-variant brief, record Lane B as ADOPTED, and add the expand-contract default eval. Closes #2935. Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 844e04ed6a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…flow Standard /work-items:work still PRs against the default branch, so fallback items are not executable on that path (#2935 review).
…SOT lane sections Main took 0.35.26 (#2942) and 0.35.27 (#2947); this branch's decompose entries move to 0.35.28 with plugin.json bumped to match. Course SSOT keeps both the Lane B section (this PR) and the merged Lane W section; v12-map rows 15/16 keep this PR's deliberate CONVERGENT re-classification. Stacked leftovers from already-merged #2975/#2976 (track SKILL.md, CONTRACT.md, local-markdown README) resolve to main's versions. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CnzwTKoTa6xNY7iyEzMYpm
…ations Both this session and the Cursor session merged origin/main concurrently; this merge unifies them — v12-map rows 15/16 keep main's PARTIAL/DERIVED (matching the remote side's own resolution), version ladder stays 0.35.28. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CnzwTKoTa6xNY7iyEzMYpm
|
Claude finished @kyle-sexton's task in 1m 23s —— View job Security review — skipped (no security-relevant surface)
Per
Per the skip gate, this PR has no security-relevant surface:
Stopping here with no further findings, consistent with the prior review of this PR. |
|
Claude finished @kyle-sexton's task in 1m 21s —— View job Code review — skipped (PR merged)
Per PR #2978 is merged. Confirmed locally: the checkout for this task ( Stopping here per the skip gate, per instructions above. |
|
Claude has reviewed this PR 1 time. The lane skips further automatic reviews after 5; deleting this comment resets the count. |
<!-- CURSOR_AGENT_PR_BODY_BEGIN --> Closes #2943 ## Summary Long-running `/work-items:work` claims stay alive via mid-flight `renew-lease` (issue-comment PATCH), not GitHub branch-push activity. The worker is the durable renew actor during the blocked implement-dispatch wait; the orchestrator renews only after the worker returns. ## Fix - Record `lease_comment_id` from claim and enumerate it in the dispatch brief next to the PR-contract list. - Worker runs `"$TRACKER" renew-lease "<id>" --lease-comment-id <n>` at phase boundaries / before return. Orchestrator cannot timer-renew while waiting on the worker. - Expired renew is exit 7 → fresh claim, not a revive. - CONTRACT: GitHub PATCH has no If-Match/CAS (revalidation is intent, not a guarantee); clock skew; ttl-0 born-expired; comment-id monotonicity as an adapter requirement. - Eval case `work-mid-flight-renew-not-push-activity`. - work-items 0.35.27 → 0.35.28. Stacked on #2978 (decompose deltas). Merge after that PR, or rebase onto `main` once #2935 lands. ## Verification - `CHECK_SKILL_SKILLS_ROOT=$PWD bash plugins/skill-quality/scripts/check-skill.sh --require-evals plugins/work-items/skills/work` — PASS (0 errors) - `bash plugins/skill-quality/scripts/check-evals-quality.sh plugins/work-items/skills/work/evals/evals.json` — PASS - `bash plugins/work-items/tools/work-item-tracker/lib/lease.test.sh` — 19/19 PASS - `wc -l plugins/work-items/skills/work/SKILL.md` — 254 (under 500) ## Related Refs #2978 Refs #2933 <!-- CURSOR_AGENT_PR_BODY_END --> <div><a href="https://cursor.com/agents/bc-60311e3e-bf89-4375-aded-ebb9933c68fa?cursor_ref=pr_footer&cursor_cta=open_in_web"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a> <a href="https://cursor.com/background-agent?bcId=bc-60311e3e-bf89-4375-aded-ebb9933c68fa&cursor_ref=pr_footer&cursor_cta=open_in_cursor"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img alt="Open in Cursor" width="131" height="28" src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> </div> --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
Closes #2935
Summary
Adopts five decompose deltas from the Shipping-course audit: prefactor-first slices as blockers, one-fresh-window sizing beside S/M/L, an integration-branch fallback when expand-contract batches cannot land green alone, "work the frontier" in the report, and a PR-variant agent brief.
Fix
decomposeSKILL.md: C5–C8 (no token folklore; expand-contract remains the default).reference/agent-brief.md: PR-variant (current-behavior-of-the-diff / finish-what-exists).0.35.26→0.35.27. Approval gate, born-triaged, blockers-first publish unchanged.Verification
check-skill.sh --require-evals decomposePASS (183/500 lines).check-evals-quality.shPASS (4 cases).Related
Refs #2933. Stacked on #2976 (#2947) and #2975 (#2944).