Skip to content

feat(work-items): decompose prefactor, window sizing, integration-branch fallback - #2978

Merged
kyle-sexton merged 9 commits into
mainfrom
cursor/2935-decompose-deltas-68fa
Aug 17, 2026
Merged

feat(work-items): decompose prefactor, window sizing, integration-branch fallback#2978
kyle-sexton merged 9 commits into
mainfrom
cursor/2935-decompose-deltas-68fa

Conversation

@kyle-sexton

Copy link
Copy Markdown
Contributor

Closes #2935

Summary

Adopts five decompose deltas from the Shipping-course audit: prefactor-first slices as blockers, one-fresh-window sizing beside S/M/L, an integration-branch fallback when expand-contract batches cannot land green alone, "work the frontier" in the report, and a PR-variant agent brief.

Fix

  • decompose SKILL.md: C5–C8 (no token folklore; expand-contract remains the default).
  • reference/agent-brief.md: PR-variant (current-behavior-of-the-diff / finish-what-exists).
  • Evals cover the new rows. Course SSOT Lane B → PARTIAL.
  • Plugin 0.35.260.35.27. Approval gate, born-triaged, blockers-first publish unchanged.

Verification

  • check-skill.sh --require-evals decompose PASS (183/500 lines).
  • check-evals-quality.sh PASS (4 cases).

Related

Refs #2933. Stacked on #2976 (#2947) and #2975 (#2944).

Open in Web Open in Cursor 

cursoragent and others added 4 commits August 17, 2026 17:56
…ment (#2944)

Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
The confinement note in the local-markdown provider comparison pushed
the file to 503 lines. Compress it so the skill-quality hard cap still
passes.

Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
…sue triggers (#2947)

Work item stays canonical; ticket and issue are invocation synonyms on
track/work. Cross-link the Shipping-course SSOT from the skills-repo
record and make to-tickets/triage/wayfinder absorptions traceable on
the v1.2 map.

Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
…nch fallback (#2935)

Adopt C5–C8 and C17: prefactor blockers, one-fresh-window sizing without
token folklore, integration-branch fallback when expand-contract batches
cannot land green alone, work-the-frontier reporting, and a PR-variant
agent brief.

Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
@claude

claude Bot commented Aug 17, 2026

Copy link
Copy Markdown

Security review — skipped (no security-relevant surface)

  • Gather context (PR diff, changed files)
  • Apply skip gate (open PR? security-relevant surface? prior review?)
  • Review changed files for security issues
  • Report findings (or state none found)

I reviewed the full diff (git diff origin/main...HEAD, 14 files, +188/-20) per /review:security-review. Per that skill's skip gate, this PR has no security-relevant surface:

  • All changes are documentation and skill-guidance prose: docs/upstream/*.md, plugin README.md/CHANGELOG.md, SKILL.md frontmatter/body edits (decompose, setup, track, work), reference/agent-brief.md, CONTRACT.md, a new adapter operations README.md, evals.json test cases, and a plugin.json version bump (0.35.26 → 0.35.27).
  • No executable code, scripts, or GitHub Actions workflow files are touched.
  • No changes to authentication, authorization, credential handling, or network-facing logic — the local-markdown adapter docs describe existing claim-identity/auth behavior (git config user.name$USERlocal, no network/credentials) but don't change it.
  • No injection surfaces (command, SQL, path, template) are introduced.

Per the skip gate, stopping here with no further findings.

View job run

@github-actions

github-actions Bot commented Aug 17, 2026

Copy link
Copy Markdown

Last security-reviewed head: 8ad78104ee21253b4b79b03928812f4c9181b887. On the next push, the relevance gate compares only the commits since this SHA; delete this comment to force a full re-review.

Promote prefactor/window/fallback into short subsections, present unblocked
slices first, name current-behavior-of-the-diff and finish-what-exists on
the PR-variant brief, record Lane B as ADOPTED, and add the expand-contract
default eval. Closes #2935.

Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
@cursor

cursor Bot commented Aug 17, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 844e04ed6a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread plugins/work-items/skills/decompose/SKILL.md Outdated
cursoragent and others added 4 commits August 17, 2026 20:23
…flow

Standard /work-items:work still PRs against the default branch, so fallback
items are not executable on that path (#2935 review).
Bump work-items to 0.35.28 so #2935 sits above #2947's 0.35.27.
Keep main's local-markdown honesty wording and #2947 issue synonyms.
…SOT lane sections

Main took 0.35.26 (#2942) and 0.35.27 (#2947); this branch's decompose entries
move to 0.35.28 with plugin.json bumped to match. Course SSOT keeps both the
Lane B section (this PR) and the merged Lane W section; v12-map rows 15/16 keep
this PR's deliberate CONVERGENT re-classification. Stacked leftovers from
already-merged #2975/#2976 (track SKILL.md, CONTRACT.md, local-markdown README)
resolve to main's versions.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CnzwTKoTa6xNY7iyEzMYpm
…ations

Both this session and the Cursor session merged origin/main concurrently; this
merge unifies them — v12-map rows 15/16 keep main's PARTIAL/DERIVED (matching
the remote side's own resolution), version ladder stays 0.35.28.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CnzwTKoTa6xNY7iyEzMYpm
@claude

claude Bot commented Aug 17, 2026

Copy link
Copy Markdown

Claude finished @kyle-sexton's task in 1m 23s —— View job


Security review — skipped (no security-relevant surface)

  • Gather context (PR diff, changed files)
  • Apply skip gate (open PR? security-relevant surface? prior review?)
  • Review changed files for security issues
  • Report findings (or state none found)

Per /review:security-review, re-reviewed the commits added since the last reviewed head (98753d17b) through current HEAD 8ad78104ee21253b4b79b03928812f4c9181b887. The PR's six changed files remain unchanged in kind from the prior review:

Per the skip gate, this PR has no security-relevant surface:

  • No executable code, scripts, or GitHub Actions workflow files are touched — all changes are Markdown skill/reference prose, a changelog entry, an eval JSON fixture, and a semver bump.
  • No authentication, authorization, credential/token handling, or network-facing logic is added or changed.
  • No injection surfaces (command, SQL, path, template) are introduced.
  • The one open review thread on this PR (Codex's P1 comment about the integration-branch fallback not yet being wired into /work-items:work's execution path) is a functional-completeness / architecture concern, not a security issue — the SKILL.md text now explicitly documents that gap ("/work-items:work still provisions each item's worktree from the default branch... these fallback items are not executable on the standard work path") rather than silently mis-describing behavior, so there's no security-relevant deception or trust-boundary issue there either.

Stopping here with no further findings, consistent with the prior review of this PR.

@kyle-sexton
kyle-sexton merged commit 6d1b9b0 into main Aug 17, 2026
48 checks passed
@kyle-sexton
kyle-sexton deleted the cursor/2935-decompose-deltas-68fa branch August 17, 2026 20:54
@claude

claude Bot commented Aug 17, 2026

Copy link
Copy Markdown

Claude finished @kyle-sexton's task in 1m 21s —— View job


Code review — skipped (PR merged)

  • Gather context (PR diff, changed files, current PR state)
  • Apply skip gate (open PR? draft? already reviewed?)
  • Review changed files for correctness/maintainability — not applicable, see below

Per /review:code-review's skip gate: "PR is closed or not open" → stop early, post nothing else.

PR #2978 is merged. Confirmed locally: the checkout for this task (claude/pr-2978-20260817-2059) branches from origin/main's current tip, and that tip already contains this PR's changes and beyond — plugins/work-items/.claude-plugin/plugin.json on main is now at version 0.35.28 (past the 0.35.27 this PR bumped to). There's no longer a live diff against main to anchor inline findings to, and the two pre-existing reviews on this PR (Codex's P1 on the integration-branch fallback, and the author's reply marking it addressed) already cover the substantive discussion.

Stopping here per the skip gate, per instructions above.

@github-actions

Copy link
Copy Markdown

Claude has reviewed this PR 1 time. The lane skips further automatic reviews after 5; deleting this comment resets the count.

kyle-sexton added a commit that referenced this pull request Aug 17, 2026
<!-- CURSOR_AGENT_PR_BODY_BEGIN -->
Closes #2943

## Summary

Long-running `/work-items:work` claims stay alive via mid-flight
`renew-lease` (issue-comment PATCH), not GitHub branch-push activity.
The worker is the durable renew actor during the blocked
implement-dispatch wait; the orchestrator renews only after the worker
returns.

## Fix

- Record `lease_comment_id` from claim and enumerate it in the dispatch
brief next to the PR-contract list.
- Worker runs `"$TRACKER" renew-lease "<id>" --lease-comment-id <n>` at
phase boundaries / before return. Orchestrator cannot timer-renew while
waiting on the worker.
- Expired renew is exit 7 → fresh claim, not a revive.
- CONTRACT: GitHub PATCH has no If-Match/CAS (revalidation is intent,
not a guarantee); clock skew; ttl-0 born-expired; comment-id
monotonicity as an adapter requirement.
- Eval case `work-mid-flight-renew-not-push-activity`.
- work-items 0.35.27 → 0.35.28.

Stacked on #2978 (decompose deltas). Merge after that PR, or rebase onto
`main` once #2935 lands.

## Verification

- `CHECK_SKILL_SKILLS_ROOT=$PWD bash
plugins/skill-quality/scripts/check-skill.sh --require-evals
plugins/work-items/skills/work` — PASS (0 errors)
- `bash plugins/skill-quality/scripts/check-evals-quality.sh
plugins/work-items/skills/work/evals/evals.json` — PASS
- `bash plugins/work-items/tools/work-item-tracker/lib/lease.test.sh` —
19/19 PASS
- `wc -l plugins/work-items/skills/work/SKILL.md` — 254 (under 500)

## Related

Refs #2978
Refs #2933

<!-- CURSOR_AGENT_PR_BODY_END -->

<div><a
href="https://cursor.com/agents/bc-60311e3e-bf89-4375-aded-ebb9933c68fa?cursor_ref=pr_footer&cursor_cta=open_in_web"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-web-light.png"><img
alt="Open in Web" width="114" height="28"
src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a>&nbsp;<a
href="https://cursor.com/background-agent?bcId=bc-60311e3e-bf89-4375-aded-ebb9933c68fa&cursor_ref=pr_footer&cursor_cta=open_in_cursor"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img
alt="Open in Cursor" width="131" height="28"
src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a>&nbsp;</div>

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lane B: decompose deltas — prefactor-first, window sizing, integration-branch fallback, frontier phrasing, PR-variant briefs

3 participants