Skip to content

test(scripts): scope portability-suite fixture git commands with -C #2839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyle-sexton merged 1 commit into from
Aug 16, 2026
Merged

test(scripts): scope portability-suite fixture git commands with -C #2839

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions scripts/check-shell-portability.test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1543,14 +1543,14 @@ mkdir -p "$fx/scripts" "$fx/plugins/alpha/skills/demo/context"
cp "$SCRIPT" "$fx/scripts/"
out="$(
cd "$fx" &&
git init -q &&
git config user.email test@example.com &&
git config user.name test &&
git commit -q --allow-empty -m base &&
base="$(git rev-parse HEAD)" &&
git -C "$fx" init -q &&
git -C "$fx" config user.email test@example.com &&
git -C "$fx" config user.name test &&
git -C "$fx" commit -q --allow-empty -m base &&
base="$(git -C "$fx" rev-parse HEAD)" &&
printf '%s\n' 'stat -c %Y "$f"' >'plugins/alpha/skills/demo/context/mtime.md' &&
git add -A >/dev/null 2>&1 &&
git commit -q -m add-skill-md &&
git -C "$fx" add -A >/dev/null 2>&1 &&
git -C "$fx" commit -q -m add-skill-md &&
SHELL_PORTABILITY_TOKENS="$(one_token_list 'stat[[:space:]]+-c')" bash scripts/check-shell-portability.sh "$base" 2>&1
)"
rc=$?
Expand Down Expand Up @@ -1639,15 +1639,15 @@ cp "$SCRIPT" "$fx/scripts/"
quoted_name="$(printf 'quoted-\303\251.sh')" # trailing U+00E9 byte -- non-ASCII, triggers Git quoting
out="$(
cd "$fx" &&
git init -q &&
git config user.email test@example.com &&
git config user.name test &&
git commit -q --allow-empty -m base &&
base="$(git rev-parse HEAD)" &&
git -C "$fx" init -q &&
git -C "$fx" config user.email test@example.com &&
git -C "$fx" config user.name test &&
git -C "$fx" commit -q --allow-empty -m base &&
base="$(git -C "$fx" rev-parse HEAD)" &&
printf '%s\n' 'grep -Eq "\\bfoo\\b" "$file"' >'plain.sh' &&
printf '%s\n' 'grep -Eq "\\bfoo\\b" "$file"' >"$quoted_name" &&
git add -A >/dev/null 2>&1 &&
git commit -q -m add-scripts &&
git -C "$fx" add -A >/dev/null 2>&1 &&
git -C "$fx" commit -q -m add-scripts &&
SHELL_PORTABILITY_TOKENS="$(one_token_list '\\b')" bash scripts/check-shell-portability.sh "$base" 2>&1
)"
rc=$?
Expand Down
14 changes: 7 additions & 7 deletions scripts/check-skill-portability.test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -669,16 +669,16 @@ cp "$SCRIPT" "$fx/scripts/"
quoted_name="$(printf 'quoted-\303\251.md')" # trailing U+00E9 byte — non-ASCII, triggers Git quoting
out="$(
cd "$fx" &&
git init -q &&
git config user.email test@example.com &&
git config user.name test &&
git commit -q --allow-empty -m base &&
base="$(git rev-parse HEAD)" &&
git -C "$fx" init -q &&
git -C "$fx" config user.email test@example.com &&
git -C "$fx" config user.name test &&
git -C "$fx" commit -q --allow-empty -m base &&
base="$(git -C "$fx" rev-parse HEAD)" &&
mkdir -p 'plugins/p/skills/s' &&
printf 'diff against origin/main\n' >'plugins/p/skills/s/plain.md' &&
printf 'diff against origin/main\n' >"plugins/p/skills/s/${quoted_name}" &&
git add -A >/dev/null 2>&1 &&
git commit -q -m add-skills &&
git -C "$fx" add -A >/dev/null 2>&1 &&
git -C "$fx" commit -q -m add-skills &&
SKILL_PORTABILITY_TOKENS="$TEST_TOKENS" bash scripts/check-skill-portability.sh "$base" 2>&1
)"
rc=$?
Expand Down
Loading