Skip to content

fix(repo-fleet-hygiene): defer reclaimable-worktree to source-control - #2637

Merged
kyle-sexton merged 2 commits into
mainfrom
cursor/fix-fleet-reclaimable-ownership-f8b0
Aug 14, 2026
Merged

fix(repo-fleet-hygiene): defer reclaimable-worktree to source-control#2637
kyle-sexton merged 2 commits into
mainfrom
cursor/fix-fleet-reclaimable-ownership-f8b0

Conversation

@kyle-sexton

Copy link
Copy Markdown
Contributor

Closes #2605

Summary

reclaimable-worktree duplicated source-control:worktree's stranded-work axis with a weaker signal.

Fix

Demote/retire reclaimable-worktree emissions in favor of source-control ownership / handoff so fleet findings do not undercut the stronger stranded-work classifier.

Verification

See collector tests on PR checks.

Related

Refs #2601 — ignored-files safety on reclaimable classification.
Refs #2597 — fleet epic.

Open in Web Open in Cursor 

Stop emitting reclaimable-worktree from git status --porcelain. Name linked
unlocked worktrees in worktree-status-handoff and route stranded-work
classification to /source-control:worktree status (stranded/unknown outrank
stale). With source-control absent, name targets and the missing collaborator
instead of a weaker substitute verdict.

Closes #2605
Coordinates with #2601 by retiring the reclaimable axis that PR would harden.

Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
@cursor

cursor Bot commented Aug 14, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@kyle-sexton
kyle-sexton enabled auto-merge (squash) August 14, 2026 23:04
@claude

claude Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Claude finished @kyle-sexton's task in 1m 44s —— View job


Security review

  • Gather context (PR diff, changed files, CLAUDE.md)
  • Invoke /review:security-review per custom instructions
  • Post findings

No security issues found.

Reviewed the full diff (302a6fa...f21dbf3) against the /review:security-review skip gate and criteria:

  • The change is confined to the repo-fleet-hygiene plugin: a read-only fleet audit script (audit-fleet.sh), its test file, and docs/changelog/plugin metadata.
  • Net effect: removes git status --porcelain from the git_probe_allowed exact-match allowlist (L149-151 old) and retires the reclaimable-worktree / worktree-disposability-unverifiable findings in favor of a worktree-status-handoff finding that just names paths/branches and defers classification to /source-control:worktree status. This shrinks the allowed command surface rather than expanding it.
  • No new external/untrusted input is introduced — wt_path/wt_branch come from local git worktree list --porcelain output, same trust level as before, and are only ever written into report text via print_field/emit_finding (no eval, no shell re-interpretation, and per security-review.md these fields are %q-encoded so they can't forge report labels or terminal control sequences).
  • No .github/workflows files, auth/access-control logic, secrets/token handling, or injection-relevant surfaces are touched in this PR.
  • The test diff (audit-fleet.test.sh) explicitly asserts the retired status probe is now rejected by the allowlist, confirming the narrowing is intentional and enforced.

This meets the skill's skip-gate condition ("change has no security-relevant surface after reading the diff"), so no findings to report.

@github-actions

Copy link
Copy Markdown

Last security-reviewed head: f21dbf3b7ff420a3771e16f0d1a1c713adc64fab. On the next push, the relevance gate compares only the commits since this SHA; delete this comment to force a full re-review.

ShellCheck SC2034: the reclaimable porcelain probe was replaced by
source-control status handoff, but the local declaration remained.

Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
@kyle-sexton
kyle-sexton merged commit a2f3420 into main Aug 14, 2026
39 checks passed
@kyle-sexton
kyle-sexton deleted the cursor/fix-fleet-reclaimable-ownership-f8b0 branch August 14, 2026 23:18
@claude

claude Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Claude finished @cursor[bot]'s task in 21s —— View job


Code review

  • Gather context (PR diff, changed files, CLAUDE.md)
  • Invoke /review:code-review per custom instructions
  • Apply skip gate
  • Post result

Skip gate triggered — no review performed.

Per /review:code-review's skip gate: "PR is closed or not open." This PR (#2637) is merged, so there is no open working branch to review or post inline findings against, and the change has already landed on main. Posting a code review now would have no actionable target.

@github-actions

Copy link
Copy Markdown

Claude has reviewed this PR 1 time. The lane skips further automatic reviews after 5; deleting this comment resets the count.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

repo-fleet-hygiene: reclaimable-worktree duplicates source-control:worktree's stranded-work axis with a weaker signal

2 participants