Skip to content

feat(source-control): wire promotion-evidence fail-closed gate into babysit-loop partition - #2566

Merged
kyle-sexton merged 2 commits into
mainfrom
cursor/babysit-promotion-evidence-1695-d116
Aug 13, 2026
Merged

feat(source-control): wire promotion-evidence fail-closed gate into babysit-loop partition#2566
kyle-sexton merged 2 commits into
mainfrom
cursor/babysit-promotion-evidence-1695-d116

Conversation

@kyle-sexton

Copy link
Copy Markdown
Contributor

Closes #1695

Minimal in-repo peel implementing the frontier-consensus ruling: trusted promotion-evidence resolution contract on the rung partition with fail-closed behavior when evidence is unavailable, untrusted, partial, or forgeable. Does not enable autonomous merge on unqualified evidence. Full three-arm resolver deferred; --merge human-only launch pin stays until the seam qualifies.

Summary

  • Contract: skills/babysit-loop/reference/promotion-evidence-resolution.md — promotable cells (C2-auto-merge, C3-auto-merge), trusted seam requirement, fail-closed table, partition interaction
  • Partition: cycle-shape step 3 resolves effective promotion state before work-class eligibility; unavailable seam → every cell effective-unpromoted → no C2/C3 autonomous merge
  • Config: config-resolution.md notes the gate under merge dimension
  • Gotcha: SKILL.md documents that tracked rung alone is not merge permission
  • Version: source-control 0.53.24

Tests

  • Eval 10: promotion-evidence fail-closed at c3-autonomous tracked rung
  • Evals 2, 6–8 updated for promotion gate semantics
  • test_skill_contract.py::test_babysit_loop_promotion_evidence_contract_is_wired

Related

@github-actions github-actions Bot deleted a comment from claude Bot Aug 13, 2026
@claude

claude Bot commented Aug 13, 2026

Copy link
Copy Markdown

Claude encountered an error after 1s —— View job


I'll analyze this and get back to you.

@github-actions

Copy link
Copy Markdown

Warning

Automated security review did not complete — this is an infrastructure failure, not a review verdict.

Treat any Claude comment on this PR (including a placeholder like "I'll analyze this and get back to you") as incomplete, not "no findings."

The check is green on purpose, and it is not evidence. It certifies that a security pass ran, and this one did not complete — but the cause is outside this PR's control, so merging is deliberately left unblocked rather than locking every merge for the length of the outage. Nothing was reviewed at this head. Where this check is required, it is satisfied without that evidence; a human should review security-sensitive changes here before merging.

Re-run the job, or workflow_dispatch this workflow with the PR number, to retry the review (ci-workflows#227). A new push also retries it only if the caller's pull_request triggers include synchronize (the canonical security caller keeps it). An automatic retry may already have run — it is skipped when a partial review could duplicate comments, or when the failure class needs an operator.

Re-running does NOT help for every class:

  • rate-limit that persists across re-runs, or auth — the credential or usage budget needs an operator; retrying will not clear it.
  • a run that exhausted its turn budget ("subtype":"error_max_turns" above) will exhaust it again. As the PR author, split the change into smaller PRs; raising --max-turns is a change to the caller workflow, not something you can set on this PR.

…abysit-loop partition

Closes #1695.

Add trusted-seam promotion-evidence resolution contract to the rung partition:
unavailable, untrusted, partial, or forgeable evidence fail-closes C2/C3
autonomous merge regardless of tracked rung. Keep --merge human-only as the
safe operator pin until the seam qualifies. Full three-arm resolver deferred.

Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
@kyle-sexton
kyle-sexton marked this pull request as ready for review August 13, 2026 06:41
@cursor
cursor Bot force-pushed the cursor/babysit-promotion-evidence-1695-d116 branch from acb6aa2 to b32f766 Compare August 13, 2026 06:41
@cursor

cursor Bot commented Aug 13, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

Condense promotion-evidence gate wiring in cycle shape and drop the
duplicate gotcha so skill-quality-gate passes without losing contract
markers required by test_babysit_loop_promotion_evidence_contract_is_wired.

Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
@github-actions github-actions Bot deleted a comment from claude Bot Aug 13, 2026
@claude

claude Bot commented Aug 13, 2026

Copy link
Copy Markdown

Claude encountered an error after 0s —— View job


I'll analyze this and get back to you.

@github-actions

Copy link
Copy Markdown

Warning

Automated review did not complete — this is an infrastructure failure, not a review verdict.

Treat any Claude comment on this PR (including a placeholder like "I'll analyze this and get back to you") as incomplete, not "no findings."

Re-run the job, or workflow_dispatch this workflow with the PR number, to retry the review. A new push re-triggers this lane only if the caller's pull_request triggers include synchronize (the canonical caller omits it).
An automatic retry may already have run — it is skipped when a partial review could duplicate comments, or when the failure class needs an operator (auth).

@kyle-sexton
kyle-sexton merged commit db71b9a into main Aug 13, 2026
38 checks passed
@kyle-sexton
kyle-sexton deleted the cursor/babysit-promotion-evidence-1695-d116 branch August 13, 2026 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

babysit-loop: wire effective promotion-state resolution into the merge rung partition

2 participants