Skip to content

fix(work-items): work-loop audit peels for #1668 (F1–F3) - #2564

Merged
kyle-sexton merged 3 commits into
mainfrom
cursor/work-loop-audit-1668-d116
Aug 13, 2026
Merged

fix(work-items): work-loop audit peels for #1668 (F1–F3)#2564
kyle-sexton merged 3 commits into
mainfrom
cursor/work-loop-audit-1668-d116

Conversation

@kyle-sexton

@kyle-sexton kyle-sexton commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Closes #1668

Summary

Implements the three IMPLEMENT_NOW slices from frontier consensus on #1668 (F3 clamp, F2 eval rewrite, F1 telemetry Gotcha). Deferred slices recorded below — no new issues.

Fix

  • Clamp persisted item_cap into resolved [floor, ceiling] on durable-state re-read; report and persist
  • Rewrite drain-exit eval to retained-snapshot-ids-only (mode-drain.md)
  • Gotcha in telemetry-upsert.md for compound-shell classifier + isolated-calls fallback
  • work-items version bump

Verification

  • scripts/affected-tests.sh --run on touched paths
  • CI skill-quality / changelog-parity

Related

Deferred follow-ups stay as comments on #1668 (no new issues): F1 bundled script / autoMode.allow; F3 full quarantine; F4 pattern-escalation.

@cursor

cursor Bot commented Aug 13, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@github-actions github-actions Bot deleted a comment from claude Bot Aug 13, 2026
@github-actions github-actions Bot deleted a comment from claude Bot Aug 13, 2026
@claude

claude Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Claude encountered an error after 0s —— View job


I'll analyze this and get back to you.

@github-actions

github-actions Bot commented Aug 13, 2026

Copy link
Copy Markdown

Warning

Automated review did not complete — this is an infrastructure failure, not a review verdict.

Treat any Claude comment on this PR (including a placeholder like "I'll analyze this and get back to you") as incomplete, not "no findings."

Re-run the job, or workflow_dispatch this workflow with the PR number, to retry the review. A new push re-triggers this lane only if the caller's pull_request triggers include synchronize (the canonical caller omits it).
An automatic retry may already have run — it is skipped when a partial review could duplicate comments, or when the failure class needs an operator (auth).

@claude

claude Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Claude encountered an error after 0s —— View job


I'll analyze this and get back to you.

@github-actions

Copy link
Copy Markdown

Warning

Automated security review did not complete — this is an infrastructure failure, not a review verdict.

Treat any Claude comment on this PR (including a placeholder like "I'll analyze this and get back to you") as incomplete, not "no findings."

The check is green on purpose, and it is not evidence. It certifies that a security pass ran, and this one did not complete — but the cause is outside this PR's control, so merging is deliberately left unblocked rather than locking every merge for the length of the outage. Nothing was reviewed at this head. Where this check is required, it is satisfied without that evidence; a human should review security-sensitive changes here before merging.

Re-run the job, or workflow_dispatch this workflow with the PR number, to retry the review (ci-workflows#227). A new push also retries it only if the caller's pull_request triggers include synchronize (the canonical security caller keeps it). An automatic retry may already have run — it is skipped when a partial review could duplicate comments, or when the failure class needs an operator.

Re-running does NOT help for every class:

  • rate-limit that persists across re-runs, or auth — the credential or usage budget needs an operator; retrying will not clear it.
  • a run that exhausted its turn budget ("subtype":"error_max_turns" above) will exhaust it again. As the PR author, split the change into smaller PRs; raising --max-turns is a change to the caller workflow, not something you can set on this PR.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 467da129c3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread plugins/work-items/skills/work-loop/SKILL.md Outdated
- F3: clamp persisted item_cap to resolved [floor, ceiling] after durable-state
  re-read; report correction and persist clamped value; eval expects 5→3
- F2: align drain-terminal eval with mode-drain retained-snapshot-ids-only exit
- F1: Gotcha in telemetry-upsert.md for compound-shell classifier fallback

Bump work-items to 0.35.19.

Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
@cursor
cursor Bot force-pushed the cursor/work-loop-audit-1668-d116 branch from 467da12 to 9bac9cf Compare August 13, 2026 06:01
@github-actions github-actions Bot deleted a comment from claude Bot Aug 13, 2026
@claude

claude Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Claude encountered an error after 0s —— View job


I'll analyze this and get back to you.

cursoragent and others added 2 commits August 13, 2026 06:13
Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
@github-actions github-actions Bot deleted a comment from claude Bot Aug 13, 2026
@claude

claude Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Claude encountered an error after 0s —— View job


I'll analyze this and get back to you.

@kyle-sexton
kyle-sexton merged commit b636d88 into main Aug 13, 2026
38 checks passed
@kyle-sexton
kyle-sexton deleted the cursor/work-loop-audit-1668-d116 branch August 13, 2026 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

work-items:work-loop: 4 audit findings (compound-shell classifier risk, unvalidated persisted state, exit-condition prose, no pattern-escalation)

2 participants