Skip to content

feat(autofix-hooks): adopt content-mutation disclosure across remaining autofix hooks - #2555

Merged
kyle-sexton merged 1 commit into
mainfrom
cursor/fix-1596-mutation-disclosure-2ae1
Aug 13, 2026
Merged

feat(autofix-hooks): adopt content-mutation disclosure across remaining autofix hooks#2555
kyle-sexton merged 1 commit into
mainfrom
cursor/fix-1596-mutation-disclosure-2ae1

Conversation

@kyle-sexton

Copy link
Copy Markdown
Contributor

Fixes #1596

Summary

Closes the fleet-wide content-mutation disclosure tracker (#1596). Each remaining autofix hook that rewrites file content on Write/Edit now conforms to the hook-observability clause: when a rewrite occurs, the hook names what changed on the user channel (systemMessage) and stays silent on no-op paths.

Per-plugin disclosure behavior was already merged in the earlier wave (#2458, #2471#2477). This PR completes the tracker by:

Hook coverage

Plugin Disclosure Tests
eol-normalizer ✅ (prior #2458)
ruff-format ✅ added
bash-format ✅ added
go-format ✅ added
powershell-format ✅ (prior #2477)
biome-format ✅ (prior #2474)

Related

Add contract tests and #1596 rationale comments across the remaining autofix
hooks. Disclosure behavior was already landed per-plugin; this PR locks it with
tests where missing and documents the structural-layout rationale in hook
comments. Bump versions and CHANGELOG entries for touched plugins.

Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
@cursor

cursor Bot commented Aug 13, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@github-actions github-actions Bot deleted a comment from claude Bot Aug 13, 2026
@github-actions github-actions Bot deleted a comment from claude Bot Aug 13, 2026
@claude

claude Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Claude encountered an error after 1s —— View job


I'll analyze this and get back to you.

@github-actions

Copy link
Copy Markdown
Contributor

Warning

Automated review did not complete — this is an infrastructure failure, not a review verdict.

Treat any Claude comment on this PR (including a placeholder like "I'll analyze this and get back to you") as incomplete, not "no findings."

Re-run the job, or workflow_dispatch this workflow with the PR number, to retry the review. A new push re-triggers this lane only if the caller's pull_request triggers include synchronize (the canonical caller omits it).
An automatic retry may already have run — it is skipped when a partial review could duplicate comments, or when the failure class needs an operator (auth).

@claude

claude Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Claude encountered an error after 0s —— View job


I'll analyze this and get back to you.

@github-actions

Copy link
Copy Markdown
Contributor

Warning

Automated security review did not complete — this is an infrastructure failure, not a review verdict.

Treat any Claude comment on this PR (including a placeholder like "I'll analyze this and get back to you") as incomplete, not "no findings."

The check is green on purpose, and it is not evidence. It certifies that a security pass ran, and this one did not complete — but the cause is outside this PR's control, so merging is deliberately left unblocked rather than locking every merge for the length of the outage. Nothing was reviewed at this head. Where this check is required, it is satisfied without that evidence; a human should review security-sensitive changes here before merging.

Re-run the job, or workflow_dispatch this workflow with the PR number, to retry the review (ci-workflows#227). A new push also retries it only if the caller's pull_request triggers include synchronize (the canonical security caller keeps it). An automatic retry may already have run — it is skipped when a partial review could duplicate comments, or when the failure class needs an operator.

Re-running does NOT help for every class:

  • rate-limit that persists across re-runs, or auth — the credential or usage budget needs an operator; retrying will not clear it.
  • a run that exhausted its turn budget ("subtype":"error_max_turns" above) will exhaust it again. As the PR author, split the change into smaller PRs; raising --max-turns is a change to the caller workflow, not something you can set on this PR.

@kyle-sexton
kyle-sexton merged commit b1b1c22 into main Aug 13, 2026
38 checks passed
@kyle-sexton
kyle-sexton deleted the cursor/fix-1596-mutation-disclosure-2ae1 branch August 13, 2026 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adopt the content-mutation disclosure clause across the remaining autofix hooks

2 participants