feat(work-items): add work-loop invocation argument surface - #2537
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
Claude finished @kyle-sexton's task in 3m 11s —— View job Security Review —
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 066a008091
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Last security-reviewed head: |
|
Claude finished @cursor[bot]'s task in 2m 56s —— View job Security review complete
Scope: this PR's changed files only ( IMPORTANT — the advertised fail-closed argument rejection isn't actually specified in the skill, only in its evals The PR body claims: "Rejects
Fix: add the missing "argument surface" section to No other security-relevant issues found in this diff. The |
491ca08 to
5eae4e7
Compare
|
Claude finished @cursor[bot]'s task in 1m 23s —— View job Security Review —
|
5eae4e7 to
ea3116f
Compare
|
Claude finished @cursor[bot]'s task in 1m 28s —— View job Security Review —
|
|
Claude finished @cursor[bot]'s task in 6m 47s —— View job Code Review —
|
ea3116f to
448aa47
Compare
|
Claude finished @cursor[bot]'s task in 1m 16s —— View job Security Review —
|
|
Claude has reviewed this PR 3 times. The lane skips further automatic reviews after 5; deleting this comment resets the count. |
|
Claude finished @cursor[bot]'s task in 5m 44s —— View job Code Review —
|
Give /work-items:work-loop a minimal argv surface mirroring babysit-loop where appropriate: optional repo validation, --drain stop mode, --shard and --scope partitioning, --ordering, and --instance override. Reject merge/tier and cap tokens that cannot bind here. Progressive-disclosure stop-mode text lives in reference/mode-standing.md and reference/mode-drain.md. Fixes #1291 Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
…n with #1290 Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
Add invocation grammar with parse/validate/default/reject before telemetry or cycle work; sort admitted items on List items createdAt before cap fill; apply post-snapshot intake reporting on every drain exit path. Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
…eview (#1291) Rebase onto main with 0.35.17 changelog (0.35.16 attend-queue stays on main). Move invocation argument surface to reference/invocation-argv.md (468/500 lines). Fold persisted durable state into resolution order; update telemetry-upsert for --instance. Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
448aa47 to
a74c310
Compare
|
Claude finished @cursor[bot]'s task in 3m 11s —— View job Security Review —
|
|
Claude finished @cursor[bot]'s task in 2m 19s —— View job Code Review —
|
Fixes #1291
Summary
Gives
/work-items:work-loopa minimal invocation argument surface mirroring babysit-loop where appropriate:[<owner/repo>] [--drain] [--shard <i>/<n>] [--ordering oldest-first|newest-first] [--instance <id>] [--scope <label>]Rejects
--merge/ babysit tier / cap knobs fail-closed. Progressive disclosure moves stop-mode exit semantics intoreference/mode-standing.mdandreference/mode-drain.md.Bumps
work-itemsto 0.35.17 (0.35.16 reserved for #1290 attend-queue claim).Test plan
--drainwhere drain-terminal stop is expectedRelated