Skip to content

fix(claude-ops): make install_new userConfig prose substitution-safe (#2522) - #2530

Merged
kyle-sexton merged 1 commit into
mainfrom
cursor/fix-2522-install-new-prose-2ae1
Aug 13, 2026
Merged

fix(claude-ops): make install_new userConfig prose substitution-safe (#2522)#2530
kyle-sexton merged 1 commit into
mainfrom
cursor/fix-2522-install-new-prose-2ae1

Conversation

@kyle-sexton

@kyle-sexton kyle-sexton commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Fixes #2522

Summary

The install_new userConfig paragraph in plugins/claude-ops/skills/plugins/SKILL.md embedded ${user_config.install_new} inside explanatory prose about the unset state. Claude Code substitutes every occurrence, so when the key is set (e.g. to all) the paragraph falsely claims it still renders as the literal placeholder — right after the Configured value line already shows the real value.

This PR rewrites the explanation so only the Configured value line keeps the live ${user_config.install_new} token. Surrounding sentences describe the placeholder by shape (${user_config.…}) or by reference to that line, staying readable whether the key is set or unset.

Bumps claude-ops to 0.31.10 (0.31.9 reserved for in-flight hook-utils sync on #2450).

Test plan

  • No automated tests cover this prose contract.
  • Manual review: unset render — Configured value line shows the placeholder token; explanatory prose does not embed a second live ${user_config.install_new}.
  • Manual review: set render (e.g. all) — Configured value line shows all; explanatory prose still correctly describes unset behavior.

Related

@claude

claude Bot commented Aug 12, 2026

Copy link
Copy Markdown

Claude finished @kyle-sexton's task in 30s —— View job


Security Review

  • Gather context (diff against origin/main)
  • Apply skip gate
  • Post result

Skip gate: no security-relevant surface. This PR changes only:

  • plugins/claude-ops/.claude-plugin/plugin.json — version bump 0.31.80.31.10
  • plugins/claude-ops/CHANGELOG.md — changelog entry
  • plugins/claude-ops/skills/plugins/SKILL.md — prose rewording so the install_new userConfig explanation no longer embeds a second live ${user_config.install_new} substitution site inside its own unset-state explanation, keeping only the Configured value line as the live substitution point

No code, permissions, workflow triggers, injection surfaces, or trust boundaries are touched — this is a documentation-clarity fix. No security issues found.

@github-actions

github-actions Bot commented Aug 12, 2026

Copy link
Copy Markdown

Last security-reviewed head: 34eb89ad56bf0e9946aa3c86317487ccb3f140a7. On the next push, the relevance gate compares only the commits since this SHA; delete this comment to force a full re-review.

…2522)

Rewrite the install_new userConfig explanation so only the Configured value
line embeds the live placeholder; surrounding prose describes the token by
shape or by reference to that line, staying readable when the key is set.

Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
@cursor
cursor Bot force-pushed the cursor/fix-2522-install-new-prose-2ae1 branch from 9927ac5 to 34eb89a Compare August 12, 2026 23:54
@kyle-sexton
kyle-sexton marked this pull request as ready for review August 12, 2026 23:55
@cursor

cursor Bot commented Aug 12, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@claude

claude Bot commented Aug 12, 2026

Copy link
Copy Markdown

Claude finished @cursor[bot]'s task in 53s —— View job


Security Review

  • Gather context (gh pr diff against origin/main)
  • Apply skip gate
  • Post result

Skip gate: no security-relevant surface. This PR changes only:

  • plugins/claude-ops/.claude-plugin/plugin.json — version bump 0.31.90.31.10
  • plugins/claude-ops/CHANGELOG.md — changelog entry documenting the fix
  • plugins/claude-ops/skills/plugins/SKILL.md — prose rewording so the install_new userConfig explanation describes the substitution placeholder by shape/reference instead of embedding a second live ${user_config.install_new} token, keeping only the Configured value line as the substitution site

No code, permissions, workflow triggers, injection surfaces, or trust boundaries are touched — this is a documentation-clarity fix. No security issues found.

@claude

claude Bot commented Aug 12, 2026

Copy link
Copy Markdown

Claude finished @kyle-sexton's task in 49s —— View job


Security Review

  • Gather context (gh pr diff against origin/main)
  • Apply skip gate
  • Post result

Skip gate: no security-relevant surface. This PR changes only:

No code, permissions, workflow triggers, injection surfaces, or trust boundaries are touched — this is a documentation-clarity fix. No security issues found.

@claude

claude Bot commented Aug 13, 2026

Copy link
Copy Markdown

Claude finished @kyle-sexton's task in 1m 14s —— View job


Code Review (/review:code-review)

  • Gather context (gh pr diff, read the full install_new section in context)
  • Apply skip gate
  • Review diff against code-review criteria
  • Post result

Scope: 3 files — plugins/claude-ops/.claude-plugin/plugin.json (version bump), plugins/claude-ops/CHANGELOG.md (entry), plugins/claude-ops/skills/plugins/SKILL.md (prose rewrite). Pure documentation/prose change, no code or logic touched.

Verification performed:

No correctness, maintainability, or documentation-accuracy issues found. This is a narrowly-scoped, internally consistent prose fix — no findings to report.

Note: no linter/build applies to this Markdown-only change, so nothing further was run beyond reading the rendered result.

@github-actions

Copy link
Copy Markdown

Claude has reviewed this PR 1 time. The lane skips further automatic reviews after 5; deleting this comment resets the count.

@kyle-sexton
kyle-sexton merged commit e0ae44a into main Aug 13, 2026
40 of 42 checks passed
@kyle-sexton
kyle-sexton deleted the cursor/fix-2522-install-new-prose-2ae1 branch August 13, 2026 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

claude-ops plugins skill: the install_new userConfig paragraph is self-referential and unreadable once the key is set

2 participants