Skip to content

fix(babysit-prs): fail closed when PR commit walk hits 250 cap - #2395

Merged
kyle-sexton merged 1 commit into
mainfrom
cursor/babysit-prs-250-commit-cap-63e1
Aug 12, 2026
Merged

fix(babysit-prs): fail closed when PR commit walk hits 250 cap#2395
kyle-sexton merged 1 commit into
mainfrom
cursor/babysit-prs-250-commit-cap-63e1

Conversation

@kyle-sexton

@kyle-sexton kyle-sexton commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Fixes #2387.

fetch_pull_request_commits compares the walked row count to the PR's commits field and raises when GitHub's 250-commit endpoint ceiling truncates the list — preserving the over-report-only invariant for required-signatures enforcement.

Verification

  • tests.test_babysit_gh.FetchPullRequestCommitsTests: 3 tests OK

Related

@cursor

cursor Bot commented Aug 12, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@cursor
cursor Bot force-pushed the cursor/babysit-prs-250-commit-cap-63e1 branch from 1bf3ea7 to 22e8115 Compare August 12, 2026 07:31
@github-actions

github-actions Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Warning

Automated security review did not complete — this is an infrastructure failure, not a review verdict.

Treat any Claude comment on this PR (including a placeholder like "I'll analyze this and get back to you") as incomplete, not "no findings."

The check is green on purpose, and it is not evidence. It certifies that a security pass ran, and this one did not complete — but the cause is outside this PR's control, so merging is deliberately left unblocked rather than locking every merge for the length of the outage. Nothing was reviewed at this head. Where this check is required, it is satisfied without that evidence; a human should review security-sensitive changes here before merging.

Re-run the job to retry the review; a new push also retries it only if the caller's pull_request triggers include synchronize (the canonical security caller keeps it). An automatic retry may already have run — it is skipped when a partial review could duplicate comments, or when the failure class needs an operator.

Re-running does NOT help for every class:

  • rate-limit that persists across re-runs, or auth — the credential or usage budget needs an operator; retrying will not clear it.
  • a run that exhausted its turn budget ("subtype":"error_max_turns" above) will exhaust it again. As the PR author, split the change into smaller PRs; raising --max-turns is a change to the caller workflow, not something you can set on this PR.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1bf3ea712b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread plugins/source-control/skills/babysit-prs/scripts/babysit_gh.py
@github-actions

github-actions Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Warning

Automated review did not complete — this is an infrastructure failure, not a review verdict.

Treat any Claude comment on this PR (including a placeholder like "I'll analyze this and get back to you") as incomplete, not "no findings."

Re-run the job to retry the review. A new push re-triggers this lane only if the caller's pull_request triggers include synchronize (the canonical caller omits it).
An automatic retry may already have run — it is skipped when a partial review could duplicate comments, or when the failure class needs an operator (auth).

@cursor
cursor Bot force-pushed the cursor/babysit-prs-250-commit-cap-63e1 branch 2 times, most recently from f1d6f9e to e371c8c Compare August 12, 2026 09:36
Fixes #2387.

Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
@cursor
cursor Bot force-pushed the cursor/babysit-prs-250-commit-cap-63e1 branch from e371c8c to 74fe5f5 Compare August 12, 2026 09:45
@kyle-sexton
kyle-sexton merged commit 95d95a2 into main Aug 12, 2026
34 checks passed
@kyle-sexton
kyle-sexton deleted the cursor/babysit-prs-250-commit-cap-63e1 branch August 12, 2026 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants