fix(guardrails): forward git globals through convention-violation alias hops - #2372
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
Warning Automated security review did not complete — this is an infrastructure failure, not a review verdict. Treat any Claude comment on this PR (including a placeholder like "I'll analyze this and get back to you") as incomplete, not "no findings."
The check is green on purpose, and it is not evidence. It certifies that a security pass ran, and this one did not complete — but the cause is outside this PR's control, so merging is deliberately left unblocked rather than locking every merge for the length of the outage. Nothing was reviewed at this head. Where this check is required, it is satisfied without that evidence; a human should review security-sensitive changes here before merging. Re-run the job to retry the review; a new push also retries it only if the caller's Re-running does NOT help for every class:
|
|
Warning Automated review did not complete — this is an infrastructure failure, not a review verdict. Treat any Claude comment on this PR (including a placeholder like "I'll analyze this and get back to you") as incomplete, not "no findings."
Re-run the job to retry the review. A new push re-triggers this lane only if the caller's |
…as hops Fixes #2166. Plain-alias recursion sliced at gi+1 and dropped git's own -C between git and the subcommand, so a mid-merge git -C inner qc was gated in the wrong repository. Rebuild through sub_idx like block-dangerous-git. Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
ed95c3e to
089697d
Compare
Fixes #2166.
Plain-alias recursion in
block-convention-violationrebuilt argv throughgi+1, dropping git's own locating globals betweengitand the subcommand. A mid-mergegit -C inner qc -F -was content-gated in the payload repository instead of the moved-to one.Change: splice through
sub_idx(matchingblock-dangerous-git).Tests: base-failing
git -C inner qcsequencer case plus a no-MERGE_HEADdiscriminator.Related
Refs #2166