fix(autonomy): name the field the deterministic/model slot split turns on - #2346
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a4aad2ce56
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…s on The schema and the checker key the entire split on `scanner_class` — which relational constraints and predicates are legal on a slot, which floor it counts toward, and whether distinctness is judged by scanner class or by resolved model identity. The normative leaf described the split only in prose and never named the field. That left the contract unable to answer the first question a binding author asks it: how do I declare a deterministic slot. A contract whose own vocabulary is discoverable only by reading the validator is the inverse of the arrangement this leaf exists to establish. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0133WoxqBf7kLDviEfrcYL5Z
a4aad2c to
89b5709
Compare
|
Warning Automated security review did not complete — this is an infrastructure failure, not a review verdict. Treat any Claude comment on this PR (including a placeholder like "I'll analyze this and get back to you") as incomplete, not "no findings."
The check is green on purpose, and it is not evidence. It certifies that a security pass ran, and this one did not complete — but the cause is outside this PR's control, so merging is deliberately left unblocked rather than locking every merge for the length of the outage. Nothing was reviewed at this head. Where this check is required, it is satisfied without that evidence; a human should review security-sensitive changes here before merging. Re-run the job to retry the review; a new push also retries it only if the caller's Re-running does NOT help for every class:
|
|
Warning Automated review did not complete — this is an infrastructure failure, not a review verdict. Treat any Claude comment on this PR (including a placeholder like "I'll analyze this and get back to you") as incomplete, not "no findings."
Re-run the job to retry the review. A new push re-triggers this lane only if the caller's |
1 participant
Summary
Post-merge sweep of #2326 found the verification-topology leaf never names
scanner_class, the field the schema and checker key the entire deterministic/model slot split on.The field decides which relational constraints and predicates are legal on a slot, which floor it counts toward, and whether distinctness is judged by scanner class or by resolved model identity. The leaf described the split in prose — "a slot is filled by either a DETERMINISTIC layer or a MODEL-ADJUDICATED role" — and left the reader no way to write one.
A binding author reading the normative contract could not declare a deterministic slot without reading the validator source. That inverts the arrangement the leaf exists to establish.
Test plan
node scripts/validate-plugin-contracts.mjs— 45 setup skills, 2398 files.bash scripts/check-changelog-parity.sh --check— passes.python scripts/sync-plugin-options-docs.py --check— passes.grep -rniE "frontier|flagship|daily driver" plugins/autonomy/reference/— empty.grep -c blockingover the narration lane's section — 0.Related
No linked issue — found by a post-merge consistency sweep of #2326's contract surface against its own implementation, and small enough to fix directly rather than file and queue.