fix(repo-hygiene): widen AskUserQuestion fallback for dontAsk denial - #2255
Conversation
Fixes #2088 Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
Claude finished @kyle-sexton's task in 39s —— View job Security Review
Scope: Summary: This PR is a prose-only correction to the The actual behavioral change tightens a security-relevant guard rather than loosening one: it widens the condition for falling back to an inline (non-fabricatable) question from "AskUserQuestion is absent" to "absent, denied, or otherwise unusable" — closing a gap where a No security issues found in the changed files. No CRITICAL/IMPORTANT/SUGGESTION findings to report. |
|
Claude finished @kyle-sexton's task in 1m 11s —— View job Code Review
Scope: SummaryThis does exactly what it says: it widens the Correctness verified:
Minor, non-blocking observation: the new claude-code-plugins/plugins/repo-hygiene/CHANGELOG.md Lines 10 to 18 in 9dddf89 No correctness, architecture, error-handling, or test-coverage issues found — this is a scoped prose fix with no executable code, consistent with the "prose-only, no shell/python suites map to this file" verification note (author-claimed, not independently re-run by me since there is no test suite to run against this change). |
|
Claude has reviewed this PR 1 time. The lane skips further automatic reviews after 5; deleting this comment resets the count. |
Summary
Mirror the #2016
disk-hygieneconfirmation-gate prose fix inrepo-hygiene: the inline-question fallback must trigger whenAskUserQuestionis absent, denied, or otherwise unusable — not only when it is absent.Fix
plugins/repo-hygiene/skills/clean/SKILL.mdconfirmation gate question-surface rule to match the correcteddontAsk/ deny / disallowed-tools wording.Verification
Prose-only change; no shell/python suites map to this file. Reviewed against the live permissions docs claim cited in #2088 and the merged
disk-hygienesibling wording.Related
Fixes #2088 (completes the three-item sweep alongside #2252 and #2254).