Skip to content

docs(guardrails): block-dangerous-git contract names Bash and PowerShell - #2242

Merged
kyle-sexton merged 1 commit into
mainfrom
cursor/block-dangerous-git-powershell-docs-63e1
Aug 12, 2026
Merged

docs(guardrails): block-dangerous-git contract names Bash and PowerShell#2242
kyle-sexton merged 1 commit into
mainfrom
cursor/block-dangerous-git-powershell-docs-63e1

Conversation

@kyle-sexton

Copy link
Copy Markdown
Contributor

Summary

Reword the opening contract comment in block-dangerous-git.sh so it names both
tool surfaces the hook is registered for. The hooks.json matcher is
Bash|PowerShell, and the file already documents the bundled PowerShell grammar
classifier a few lines below — only the first sentence still said Bash-only.

Docs accuracy only; no behavior change.

Fixes #2145

Test plan

  • scripts/affected-tests.sh --run plugins/guardrails/hooks/block-dangerous-git.sh
    — PASS=381 FAIL=0

Related

@cursor

cursor Bot commented Aug 11, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

Reword the opening header comment so the contract statement matches the
hooks.json matcher (Bash|PowerShell) and the in-file PowerShell classifier
note. Docs accuracy only; no behavior change.

Fixes #2145

Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
@cursor
cursor Bot force-pushed the cursor/block-dangerous-git-powershell-docs-63e1 branch from 7ae2299 to 4d985a8 Compare August 11, 2026 23:24
@github-actions

Copy link
Copy Markdown

Warning

Automated security review did not complete — this is an infrastructure failure, not a review verdict.

Treat any Claude comment on this PR (including a placeholder like "I'll analyze this and get back to you") as incomplete, not "no findings."

The check is green on purpose, and it is not evidence. It certifies that a security pass ran, and this one did not complete — but the cause is outside this PR's control, so merging is deliberately left unblocked rather than locking every merge for the length of the outage. Nothing was reviewed at this head. Where this check is required, it is satisfied without that evidence; a human should review security-sensitive changes here before merging.

Re-run the job to retry the review; a new push also retries it only if the caller's pull_request triggers include synchronize (the canonical security caller keeps it). An automatic retry may already have run — it is skipped when a partial review could duplicate comments, or when the failure class needs an operator.

Re-running does NOT help for every class:

  • rate-limit that persists across re-runs, or auth — the credential or usage budget needs an operator; retrying will not clear it.
  • a run that exhausted its turn budget ("subtype":"error_max_turns" above) will exhaust it again. As the PR author, split the change into smaller PRs; raising --max-turns is a change to the caller workflow, not something you can set on this PR.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7ae229946a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread plugins/claude-ops/skills/observability/context/otel-queries.md Outdated
@github-actions

Copy link
Copy Markdown

Warning

Automated review did not complete — this is an infrastructure failure, not a review verdict.

Treat any Claude comment on this PR (including a placeholder like "I'll analyze this and get back to you") as incomplete, not "no findings."

Re-run the job to retry the review. A new push re-triggers this lane only if the caller's pull_request triggers include synchronize (the canonical caller omits it).
An automatic retry may already have run — it is skipped when a partial review could duplicate comments, or when the failure class needs an operator (auth).

@kyle-sexton
kyle-sexton merged commit ab012e2 into main Aug 12, 2026
34 checks passed
@kyle-sexton
kyle-sexton deleted the cursor/block-dangerous-git-powershell-docs-63e1 branch August 12, 2026 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs(guardrails): block-dangerous-git's contract line says Bash-only; the matcher is Bash|PowerShell

2 participants