docs(guardrails): block-dangerous-git contract names Bash and PowerShell - #2242
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Reword the opening header comment so the contract statement matches the hooks.json matcher (Bash|PowerShell) and the in-file PowerShell classifier note. Docs accuracy only; no behavior change. Fixes #2145 Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
7ae2299 to
4d985a8
Compare
|
Warning Automated security review did not complete — this is an infrastructure failure, not a review verdict. Treat any Claude comment on this PR (including a placeholder like "I'll analyze this and get back to you") as incomplete, not "no findings."
The check is green on purpose, and it is not evidence. It certifies that a security pass ran, and this one did not complete — but the cause is outside this PR's control, so merging is deliberately left unblocked rather than locking every merge for the length of the outage. Nothing was reviewed at this head. Where this check is required, it is satisfied without that evidence; a human should review security-sensitive changes here before merging. Re-run the job to retry the review; a new push also retries it only if the caller's Re-running does NOT help for every class:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7ae229946a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Warning Automated review did not complete — this is an infrastructure failure, not a review verdict. Treat any Claude comment on this PR (including a placeholder like "I'll analyze this and get back to you") as incomplete, not "no findings."
Re-run the job to retry the review. A new push re-triggers this lane only if the caller's |
Summary
Reword the opening contract comment in
block-dangerous-git.shso it names bothtool surfaces the hook is registered for. The
hooks.jsonmatcher isBash|PowerShell, and the file already documents the bundled PowerShell grammarclassifier a few lines below — only the first sentence still said Bash-only.
Docs accuracy only; no behavior change.
Fixes #2145
Test plan
scripts/affected-tests.sh --run plugins/guardrails/hooks/block-dangerous-git.sh— PASS=381 FAIL=0
Related