docs(conventions): align permission-rule-hygiene quotes with current skills page (row 156 dependency pass) - #2060
Conversation
…skills page
Row 156's page-level close owed a dependency pass over the other 33 files
citing code.claude.com/docs/en/skills. The pass found two stale claims,
both in permission-rule-hygiene:
- Drop the `${CLAUDE_SKILL_DIR}` v2.1.129 version floor attributed to the
skills page: the live page no longer documents any floor for that
substitution, only `${CLAUDE_PROJECT_DIR}` requiring v2.1.196+.
- Re-quote the `allowed-tools` grant sentence: the page now scopes the
grant to "the turn that invokes the skill" (clearing on the next
message), not "while the skill is active". The turn scoping strengthens
the anti-pattern-3 argument unchanged.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HbtPzLRe1yBavNpsmv5Tum
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
Claude finished @kyle-sexton's task in 2m 7s —— View job Review complete
ScopeSingle-file docs edit,
Not independently verified (author-claimed only): the FindingsOne non-blocking inline nit posted on L99-100: splicing three quoted source fragments as grammatical objects of "It" is a bit strained since two of the three are themselves full sentences in the source. Purely a prose-polish suggestion — the content is accurate and the quotes are verbatim. No correctness, architecture, or maintainability issues found otherwise. The PR is a well-scoped, well-cited docs correction; no versioned plugin surface is touched, consistent with the PR description. |
|
Claude has reviewed this PR 3 times. The lane skips further automatic reviews after 5; deleting this comment resets the count. |
… sentences Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HbtPzLRe1yBavNpsmv5Tum
|
Claude finished @kyle-sexton's task in 2m 13s —— View job Review complete
What changed since my last reviewCommit
FindingsOne non-blocking inline nit on L99-101: the two re-quoted fragments now close with a period inside the quotation marks at a point where the live source actually has a comma and continues the sentence — overstating quote fidelity in a doc whose entire premise is verbatim-checked citations. Ironically this traces back to my own prior suggested wording; flagging it now since I independently re-verified the exact source punctuation this pass. No other issues found. Scope, sourcing methodology, and the two substantive claim corrections remain sound; no versioned plugin surface is touched. Not independently verified (author-claimed only): |
The first fragment continues in the source, so the period inside its closing quote claimed a sentence end the live page does not have; the semicolon now sits outside the quotation. The second fragment is a complete source sentence and keeps its period. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HbtPzLRe1yBavNpsmv5Tum
|
Claude finished @kyle-sexton's task in 2m 1s —— View job Review complete
What changed since my last reviewCommit I re-fetched
Fragment 1 ("...invokes the skill") — now correctly un-punctuated at the closing quote, matching the source's comma-continuation. Fixed, confirmed accurate. Fragment 3 ("does not restrict which tools are available") — unchanged, still verbatim. Confirmed accurate. One remaining subtlety (FYI only, not requiring further action): fragment 2, FindingsNo blocking issues. The Not independently verified (author-claimed only): the Scope, sourcing methodology, and both substantive claim corrections remain sound. No versioned plugin surface is touched, consistent with the PR description. |
Summary
Executes row 156's owed dependency pass (the optional follow-up on #1989): the page-level DONE close of the Extend Claude with skills roster row had checked only
plugins/playbooks/skills/fable-5/context/verification.md, owing a pass over the other citing files.Enumeration: re-derived by
git grep -E 'code\.claude\.com/docs/en/skills([^a-z-]|$)'at origin/main958f9579— 36 files / 59 citing lines (the row's count of 34 was taken at81c0297d87; main has moved). The live page was re-fetched raw (HTTP 200, 82,668 B) and has changed since the row's 2026-08-06 baseline (78,513 B, MD5 differs), so every citation was checked against the current page.Result: 35 of 36 files conformant; 2 stale claims, both in
docs/conventions/permission-rule-hygiene/README.md, fixed here:${CLAUDE_SKILL_DIR}v2.1.129 floor dropped — the sentence attributed both substitution version floors to the skills page; the live page now documents only the${CLAUDE_PROJECT_DIR}floor ("The${CLAUDE_PROJECT_DIR}substitution requires Claude Code v2.1.196 or later"). The 2.1.129 claim is no longer supported by its cited source.allowed-toolsgrant quote re-quoted — the page no longer says the grant holds "while the skill is active"; it now reads "grants permission for the listed tools during the turn that invokes the skill" and "The grant clears when you send your next message". Semantic upstream change (turn-scoped, not skill-active-scoped); the anti-pattern-3 argument survives strengthened. Bullet lead re-worded "skill-scoped" → "turn-scoped" to match.Notable conformant checks (representative): namespace claim verbatim at live page (3 citing files); invocation-control table "Description not in context" (skill-quality scripts/tests/CHANGELOG, discipline, claude-config criteria); 1,536-char truncation verbatim;
context: fork/agent/ lifecycle / 5,000-token compaction quotes verbatim;${CLAUDE_PLUGIN_ROOT}still absent from the page (the convention's negative claim holds); v2.1.145 / v2.1.215 / v2.1.216 bundled-skill claims verbatim (testing, verification, review, playbooks). The spec-validation absence claim inverification.mdstill holds: the commands page now has 14[Skill]rows and one[Workflow]row (/deep-research); none is spec-validation, so the row's recheck trigger has not fired. A repo-wide sweep for the two stale phrases found no other live occurrence (remaining hits aredisallowed-toolsprose matching the live page, historical CHANGELOG entries, and one unrelateddocs/PLUGIN-PHILOSOPHY.mdsentence that is the repo's own prose, not a docs quote).No plugin versioned surface is touched — repo docs only, no version bump.
Test plan
git grepsweep for2\.1\.129andwhile the skill is active— no other live occurrencemarkdownlint-cli2on the changed file — 0 errorsRelated
No linked issue — this is the optional row-156 dependency pass tracked under umbrella #1989 (kept open deliberately; no closing keyword).
🤖 Generated with Claude Code
https://claude.ai/code/session_01HbtPzLRe1yBavNpsmv5Tum