docs: codify the policy/behavioral hook-classification rubric - #2033
Conversation
Promote the #2021 audit's classification method into standing doctrine in PLUGIN-PHILOSOPHY's Instruction economy section: the two-axis rubric (mechanism x class), the hybrid category's trim-not-delete rule, the ground-truth-oracle carve-out, and the config-disable-first remediation order — so downstream consumer repos can run the same pass over their own hook surfaces at each generation-triggered ablation. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
Claude finished @kyle-sexton's task in 2m 56s —— View job Review: PR #2033 — docs: codify the policy/behavioral hook-classification rubric
SummaryDocs-only change (
Two prose-clarity issues left as inline comments, both fixable without touching the underlying rubric:
Not independently verified
Scope check (CLAUDE.md fresh-docs mandate)This change describes a classification methodology for existing hooks, not a change to a hook contract, manifest schema, or documented harness behavior itself — no new claims about No plugin manifests, catalog, or contract-surface files are touched, consistent with the PR's own verification note. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 63fe5e48ac
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Claude has reviewed this PR 2 times. The lane skips further automatic reviews after 5; deleting this comment resets the count. |
Review findings: the subsection's opening sentence lacked a finite verb; "the evidence gate above" did not resolve to a named rule. The remediation sentence now names Evidence-gated additions explicitly and states the symmetry (same evidentiary rigor for removal as for addition). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Claude finished @kyle-sexton's task in 1m 22s —— View job Review: PR #2033 — docs: codify the policy/behavioral hook-classification rubric
SummaryFollow-up commit
No new issues found in the fix commit. The section's cross-references still check out against the current file:
Not independently verified
Scope check (CLAUDE.md fresh-docs mandate)Unchanged from the prior pass: this describes a classification methodology for existing hooks, not a hook-contract/manifest/harness-behavior change, so the fresh-docs citation requirement isn't triggered. No plugin manifests or contract-surface files are touched. |
|
All three threads addressed. The two prose findings are fixed in f3409ed (finite-verb rewrite; the remediation sentence now names Evidence-gated additions explicitly and states the addition/removal symmetry). The codex P2 (unhobble's classification contract cannot represent a hybrid hook entry, so its strip plan contradicts trim-not-delete) is accepted and lands as its own small claude-config PR immediately after #2054 merges — the two would otherwise collide on the claude-config version from the same base (#1746 class). This PR stays docs-only. |
#2067) No linked issue ## Summary Aligns the unhobble skill's classification contract with the hybrid hook rubric merged in #2033 — the follow-up promised on that PR's codex thread. Previously a hook entry carrying both a policy gate and behavioral prose could only be over-stripped (wiring removed whole) or over-kept, contradicting the rubric's trim-not-delete rule. ## Fix - Phase 1 adds the `hybrid` class per hook entry, delegating the rubric itself (mechanism vs class, trim-not-delete, ground-truth-oracle carve-out) to PLUGIN-PHILOSOPHY "Classifying a hook" rather than restating it. - Phase 2: a hybrid entry's behavioral surface strips via the hook's own kill switch or config where one exists; otherwise the entry stays wired and is recorded `unstripped-hybrid-hook` with the observe-phase confound noted. Wiring is never removed whole. - Manifest classification enum gains `hybrid`. - claude-config 0.27.2 → 0.27.3 with changelog. ## Verification Docs-contract change only (no scripts); catalog/cheat-sheet regeneration produced no diff; changelog-parity satisfied by the stacked 0.27.3 entry. ## Related Refs #2033 (the rubric this aligns to; its codex P2 thread is the finding), #2021 (the audit whose hybrid rows motivated the rule). 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
No linked issue
Summary
Promotes the #2021 hook-surface audit's classification method into standing doctrine, so downstream consumer repos can run the same pass over their own hook surfaces at each generation-triggered ablation.
Fix
Adds a "Classifying a hook" subsection to
docs/PLUGIN-PHILOSOPHY.md's Instruction economy section: the two-axis rubric (mechanism x class), the mechanism-never-implies-class rule, the hybrid trim-not-delete rule, the ground-truth-oracle carve-out (behavioral purpose + non-derivable oracle = keep), and the config-disable-first remediation order. This records the classification-authority decision on #2021: standing playbook rubric, not one-time audit.Verification
Docs-only change; markdownlint clean on edit; no plugin manifests, catalog, or cheat-sheet affected.
Related
Refs #2021 (the audit this rubric generalizes), #2009, docs/PLUGIN-PHILOSOPHY.md "Instruction economy".
🤖 Generated with Claude Code