fix(ci): deploy linkage parser v0.10.2 - #1956
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
Claude finished @kyle-sexton's task in 57s —— View job Security Review — PR #1956
Scope: Change: bumps the pinned FindingsNo security issues found in this diff. Reasoning:
Confidence: High — the diff is a single-line SHA/comment bump with no other lines touched, and both the token/permission boundary and the trigger contract are byte-for-byte unchanged. |
|
Claude finished @kyle-sexton's task in 2m 21s —— View job Reviewing PR #1956
SummarySingle-line change in Verified:
Not applicable to this change: no test coverage gap (CI pin bump, not application logic), no architecture/error-handling concerns (scope is a single No findings — this is a clean, well-justified dependency bump. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dd4dff614f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Claude has reviewed this PR 2 times. The lane skips further automatic reviews after 5; deleting this comment resets the count. |
No linked issue ## Summary Mask inline-code and fenced-code contents before validating PR linkage metadata. The v0.10.1 parser correctly prevented literal HTML-comment markers in code from hiding later live metadata, but preserved other code contents long enough for example `No linked issue` or `## Related` text to satisfy the gate. This keeps the comment-parser fix while restoring fail-closed behavior for linkage markers that are not rendered as metadata. ## Verification - `node --test .github/scripts/pr-issue-linkage.test.cjs` (23/23) - `actionlint .github/workflows/pr-issue-linkage.yml` - Prettier - `git diff --check` ## Related - ci-workflows#354 - melodic-software/claude-code-plugins#1956
No linked issue ## Summary - approve the exact `ci-workflows` v0.10.2 SHA in runner policy - deploy the shared PR issue linkage caller at that SHA - document the parser hardening that masks inline, fenced, and indented code while preserving real linkage metadata - retain the existing contract, permissions, secret flow, and reusable-workflow routing ## Verification - `actionlint .github/workflows/pr-issue-linkage.yml` - `python components/runner-policy/scripts/lint_runner_policy.py` - `python -m unittest discover -s components/runner-policy/tests` (242 tests) - `markdownlint README.md` - generated-distribution diff check ## Related - melodic-software/ci-workflows#355 - #327 - melodic-software/claude-code-plugins#1956 - `ci-workflows` release `v0.10.2`
dd4dff6 to
8b8463f
Compare
|
Claude finished @kyle-sexton's task in 2m 18s —— View job Reviewing PR #1956 (code-review lane)
SummaryThis review re-ran after a Findings1. PR title/body are stale relative to the pushed commit (correctness/maintainability)
2. Codex's P2 finding (code-fenced linkage markers bypassing the gate) — noted, not independently verified Codex flagged that the new Markdown-aware parser preserves No other issues in the one line changed here (permissions, triggers, and |
|
Claude finished @kyle-sexton's task in 1m 46s —— View job Security Review — PR #1956
Scope: FindingsNo security issues found in this diff. Reasoning:
Confidence: High for the local diff (no local security surface changed) — the SHA/permissions/trigger boundary is unchanged. No confidence claim made on the external reusable's internal fix, since that source isn't in scope/available here. |
No linked issue
Summary
Move the locally owned PR-linkage caller to the reviewed
ci-workflowsv0.10.2 release. This deploys the Markdown-aware parser that ignores linkage-like text inside inline, fenced, and indented code while preserving real HTML-comment metadata and the existing exact Dependabot exemption.The exact reusable-workflow SHA is approved by the synced runner policy from
standards@0d0c144.Verification
actionlint .github/workflows/pr-issue-linkage.ymlnode .github/standards/runner-policy/runner-policy.mjs --root .git diff --checkRelated