-
Notifications
You must be signed in to change notification settings - Fork 0
feat(review-toolkit): add OpenAI Codex as a cross-vendor orchestrator review surface #177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
95afb68
feat(review-toolkit): add OpenAI Codex as a cross-vendor orchestrator…
kyle-sexton e7fff61
fix(review-toolkit): invoke Codex review with --wait for synchronous …
kyle-sexton dd7d217
fix(review-toolkit): pass the resolved review base to Codex reviews
kyle-sexton 71b3326
fix(review-toolkit): resolve the review base before invoking Codex, r…
kyle-sexton b81b15b
docs(review-toolkit): note Codex --base branch-mode coverage boundary
kyle-sexton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fresh evidence after the prior fix: the dirty-tree caveat was added only to
run-everything-mode.md, but this sharedSKILL.mdbullet still governs default medium/large orchestrator dispatch and says--basemakes Codex diff the same change set. In a default review of an ahead branch with staged/unstaged edits, the leaves usegit diff <review-base>and include those edits, while I checked codex-plugin-cc's companion code and anybaseRefresolves to branch mode, whose branch context diffs only<merge-base>..HEAD; the persisted report will therefore overstate Codex coverage unless the same gap is documented here or default mode runs a separate working-tree Codex pass.Useful? React with 👍 / 👎.