test(source-control): bind the wrapper-denial table in both directions by kyle-sexton · Pull Request #1420 · melodic-software/claude-code-plugins

kyle-sexton · 2026-07-25T23:32:12Z

No linked issue — a gap found and closed while driving #1285 to merge, small enough that a tracking issue would outlive its usefulness before anyone read it.

Follow-up to #1285 (#1265). Closes the reverse direction of a binding that #1285 established in one direction only.

The gap

WRAPPER_DENIED_FLAGS records the flags a bin/ wrapper refuses before Python runs, so a documented wrapper command naming one is a command that always exits 2. test_wrapper_denied_flags_are_proven_by_a_refusal_row proves every listed flag is one a bash-wrapper refusal row invokes the wrapper to demonstrate.

Nothing proved the converse. A new bash-wrapper refusal row could demonstrate a second refused flag while the table stayed silent about it — and a document could then spell that flag unchallenged, because the documented-command check consults the table, not the rows. The table would be a subset of the wrapper's behavior while reading as a statement of it. That is the unbacked-claim shape this contract exists to catch, pointed the other way.

Changes

test_every_wrapper_refusal_row_reaches_the_denial_table — every flag a bash-wrapper refusal row names must be covered by WRAPPER_DENIED_FLAGS. Read from error_contains rather than argv: a row's argv also carries the flags that reached the wrapper legitimately, while the error names the one the refusal is about.
test_the_denied_flag_is_one_its_own_cli_accepts — pins the premise the separate wrapper check rests on. The merge parser does register --allow-unpinned-head, which is precisely why a CLI-only check cannot see the wrapper's refusal. If this stops holding, the two checks have collapsed into one and the narrowing is no longer load-bearing.

Verification

python -m unittest tests.test_guards — 20 tests, OK. No production code changes; test and changelog only, source-control 0.28.0 → 0.28.1.

feat(source-control): bind babysit guard semantics to an executable contract #1285 — established WRAPPER_DENIED_FLAGS and the forward binding this PR completes
Guard semantics the lane's consumers restate in prose have no drift detection #1265 — the guard-contract issue feat(source-control): bind babysit guard semantics to an executable contract #1285 closed
fix(source-control): emit a readiness verdict on the gate's silent failure paths #1264 — carries a separate --help fix to _accepted_flags in the same file; both touch test_guards.py and whichever lands second will need a trivial merge
docs(topic-docs): the contract-slice prune rule is normative, unenforced, and contradicted 17 times on main #1422 — the topic-docs convention gap filed in the same pass; unrelated to this change, listed so the sweep is traceable

`WRAPPER_DENIED_FLAGS` records the flags a `bin/` wrapper refuses before Python runs, and `test_wrapper_denied_flags_are_proven_by_a_refusal_row` already proved every LISTED flag is one a `bash-wrapper` refusal row invokes the wrapper to demonstrate. Nothing proved the converse: a new refusal row could demonstrate a second refused flag while the table stayed silent, leaving that flag spellable in a documented command. The table would be a subset of the wrapper's behavior while reading as a statement of it -- the exact unbacked-claim shape this contract exists to catch, pointed the other way. Read from `error_contains` rather than `argv`: a row's argv also carries the flags that reached the wrapper legitimately, while the error names the one the refusal is about. A companion assertion pins the premise the separate wrapper check rests on -- the merge parser does register `--allow-unpinned-head`, which is why a CLI-only check cannot see the refusal. If that stops holding the two checks have collapsed into one. Refs #1265. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

claude · 2026-07-25T23:32:30Z

Claude encountered an error after 2s —— View job

I'll analyze this and get back to you.

claude · 2026-07-25T23:32:35Z

Claude encountered an error after 2s —— View job

I'll analyze this and get back to you.

github-actions · 2026-07-25T23:32:52Z

Warning

Automated review did not complete — this is an infrastructure failure, not a review verdict.

Treat any Claude comment on this PR (including a placeholder like "I'll analyze this and get back to you") as incomplete, not "no findings."

Run: https://github.com/melodic-software/claude-code-plugins/actions/runs/30180570313
Last SDK result: {"subtype":"success","is_error":true,"num_turns":1,"duration_ms":1955,"total_cost_usd":0}

Re-running the job, or pushing a new commit, will retry the review.

github-actions · 2026-07-25T23:32:55Z

Warning

Automated security review did not complete — this is an infrastructure failure, not a review verdict.

Treat any Claude comment on this PR (including a placeholder like "I'll analyze this and get back to you") as incomplete, not "no findings."

Run: https://github.com/melodic-software/claude-code-plugins/actions/runs/30180570316
Last SDK result: {"subtype":"success","is_error":true,"num_turns":1,"duration_ms":1874,"total_cost_usd":0}

Re-running the job, or pushing a new commit, will retry the review.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5d125e73b5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Version only: main took 0.29.0 while this branch was open, so the patch slot moves 0.28.1 -> 0.29.1 and its changelog section is renamed to match. No content conflict; 387 tests pass. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

claude · 2026-07-25T23:57:04Z

Claude encountered an error after 2s —— View job

I'll analyze this and get back to you.

claude · 2026-07-25T23:57:19Z

Claude encountered an error after 2s —— View job

I'll analyze this and get back to you.

The reverse binding read `error_contains` for `--`-prefixed tokens, but that field is a tuple of asserted output substrings with no invariant that any of them is a flag. A future bash-wrapper row with an empty tuple -- or one recording its rejected option without the leading dashes -- would yield nothing to iterate and pass vacuously, leaving WRAPPER_DENIED_FLAGS free to omit that refusal. The check would have reported success over exactly the omission it exists to catch. A wrapper refusal is ABOUT a flag, so a row that cannot name one cannot be bound: at least one extracted flag is now required per row. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

claude · 2026-07-26T00:06:07Z

Claude encountered an error after 2s —— View job

I'll analyze this and get back to you.

claude · 2026-07-26T00:06:14Z

Claude encountered an error after 2s —— View job

I'll analyze this and get back to you.

Version and changelog ordering only: #1420 landed 0.29.1 while this branch was open. This work keeps 0.30.0 and its section sits above the incoming 0.29.1. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

Version and changelog ordering only: #1420 landed 0.29.1 while this branch was open. This work keeps 0.31.0 and its section sits above the incoming 0.29.1. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

chatgpt-codex-connector Bot reviewed Jul 25, 2026

View reviewed changes

Comment thread plugins/source-control/skills/babysit-prs/scripts/tests/test_guards.py Outdated

kyle-sexton merged commit 5472142 into main Jul 26, 2026
26 checks passed

kyle-sexton deleted the test/1265-wrapper-denial-reverse-binding branch July 26, 2026 00:12

This was referenced Jul 26, 2026

test(source-control): the abbreviation gate passes vacuously against an add_help=False parser #1433

Closed

Lane telemetry: babysit-loop #1214

Closed

Navigation Menu

Uh oh!

test(source-control): bind the wrapper-denial table in both directions - #1420

test(source-control): bind the wrapper-denial table in both directions#1420
kyle-sexton merged 3 commits into
mainfrom
test/1265-wrapper-denial-reverse-binding

kyle-sexton commented Jul 25, 2026 •

edited

Loading

Uh oh!

claude Bot commented Jul 25, 2026 •

edited

Loading

Uh oh!

claude Bot commented Jul 25, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 25, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 25, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

claude Bot commented Jul 25, 2026 •

edited

Loading

Uh oh!

claude Bot commented Jul 25, 2026 •

edited

Loading

Uh oh!

claude Bot commented Jul 26, 2026 •

edited

Loading

Uh oh!

claude Bot commented Jul 26, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

kyle-sexton commented Jul 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

The gap

Changes

Verification

Related

Uh oh!

claude Bot commented Jul 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

claude Bot commented Jul 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

claude Bot commented Jul 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

claude Bot commented Jul 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

claude Bot commented Jul 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

claude Bot commented Jul 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

kyle-sexton commented Jul 25, 2026 •

edited

Loading

claude Bot commented Jul 25, 2026 •

edited

Loading

claude Bot commented Jul 25, 2026 •

edited

Loading

github-actions Bot commented Jul 25, 2026 •

edited

Loading

github-actions Bot commented Jul 25, 2026 •

edited

Loading

claude Bot commented Jul 25, 2026 •

edited

Loading

claude Bot commented Jul 25, 2026 •

edited

Loading

claude Bot commented Jul 26, 2026 •

edited

Loading

claude Bot commented Jul 26, 2026 •

edited

Loading