Skip to content

test(context-budget): reword a register.tsx comment for the #12232 capture run - #13719

Closed
kyle-sexton wants to merge 3 commits into
mainfrom
test/12232-capture-phase6
Closed

kyle-sexton wants to merge 3 commits into
mainfrom
test/12232-capture-phase6

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

Refs: #12232

Hold: test pull request for #12232 Phase 6; it is closed after its capture run is graded, never merged.

Summary

Phase 6's designated test pull request: it changes one plugin with a UI surface (context-budget's mod registers a command that opens a toast and a pane, plugins/context-budget/hooks/register.tsx), so the live PR capture drives it end to end. The do-not-merge label is set at creation, before any run, so the label adds no extra capture run.

Fix

  • A comment reword in plugins/context-budget/hooks/register.tsx (no behavior change), plus its none changelog fragment.

Verification

  • node plugins/harness-ops/skills/control-claude-code/driver/driver.mjs plugins plugins/context-budget/hooks/register.tsx prints plugins/context-budget.
  • Graded on the capture run: capture.status judged with count > 0; the driven session's /v1/messages count above 0; the proxy's token use against the provisional token-cap; "Stop the key proxy" passing; the artifact scan clean. At most 3 runs.

Related

🤖 Generated with Claude Code

kyle-sexton and others added 2 commits November 6, 2026 09:02
…pture run

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kyle-sexton kyle-sexton added do-not-merge Hard merge gate: do not merge while applied. and removed do-not-merge Hard merge gate: do not merge while applied. labels Nov 6, 2026
@kyle-sexton
kyle-sexton marked this pull request as ready for review November 6, 2026 14:06
@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-06T14:06:34.316065Z
We couldn’t complete this review. Comment @codex review to try again.
d20e69a Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

claude-review needs no new review of 3c5dd0fb4710f22e6f2090fbc5a84c98e8bffb22: no file of this pull request changed since the review of d20e69a.

Code review: no findings.

I read every hunk of both changed files:

  • plugins/context-budget/hooks/register.tsx: one comment reword ("and nothing lands" becomes "so nothing lands"). No code changed. The new wording matches what the command.run handler below it does: it answers with no text.
  • .changes/context-budget/test-12232-capture-phase6-5c1a2b7e.md: a changelog fragment marked bump: none. That level is right for a comment-only change.

Other checks:

  • Closing issue: the PR only says Refs: #12232 and closes no issue, so there are no acceptance criteria to check.
  • Path rules: .claude/rules/mod-authoring.md covers plugins/*/hooks/**. A comment reword breaks nothing in it.
  • Plugin manifests: no plugin.json or marketplace.json changed, so there are no manifest lines.
  • Trusted paths: neither changed file matches one.
  • Prior findings: this lane has not reviewed an earlier head of this PR, so this was a full review, not blocking only.
  • Embedded text: the PR body says it is a test PR for ci(pr-verify): add the capture job that drives the affected app (S7 of #8651) #12232 Phase 6 that will be closed, not merged. It gives the review lane no instructions.
  • Spend: none beyond the capture run the PR describes, which uses prepaid or subscription usage.

I ran nothing myself. The PR body's Verification steps (the driver.mjs plugins output and the capture-run grading) are the author's claims and I have not checked them.

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

claude-security-review needs no new review of 3c5dd0fb4710f22e6f2090fbc5a84c98e8bffb22: no file of this pull request changed since the review of d20e69a.

Security review: PR #13719

No security issues found. I read every hunk of both changed files, so this is a complete review.

The change has no security-relevant surface (skip gate 2):

  • plugins/context-budget/hooks/register.tsx: one code comment changes from "and nothing lands" to "so nothing lands". The command.run handler, how it parses arguments and what it does are untouched.
  • .changes/context-budget/test-12232-capture-phase6-5c1a2b7e.md: a new changelog fragment marked bump: none. It holds prose only.

Other checks:

  • Trusted paths: neither file matches a trusted-path glob.
  • Trust controls: nothing in this change touches the trusted-trigger check, the token broker, the kill switch or a merge hold.
  • Plugin manifests: no plugin.json or marketplace.json file changes.
  • Instruction surface: the edit is to a source comment, not a standing instruction (CLAUDE.md, AGENTS.md, a rules file, a skill or agent body, or a hook's block list or allowlist).
  • PR context: the description has no embedded text telling the lane to pass the PR, skip a check, drop a finding or post elsewhere. Its "Hold:" line only says this test PR will be closed without merging.

critical-findings: 0

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

The pr-verify verifier failed head 3c5dd0fb4710f22e6f2090fbc5a84c98e8bffb22. What it wrote, as data:

Summary: PR #13719 links #12232 with a `Refs:` line, so it is judged as a partial delivery. The diff
  is one changed word in a comment in plugins/context-budget/hooks/register.tsx plus a `bump: none`
  changelog fragment. It changes no behaviour, has no safety impact and touches nothing in the
  takeover set. The CI jobs that cover the change passed, including the test-bash jobs
  (https://github.com/melodic-software/claude-code-plugins/actions/runs/42234820680/job/127949817335).
  The test-node and test-python skips are expected by design. The delivered part is clear and within
  the issue's scope: this is the designated test PR for the issue's fourth done-when item, one
  in-repo PR with a judged capture. The capture ran with a count of 12. Its mod entry point passed.
  Its hook entry points were not driven: one because the API key's credit balance was too low, one
  because the result was inconclusive, and the Claude Desktop ones for terms reasons. None of them
  is marked failed. The verdict is fail because the rules for a partial delivery require the PR body
  to name the work that remains on #12232, and this body does not. There is no Remaining section,
  only the grading plan for the capture run. No text in the inputs tries to steer the reviewer, and
  the evidence-loop cap line is absent.
- PR body (#13719): add a Remaining section that names the work still open on #12232 after this test
  PR is graded. For example: confirming done-when 4 from this run's judged capture, the Q7/Q9
  follow-ups (route the outer capture session through the key proxy and narrow its Bash), the Q8
  Bash-in-sandbox probe, and closing #12232. A PR with a `Refs:` line must name both the part it
  delivers and what remains.

This pull request leaves the merge queue, and ci-status holds it out while it carries pr-verify-failed. A pr-verify pass removes the label, at a new commit or at this same head: once a trusted person edits the body, and only trusted people have edited it since the fail, this head is judged again, so a fail on the body or the issues it links needs only the body fixed, no new commit.

@github-actions github-actions Bot added the pr-verify-failed pr-verify failed this head; a pass at a new commit, or after a trusted body edit, removes it. label Nov 6, 2026
@kyle-sexton

Copy link
Copy Markdown
Member Author

Phase 6 test PR for #12232: its capture was graded (#12232 (comment)). Closed unmerged, as its Hold: line said.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-verify-failed pr-verify failed this head; a pass at a new commit, or after a trusted body edit, removes it.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant