Repository navigation
test(evals): name plugin-eval in two cases that never fired it - #13245
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-security-review reviewed Security review: no security issues foundI read every hunk of all 3 changed files. None of them match a trusted path.
There are no security-relevant changes:
The PR description contains no embedded instructions aimed at this lane. This is the first review of this pull request, so the full review ran rather than blocking-only. The skip gate's "no security-relevant surface" condition applies. Spend: re-dispatching these two eval cases after merge uses prepaid API or subscription usage only. That is not a hold. critical-findings: 0 |
|
claude-review reviewed Code review: PR #13245 (complete, 3 of 3 files read)Scope: This change edits eval prompts only. The Checks made:
Verification: The PR body's results for Spend: After merge, re-dispatching these two eval cases uses prepaid API credits (3 runs each). That is not a hold. No findings. |
Refs: #12043
Summary
Two evals cases carry a
skill-firedgrader (tool_used, toolSkill, expectsevals:plugin-eval) yet fired it in 0 of 3 runs on main withskill loaded: yes, so their with-arm deltas measured nothing:sandbox-wsl2-missing-socat: run 41841302783target-before-json: run 41841355473Fix
--allow-tools), not triggering, so naming the skill keeps their purpose. Each description now says the case tests behavior once the skill is loaded, not triggering.plugins/evals/skills/plugin-eval), so it is unchanged. Thesocat-missingandtarget-firstgraders are unchanged.bump: nonechangelog fragment.Triggering finding, reported on #12043 and not fixed here: plain questions about a WSL2 sandbox missing socat, and about
claude plugin evalargument order, do not trigger/evals:plugin-eval.Verification
validate-cases.py plugins/evals: 0 FAIL (WARNs only, judge-calibration notices these cases already had).scripts/check-affected.sh --testson the committed head: 13 passed, 4 skipped over 3 changed files.claude plugin eval <archive of plugins/evals> --case <name> --runs 1 --allow-tools Read Glob Grep Skill, Claude Code 2.1.318, with-without ablation):sandbox-wsl2-missing-socat: with-armskill-firedpassed ("Skill called 1x", input matchedevals:plugin-eval),socat-missingpassed; without-arm failed it. Delta 1.0.target-before-json: with-armskill-firedpassed ("Skill called 1x"),target-firstpassed; without-arm failed it. Delta 1.0.Remaining on #12043
sandbox-wsl2-missing-socatandtarget-before-json, read the health line, and link the runs on feat(evals): run plugin eval suites in a CI lane and hill-climb in the background #6405.Related
🤖 Generated with Claude Code