Skip to content

test(review): add the revert cases' fixture archives - #13225

Closed
kyle-sexton wants to merge 2 commits into
mainfrom
test/12939-revert-fixtures
Closed

kyle-sexton wants to merge 2 commits into
mainfrom
test/12939-revert-fixtures

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

Closes #12939

Summary

Part B of the split of #13097: only the 16 fixtures.tar.gz archives the revert cases scaffold from. They are binary, so the review lanes count them but cannot read them. Held until the owner answers the open question on review gaps for binary-only pull requests (Automation Lanes' Q10).

Fix

Adds one plugins/review/evals/revert-*/fixtures.tar.gz per case. Each holds byte copies of the files at the commits its case.yaml names, plus the original commit message as the pull request context.

Verification

A verifier agent scanned the unpacked files of all 16 for home paths and token shapes and found none; the only account-linked text is public commit metadata and session URLs already in public history. The contents can be read from the commits each case.yaml names, and the results are in part A. One case ran through the harness from its archive: VALID.

Left out: review-lane coverage of the archives, which is the question this PR waits on.

Related

Draft: waits on the owner's answer to the binary-only review question

🤖 Generated with Claude Code

kyle-sexton and others added 2 commits November 4, 2026 08:14
Closes #12939

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kyle-sexton kyle-sexton added the do-not-merge Hard merge gate: do not merge while applied. label Nov 4, 2026
@kyle-sexton

Copy link
Copy Markdown
Member Author

Held. This PR holds only the 16 fixtures.tar.gz archives, which the review lanes count but cannot read, so its reviews would end partial and ci-status red. It waits on the owner's answer to Automation Lanes' Q10 (review gaps on binary-only PRs). When Q10 is answered, Lane 2 removes do-not-merge, runs ready and arms it per that answer. #12939 closes with this PR; until then the 16 revert cases cannot scaffold, and no CI job or required check runs them.

@kyle-sexton

Copy link
Copy Markdown
Member Author

Hold update. Q10 is answered: option (a), commit no binary fixtures (owner, recorded in melodic-software/architecture#28, relayed by the hub).

This PR stays held under do-not-merge and will not merge. Automation Lanes is building the replacement: the #12939 fixtures as text, with no archives, split across two PRs to stay under the 160-file review cap. Once both of those PRs merge, this PR closes as superseded.

@kyle-sexton

Copy link
Copy Markdown
Member Author

Superseded by #13299, merged 2026-11-04T18:44:47Z, which builds the revert cases from text fixtures. Owner decision Q10 (a): no binary fixture archives are committed, so this PR will not merge.

@kyle-sexton kyle-sexton closed this Nov 4, 2026
@github-actions
github-actions Bot deleted the test/12939-revert-fixtures branch November 5, 2026 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge Hard merge gate: do not merge while applied.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Revert eval set for review:code-review

1 participant