Repository navigation
feat(dometrain): concise sync body (round 2, measured no-loss) - #12162
Conversation
Drops the flavor sentence and the role-split sentence that repeated Boundaries bullet 1. Measured on Opus 5.5 and Sonnet 5.5 against the frozen suite (evals tree 03bb41f): sy-check-report-only 1.000 -> 1.000 on both models, every pass VALID. Refs: #6605 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-review reviewed Code review: no findingsI read every hunk of both changed files:
No plugin manifest is touched, so there are no manifest lines. Closing issue #6605 "Done when"
SpendThe PR reports eval passes that used prepaid API credit (about 1.64 USD list-price estimate). The PR adds no ongoing spend and starts no billed resource. No embedded instructions were found in the PR context. |
|
claude-security-review reviewed Security review: PR #12162 (
|
Closes #6605
Summary
Round 2 of the measured concise rewrite for the
dometrainplugin, for thesyncbody only. Round 1 (#12116) shipped thegroundingandsetupbodies and heldsyncback, because its Opus result was decided by a grader defect (reports-exit-codemissed "exited with code 2"). #12120 fixed that grader. On the fixed suite the round-1synctext was measured again, both versions fresh, and it shows no loss on Opus 5.5 or Sonnet 5.5.With this PR every #6605 part has a final result:
sy-check-report-only1.000 → 1.000 on both models; every pass VALID; no grader defectFix
sync/SKILL.mddrops two sentences, the same text round 1 measured:disable-model-invocation: true, which repeats Boundaries bullet 1.61 → 58 lines, 392 → 353 words. Frontmatter, spokes, scripts and
vendor/are unchanged.Changelog fragment
.changes/dometrain/,bump: patch.Verification
Protocol: rewrite-a-plugin runbook and the skill-criteria rewrite protocol, with a preregistration written before any run. Its decision rule is round 1's, unchanged: VALID on both models, after ≥ before − 0.05, no drop of a third or more. It also added two checks:
reports-exit-codepatterns are replayed on every reply, and any reply that passes only under the current pattern is read in full.Frozen suite:
plugins/dometrain/evalsgit tree03bb41f0bd(test(evals): fix eval-suite defects lane 3 measured in six plugins #12120's frozen digest), re-checked by file digest before every pass. Nothing underevals/changed.Meaning diff: reused from round 1. Both texts are byte-identical to round 1's, and two fresh labelers each returned PASS with 2 INTENDED CUT and 0 loss.
Runs:
claude plugin eval(Claude Code 2.1.316), before and after launched together,--runs 5 --ablation none --case sy-check-report-only --allow-tools Bash Write Edit. Five runs because with one 6-grader case, a single miss moves the mean by 0.056 at 3 runs, more than the 0.05 margin.No grader failed in any of the 20 runs. The only run-validity warning was "skill fired", because
syncis slash-invoked. There was no permission denial and no run error. The noise report reads "n too small to call", as expected for one case; it shows nocase dropline.Leniency check: two Opus before replies pass only under the widened pattern ("exited with code 2 (unverifiable)"). Read in full, each states one exit code, so the grader is not lenient. Every other reply passed both patterns and states one code.
Quota and network: no run called an
mcp__tool, WebFetch or WebSearch. The only network call wasupdate.sh's GitHub fetch, which the sandbox refused, so every run took the exit-2 path on both versions. No Dometrain server is reachable from the eval sandbox.Host safety: a Bash-only probe ran before any grant was given. Windows drives were empty to the sandbox, the Windows binaries could not run, and
WSL_INTEROPwas unset./skill-quality:check: 3 PASS on the branch, warnings 3/2/2, the same as round 1's in-repo before run (sync's before text is byte-identical to that run's).synchas 0 errors./evals:validate(validate-cases.py) onplugins/dometrain/evalsat the branch head: 0 FAIL. The WARN lines are the known grant notices.Totals: 5 passes (probe included), 1.64 USD list-price estimate, about 3 minutes of run time.
gitleaks: 1 commit, no leaks.Related
groundingandsetupbodies.groundingdid not fire on the plain JWT question (gr-covered-topic). This is a description-level gap.gr-export-injectionreplies did not name the planted note.sync's drift path (exit 0 or 1), because the eval sandbox cannot reachraw.githubusercontent.com.🤖 Generated with Claude Code