Repository navigation
fix(ci): acknowledge #11646's rewrite of #11548's chunk slots - #11669
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-security-review needs no new review of No security findings. The change adds one row to
critical-findings: 0 |
|
claude-review needs no new review of No findings. The PR adds one row to What I checked myself, by reading the file:
What I could not check: I have no shell or git access in this run. I did not confirm that Embedded text: the PR context file contained no directives aimed at the lane. The scoped criteria are met: PR #11669 only refs #11658 and does not close it, so there are no closing-issue criteria to check. Trusted paths: no changed file matches a TRUSTED PATHS glob. The change is a data-only allowlist row for a CI canary. It carries no cost or critical-security risk, so I return no hold. |
|
The pr-verify verifier failed head This pull request leaves the merge queue, and ci-status holds it out while it carries |
No related issue: this clears the false positive that post-merge record #11658 reports; that record is bot-written with no body, so it holds no spec to verify against
Summary
The silent-revert canary read #11646's widening of pr-verify's chunk slots as a 401-line removal of #11548, and post-merge opened #11658, so the unattended merge path sits at rung off. Nothing was lost, so this records the review in
scripts/silent-revert-acknowledged.txt.This PR's title and body are its spec. Done when: the row is on main, and the next silent-revert canary run on main passes over 5cce729. #11658 is then closed directly, as its body says, not by this PR.
Fix
One row for
5cce729c61018f709e9fa5216e639112e7f82daa, the form the canary's own output asks for.Verification
git diff --unified=0 fd862a49b 5cce729c6over the four files the finding names, read line by line:pr-verify.yml,workflow.test.mjsandwrite-verdict.mjsis a 4-slot form replaced by its 12-slot one: step chains,MAX_CHUNKS: "4",timeout-minutes: 125,^[1-9]$, hard-codedSLOTS.id: judgesteps inpr-verify.ymlwent from 15 to 39 (3 jobs of 13 steps), and all 3judge-specsteps remain.git show 5cce729c6, line by line:docs/conventions/pr-pipeline/README.md: 4 lines removed, 4 added. The removed lines are the "at most 4 chunks" and "more than 4 chunks (over about 1.2 MB)" sentences; the added lines say "up to 12" and "more than 12 chunks (over about 3.6 MB)". Same rule, new limit.workflow.test.mjsandwrite-verdict.mjs: 14 lines removed. Each is a 4-slot form (SLOTS = [1, 2, 3, 4],^chunk-[1-9]$,^[1-9]$, a 4-step chain) whose 12-slot form is added in the same commit.pr-verify.yml: the removed lines repeat 2 or 3 times, once per judging job (key, subscription, fallback):timeout-minutes: 125,MAX_CHUNKS: "4",^[1-9]$, the 4-slotif:,handoff:andleg-clean:chains, and the comment saying five 22-minute steps fit in 125 minutes. Each has a 12-slot or 301-minute replacement in the same commit.The canary's count is line attribution across a regenerated block, not lost content.
Intentional-removal:in #11646's body would have avoided the fire.Related
🤖 Generated with Claude Code