Repository navigation
fix(planning): reword shared interview phrases, read back departing answers, restate only changes - #11588
Conversation
…g skills Reword the interview lines that shared short phrases with mattpocock/skills grilling, grill-me and grill-with-docs (at 24fe0ef): the Stance wayfind trigger, "the frontier is empty" across the skill bodies, sweep, checklist, evals and wayfind, the coverage-prompt exemption line, and the confirmation gate's opening clause. No rule or halt changed. Re-pin the four digest pins that guard the reworded text. Builds on the work-resolve-issue lane's partial branch for #9790. Closes #9790 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VcupokZY9nMi5ZG7UdzT4q
… "something else" Three interview rules the work-resolve-issue lane wrote but could not re-pin (its Bash cannot run repin.sh): - #11187: loop.md's drift check reads back an answer that departs from the recommendation, or arrives dictated or unclear, and keeps its row open until the user confirms the read-back. - #11189: SKILL.md Step 3's restatement gives only changed answers, hedged rows and unseen assumptions when each answer was read back. - #11191: the round's closing probe is worded "something else". Re-pin the Stance, Step 3 and loop.md register digests they change. Closes #11187 Closes #11189 Closes #11191 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VcupokZY9nMi5ZG7UdzT4q
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-security-review reviewed No security issues found in the incremental change (d26e742 over 8bd94d5). It touches a changelog fragment, the Instruction-surface lens. The one SKILL.md edit rewrites the recap rule in the "Recap and procedure check" paragraph. The rule now applies "when every answer was accepted as recommended or confirmed after its read-back" instead of "when each answer was read back as it arrived". It tells the model to save a recap (
The edit changes only how much is restated, so no protected-class action loses its check. I did not read Test file. Changelog fragment. It is prose only. Pin-ceremony and friction-hold changes are not a finding in this phase. No manifests, token scopes, trusted-actor lists or merge holds changed. critical-findings: 0 |
|
claude-review reviewed Incremental review of d26e742 (since 8bd94d5): no findings. What changed
Checked
Not a hold: the change spends no billed resource. Eval reruns draw only on prepaid credit and are not a finding. |
Review on #11588: the #11189 rule's condition ("each answer was read back") rarely held, since accepted answers get no read-back, and it replaced the verbatim recap with a hand-written line the procedure check cannot see. The rule now applies when every answer was accepted or confirmed after its read-back, saves a recap once each round's read-backs are confirmed, and pastes the generated --changed recap at the first confirmation. Each re-pin comment now names only the change inside its own range. Step 3 re-pinned. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VcupokZY9nMi5ZG7UdzT4q
|
Host eval reruns for #11187, #11189 and #11191, on this PR's head d26e742 (which includes the review fix to the #11189 rule). How they ran:
On #11189's case, the
Filed as #11591. #11189's done-when makes the 0.8 bar the rerun's check, not this PR's gate. This was generated by AI. |
Closes #9790
Closes #11187
Closes #11189
Closes #11191
Summary
Four
/planning:interviewchanges that each stoppedhost-onlyin the issue lane only because the lane cannot re-pin the interview digests. They share the same pins, so one PR re-pins them once instead of four PRs conflicting on them. The lane wrote the rule text for each; this host run resolved conflicts with main, re-pinned and verified.Fix
loop.mddrift check reads back an answer that departs from the recommendation, or arrives dictated or unclear, and keeps its row open until the user confirms.loop.mdregister digests are re-pinned withtests/repin.sh, each with its justification. No rule or halt changed.Verification
scripts/check-affected.sh --tests: 14 passed, 2 skipped (includesinterview-defenses.test.sh).fingerprint.mjs compareofSKILL.mdandcontext/loop.mdagainst each of the three upstream files:separation.firedisfalsefor all 6 pairs.git grep -n -i 'frontier is empty' -- plugins/planningprints nothing.scripts/check-changelog-fragments.sh --checkand--check-required origin/mainboth pass.interview-readback-dictated-answer,interview-final-brief-changes-onlyandinterview-closing-probe-something-else(3 runs, opus judge), which fix(planning): read back answers that depart from the recommendation before marking them answered #11187, fix(planning): restate only changed answers and unseen assumptions at final confirmation #11189 and fix(planning): word the round's closing probe as 'something else' #11191 ask for. This host lane runs them next and posts the results on each issue.Related
🤖 Generated with Claude Code
https://claude.ai/code/session_01VcupokZY9nMi5ZG7UdzT4q