Repository navigation
ci: exempt the developer-experience labeled eval samples from typos and markdownlint - #10723
Conversation
…nd markdownlint The samples are judge inputs captured from model runs; correcting them would change what the judge is measured on. The pre-push check reads the base branch configs, so the exemption lands before the samples do. Refs: #9936 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-security-review reviewed No security issues found. critical-findings: 0 This pull request exempts
The PR description contains no embedded directives. |
|
claude-review reviewed No findings. I read the diff and PR context, and checked the new lint exclusions against their precedents in the repository.
|
Refs: #9936
Summary
Exempts the developer-experience labeled eval samples (
plugins/developer-experience/evals/sources/labels/**) from typos and markdownlint, ahead of the PR that commits those samples for #9936.Fix
scripts/check-affected.shexcludeplugins/developer-experience/evals/sources/labels/**. This is the same exemption the testing plugin's judge-calibration cases have.labels/.markdownlint-cli2.jsoncignores the directory, asplugins/session-flow/scripts/tests/fixtures/does.bump: nonedeveloper-experience changelog fragment records the change.The samples are judge inputs captured from model runs, so correcting their spelling or list spacing would change what the judge is measured on. The exemption has to land first because the pre-push
check-affectedreads the merge-base copy's configs and typos exclusions, not the branch's. Until this merges, the samples branch fails at pre-push onmarkdownandtypos.Verification
scripts/check-affected-gates.test.sh: PASS=13 FAIL=0 (the runner and workflow typos exclusions match).scripts/check-affected.sh --tests: 13 passed, 3 skipped.scripts/check-changelog-fragments.sh --check-required origin/mainexits 0.markdownlint-cli2 --config .markdownlint-cli2.jsoncon a label sample, with the nested config present, reports 0 issues.Related
host-run/9936-eval-scenario-sources, which commits the sources.🤖 Generated with Claude Code