Skip to content

fix(user-interface): treat an unexpanded account_tools_enabled as its default #10691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyle-sexton merged 1 commit into from
Oct 28, 2026
Merged

fix(user-interface): treat an unexpanded account_tools_enabled as its default #10691

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changes/user-interface/fix-9886-account-tools-unexpanded-default-3b7d5e12.md
View file
Open in desktop

@github-actions github-actions Bot Oct 28, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pr-verify verifier failed head 192857913cf2631677ca0c1a9e441077e183b0a8. What it wrote, as data:

Summary: This PR uses `Refs: #9886`, so it has to deliver a named part of #9886 and name what remains. #9886 asks for three things: record the Claude Code version, record whether the unset-default and saved-boolean cases substitute in skill content, and file a follow-up if `planning/skills/interview/SKILL.md` contradicts the result. The PR does none of these. It changes the wording in `user-interface/skills/design/SKILL.md`, which is outside the issue's scope, and its body names no work left on #9886. The wording change itself looks correct and safe.
- PR body: a `Refs:` PR must name the remaining work on the issue. 'Left out: a live 2.1.312 re-probe' is not remaining work from #9886. Either name what is left on #9886, or re-link the PR to an issue whose scope covers this change.
- .changes/user-interface/fix-9886-account-tools-unexpanded-default-3b7d5e12.md: the changelog fragment is fine, but its file name ties the fix to #9886. Rename it to match the issue the PR is re-linked to.

Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
bump: patch
---

### Fixed

- `/user-interface:design` reads an `account_tools_enabled` value that arrives as its unexpanded `${user_config.account_tools_enabled}` token as the key's default `true`, so account-bound tools stay enabled instead of being read as off.
3 changes: 2 additions & 1 deletion plugins/user-interface/skills/design/SKILL.md
View file
Open in desktop

@github-actions github-actions Bot Oct 28, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pr-verify verifier failed head 192857913cf2631677ca0c1a9e441077e183b0a8. What it wrote about this file, as data:

- plugins/user-interface/skills/design/SKILL.md:82: outside the scope of #9886. The issue's done-when items are a measurement comment (now posted by the host run) and, only if the interview skill is contradicted, a follow-up issue for that skill's wording. Changing `/user-interface:design` is not one of them. To fix, open or link an issue that asks for this change, such as a follow-up from the host run's caveat about default-`true` keys, and close or reference that issue instead of #9886.
- plugins/user-interface/skills/design/SKILL.md:82: no correctness or safety problem found. Treating an unexpanded `${user_config.account_tools_enabled}` as its manifest default `true` matches the #9886 measurement (an unset key with a default reaches skill content as the literal token). Per the PR body, `plugin.json` declares the default as `true`; this was not checked against the diff.

Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,8 @@ these hold:
- It has no `style`, or the project is in that style (for example pixel art).
- Its `reachable` is not `false`: a server that is listed but not connected is skipped.
- Its `account` is `none`, or account-bound tools are enabled (now:
`${user_config.account_tools_enabled}`). A `paid` row is suggested only when no free row covers
`${user_config.account_tools_enabled}`; a token that arrives unexpanded means the key's default,
`true`, so account-bound tools are enabled). A `paid` row is suggested only when no free row covers
the concern. When an account-bound row's `reachable` is `null`, route to it and tell the user
they may need to sign in.

Expand Down
Loading