fix(toolchain): python.yaml pyright skip granularity + config-glob + opt-in wording gaps by kyle-sexton · Pull Request #1025 · melodic-software/claude-code-plugins

kyle-sexton · 2026-07-22T16:41:02Z

Summary

Three mature, well-scoped follow-up findings on the bundled python ecosystem default
(plugins/toolchain/reference/ecosystems/python.yaml and its owning check-skill context doc),
deferred from PR #859's review threads and batched here via the #657 triage sweep. All three are
scoped to the python ecosystem surface; no cross-ecosystem mechanism changes.

Fix

Site 1 (P1) — pyright skip granularity. uv run pyright is the first check-cmd tool whose
presence is not implied by the ruff-config opt-in gate, and tool presence is evaluated per
ecosystem, not per tool (per the check skill's tool-presence rule). So a ruff-configured project
with pyright absent reports a whole-ecosystem missing-tool skip that also drops ruff coverage,
rather than skipping pyright alone.

Chose the issue's defaulted decision — document pyright as a hard prerequisite of the python
default once ruff opts the ecosystem in (skills/check/context/python.md, Type-check section) —
over a per-tool skip-granularity code change. Rationale: per-tool skip is a larger cross-ecosystem
mechanism change (every check-cmd tool would need independent-skip semantics); the documented
prerequisite is the smaller, reversible fix that resolves the reported fail-closed surprise without
redesigning the skip model. A maintainer wanting the larger mechanism can veto and redirect.

Site 2 (P2) — detection globs. Added pyrightconfig.json to the python globs so a standalone
pyright-config-only change is auto-detected as python-affecting by /toolchain:check and
/toolchain:lint local runs (CI already enforces its own check). The [tool.pyright] table is
already covered by the existing pyproject.toml glob.

Site 3 (P2) — opt-in wording. Reduced the opt-in value to its single ruff-config gating
condition. The trailing semicolon-separated pyright-mode clause structurally resembled the
multi-clause per-tool opt-in form (per the ecosystem-commands contract, whose schema defines
opt-in as either a single whole-check-cmd condition or a per-tool multi-clause value), risking
a misread of python's single-condition gate as multi-condition. Removed rather than reworded:
opt-in is a condition field, not a mode note, and the descriptive pyright-mode text already lives
verbatim in skills/check/context/python.md gotchas (single source of truth — no duplication). The
reduced value is now identical to the contract's own clean example
(docs/conventions/ecosystem-commands/examples/python.yaml), confirming the intended single-condition
form.

Includes the per-plugin version bump (0.9.0 → 0.9.1, patch — scoped bugfix/hardening) and a
matching top-inserted CHANGELOG.md entry.

Verification

Ran against the changed files in the worktree:

check-jsonschema --schemafile docs/conventions/ecosystem-commands/ecosystem.schema.json \
  plugins/toolchain/reference/ecosystems/python.yaml
  -> ok -- validation done

check-jsonschema --schemafile https://json.schemastore.org/claude-code-plugin-manifest.json \
  plugins/toolchain/.claude-plugin/plugin.json
  -> ok -- validation done

markdownlint-cli2 --config .markdownlint-cli2.jsonc \
  plugins/toolchain/skills/check/context/python.md plugins/toolchain/CHANGELOG.md
  -> Summary: 0 error(s)

typos --config _typos.toml <changed files>
  -> clean

(/toolchain:check and /toolchain:lint are model-driven skills, not runnable scripts; the
ecosystem YAML is validated against its published ecosystem.schema.json contract as the concrete
static gate. No CI lane enforces the ecosystem schema — it is a reference contract — so the schema
run above is the authoritative structural check for the YAML edit.)

Closes toolchain: python.yaml pyright per-tool skip granularity + config-glob + opt-in wording gaps (PR #859 follow-ups) #1017
feat(toolchain): add pyright to python ecosystem check-cmd #859 — originating PR whose review threads deferred these as follow-ups
lane sweep: triage — week of 7/20 (rolling paper-cut batch) #657 — triage-sweep source (T8h batch conversion)

🤖 Generated with Claude Code

Work-class: C3 (bug-fix-shaped) — attended triage 2026-07-23, operator-ratified. 🤖

…opt-in wording gaps Three PR #859 review follow-ups on the bundled python ecosystem default, batched via the #657 triage sweep: - Site 1: document pyright as a hard prerequisite of the python default once ruff config opts the ecosystem in (context/python.md). Tool presence is evaluated per ecosystem, not per tool, so a ruff-configured project with pyright absent reports a whole-ecosystem missing-tool skip that drops ruff coverage — the doc now says to install pyright alongside ruff. Chose the documented-prerequisite option over per-tool skip granularity per the issue's defaulted decision (smaller, reversible; the larger cross-ecosystem skip-mechanism change is not warranted here). - Site 2: add pyrightconfig.json to the python detection globs so a standalone pyright-config-only change is auto-detected by /toolchain:check and /toolchain:lint local runs. - Site 3: reduce the opt-in value to its single ruff-config gating condition. The trailing semicolon-separated pyright-mode clause structurally resembled the multi-clause per-tool opt-in form (per the ecosystem-commands contract), risking a misread of python's single-condition gate as multi-condition. Removed rather than reworded: opt-in is a condition field, not a mode note, and the descriptive pyright-mode text already lives in context/python.md gotchas (SSOT). Version 0.9.0 -> 0.9.1 + CHANGELOG. Verification: check-jsonschema (ecosystem.schema.json) ok; markdownlint 0 errors; typos clean; plugin-manifest schema ok. Closes #1017. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

claude · 2026-07-22T16:41:17Z

Claude finished @kyle-sexton's task in 2m 21s —— View job

PR Review

Gather context and understand the request
Read changed files
Review for correctness, security, and CLAUDE.md alignment
Post findings

Verdict: Approve with one minor omission noted. All three fixes are correct, internally consistent, and well-scoped. No security concerns. One small gap and two editorial observations below.

Site 2 — `examples/python.yaml` not updated

The pyrightconfig.json glob is added to the plugin's bundled rung-4 fallback (plugins/toolchain/reference/ecosystems/python.yaml:4) but not to the consumer-facing example at docs/conventions/ecosystem-commands/examples/python.yaml:3.

The example still reads:

globs: ["*.py", "pyproject.toml", "uv.lock"]

Consuming repos that bootstrapped from this example won't inherit the detection improvement. If the fix is worth making in the plugin default, it's arguably worth propagating to the example so both surfaces stay in sync. Not a blocker, but the example is the doc that drives consumer adoption.

Fix this →

Site 1 — prerequisite paragraph placement (editorial, not a bug)

The new text at python.md:37 is a plain paragraph floating between the Type check code block and ## Gotchas. The rest of the file uses bullet points under ## Gotchas for warning-style content. The existing pyright gotcha (line 43) and the new prerequisite note are split across sections, so a reader scanning Gotchas won't see the prerequisite. The placement gives the warning more prominence (intentional per the PR description), but the prose style doesn't match the surrounding bullet pattern. Not a blocker — the content is correct and discoverable.

Site 3 — opt-in reduction (confirmed correct)

The reduced value "ruff config (ruff.toml, .ruff.toml, or pyproject.toml [tool.ruff])" is now identical to docs/conventions/ecosystem-commands/examples/python.yaml:9, confirming the intended single-condition form per the schema's opt-in description. The schema's own definition of the multi-clause form ("each clause names a sub-tool and its own condition") makes clear the old semicolon-separated mode note was a misuse of the field. Reduction is correct.

CHANGELOG format

## [0.9.1] omits the date (CHANGELOG.md:6). Keep a Changelog recommends ## [0.9.1] - YYYY-MM-DD, but this matches the existing project convention (## [0.9.0], ## [0.8.0] also lack dates), so it's intentional and consistent. No action needed.

Version bump

0.9.0 → 0.9.1 is the correct semver tier for a scoped bug-fix and documentation-hardening patch with no API surface changes.

Security

No concerns. All changes are config YAML, documentation text, and a version bump — no code execution paths, no new external URLs, no credential handling.

claude · 2026-07-22T16:41:24Z

Claude finished @kyle-sexton's task in 1m 26s —— View job

Security Review — PR #1025

Load tools
Read PR diff
Review changed files for security issues
Post findings

No security issues found.

The four changed files are purely documentation and static configuration — no executable code paths, no injection surfaces, no credential handling, no authorization changes, and no supply chain exposure.

File	Change	Security verdict
`plugins/toolchain/.claude-plugin/plugin.json`	Version bump `0.9.0` → `0.9.1`	No impact
`plugins/toolchain/CHANGELOG.md`	Release notes text	No impact
`plugins/toolchain/reference/ecosystems/python.yaml`	Added `pyrightconfig.json` to `globs`; simplified `opt-in` string	No impact
`plugins/toolchain/skills/check/context/python.md`	Added prerequisite note for pyright	No impact

Rationale for each category checked:

Injection surfaces — globs values are file-detection patterns read by the skill runtime, not passed to a shell. The opt-in and check-cmd fields are unchanged command strings with no new interpolated variables. The find "$REPO_ROOT" snippet in python.md is illustrative documentation, not executed by this PR.
Credential / secret handling — no new variables, environment references, or external calls introduced.
Authorization / access-control — no permission widening; the opt-in simplification removes a clause, narrowing rather than broadening activation scope.
GitHub Actions / supply-chain — no workflow files touched; no dependency pins added or changed.
Command execution surface — check-cmd is pre-existing and unchanged. The new pyrightconfig.json glob only affects which file changes trigger the skill — it does not alter what the skill executes.

kyle-sexton · 2026-07-22T16:54:21Z

🔒 merge-drive lane claiming this PR for on-branch fix work this cycle (amendment-round: 16, worker tier). Will fix clear branch-owned CI/bot findings, defer non-DEFER-FORBIDDEN items with reply+resolve, push, then re-check the merge gate.

claude · 2026-07-25T15:38:47Z

Claude finished @kyle-sexton's task in 1m 21s —— View job

PR Review

Gather context and understand the request
Read changed files and git diff
Check if previously noted gap (examples/python.yaml glob) has been addressed
Review for correctness, security, and CLAUDE.md alignment
Post findings

Verdict: Approve with one minor omission still outstanding. All three fixes are correct and internally consistent. The gap flagged in the previous review cycle (2026-07-22) has not yet been resolved.

Outstanding gap — `examples/python.yaml` glob still missing `pyrightconfig.json`

The previous review noted this, and it remains unaddressed. The plugin's bundled default was updated:

plugins/toolchain/reference/ecosystems/python.yaml:4:

globs: ["*.py", "pyproject.toml", "uv.lock", "pyrightconfig.json"]

But the consumer-facing example was not:

docs/conventions/ecosystem-commands/examples/python.yaml:3:

globs: ["*.py", "pyproject.toml", "uv.lock"]   # ← pyrightconfig.json absent

Consuming repos that bootstrapped from this example won't get the detection improvement for pyright-config-only changes. Not a blocker, but both surfaces should stay in sync if the fix is considered correct.

Fix this →

All three fixes confirmed correct

Site 1 — pyright prerequisite (python.md:37). The paragraph is accurate: tool presence is evaluated per ecosystem, so a ruff-configured project with pyright absent triggers a whole-ecosystem skip. The chosen approach (document the prerequisite rather than redesign the per-tool skip model) is the right scoped call. Content is correct and discoverable.

Site 2 — pyrightconfig.json glob (python.yaml:4). Addition is correct. The [tool.pyright] table in pyproject.toml was already covered; pyrightconfig.json is the standalone config file that was missing from auto-detection.

Site 3 — opt-in reduction (python.yaml:10). The reduced value "ruff config (ruff.toml, .ruff.toml, or pyproject.toml [tool.ruff])" is now identical to docs/conventions/ecosystem-commands/examples/python.yaml:9, confirming the intended single-condition form. The old semicolon-separated clause was a structural misuse of the opt-in field per the schema definition.

Version and CHANGELOG. 0.9.0 → 0.9.1 is the correct semver tier for a scoped bug-fix/documentation-hardening patch. The three CHANGELOG bullets accurately describe each fix. The dateless header (## [0.9.1]) is consistent with the existing project convention.

Security. No concerns — all changes are static config YAML and documentation text with no execution surfaces, no new external references, and no credential handling.

claude · 2026-07-25T15:38:48Z

Claude finished @kyle-sexton's task in 1m 2s —— View job

Security Review — PR #1025

Gather context and understand the request
Read PR diff and changed files
Hunt for security vulnerabilities
Post findings

No security issues found.

All four changed files are documentation and static configuration — no executable code paths, no injection surfaces, no credential handling, no authorization changes, and no supply-chain exposure.

File	Change	Security verdict
`plugins/toolchain/.claude-plugin/plugin.json`	Version bump `0.9.0` → `0.9.1`	No impact
`plugins/toolchain/CHANGELOG.md`	Release notes text	No impact
`plugins/toolchain/reference/ecosystems/python.yaml`	Added `pyrightconfig.json` to `globs`; simplified `opt-in` string	No impact
`plugins/toolchain/skills/check/context/python.md`	Added prerequisite note for pyright	No impact

Rationale per category checked:

Injection surfaces — globs values ("pyrightconfig.json") are file-detection patterns matched by the skill runtime, not passed to a shell. The opt-in and check-cmd fields are unchanged command strings with no new interpolated variables. The illustrative find "$REPO_ROOT" snippet in python.md is pre-existing and not modified in this PR.
Credential / secret handling — no new variables, environment references, or external calls introduced.
Authorization / access-control — no permission widening. The opt-in simplification removes a clause, narrowing rather than broadening activation scope.
GitHub Actions / supply-chain — no workflow files touched; no dependency pins added or changed.
Command execution surface — check-cmd (uv run ruff check . --no-fix && uv run ruff format . --check && uv run pyright) is pre-existing and unchanged. The new glob only affects which file changes trigger the skill — it does not alter what the skill executes.

claude · 2026-07-25T21:05:58Z

Claude finished @kyle-sexton's task in 1m 28s —— View job

PR Review

Gather context and understand the request
Read changed files and git diff
Check if previously noted gap (examples/python.yaml glob) has been addressed
Review for correctness, security, and CLAUDE.md alignment
Post findings

Verdict: Approve with one minor omission still outstanding (third cycle). All three fixes are correct and internally consistent. The gap flagged in both previous review cycles (2026-07-22 and 2026-07-25) remains unaddressed.

Outstanding gap — `examples/python.yaml` glob still missing `pyrightconfig.json`

This is the third review cycle to note this. The plugin's bundled default was updated:

plugins/toolchain/reference/ecosystems/python.yaml:4:

globs: ["*.py", "pyproject.toml", "uv.lock", "pyrightconfig.json"]

But the consumer-facing example remains unchanged:

docs/conventions/ecosystem-commands/examples/python.yaml:3:

globs: ["*.py", "pyproject.toml", "uv.lock"]   # ← pyrightconfig.json absent

Consuming repos that bootstrapped from this example won't get the detection improvement for pyright-config-only changes. Both surfaces should stay in sync if the fix is considered correct.

Fix this →

All three fixes confirmed correct

Site 1 — pyright prerequisite (python.md:37). The paragraph is accurate: tool presence is evaluated per ecosystem, so a ruff-configured project with pyright absent triggers a whole-ecosystem skip. The chosen approach — document the prerequisite rather than redesign the per-tool skip model — is the right scoped call. Content is correct and discoverable.

Site 2 — pyrightconfig.json glob (python.yaml:4). Addition is correct. The [tool.pyright] table in pyproject.toml was already covered; pyrightconfig.json is the standalone config file that was missing from auto-detection.

Site 3 — opt-in reduction (python.yaml:10). The reduced value "ruff config (ruff.toml, .ruff.toml, or pyproject.toml [tool.ruff])" is now identical to docs/conventions/ecosystem-commands/examples/python.yaml:9, confirming the intended single-condition form. The old semicolon-separated clause was a structural misuse of the opt-in field per the schema definition.

Version and CHANGELOG

0.10.0 → 0.10.1 is the correct semver tier for a scoped bug-fix/documentation-hardening patch — the prior version in plugin.json and CHANGELOG.md is 0.10.0 (main was merged in after 0.10.0 landed via PR #926). The three CHANGELOG bullets under ## [0.10.1] accurately describe each fix. The dateless header is consistent with the existing project convention.

Security

No concerns. All changes are static config YAML and documentation text with no execution surfaces, no new external references, and no credential handling.

claude · 2026-07-25T21:06:03Z

Claude finished @kyle-sexton's task in 1m 10s —— View job

Security Review — PR #1025

Load tools
Read PR diff
Review changed files for security issues
Post findings

No security issues found.

All four changed files are documentation and static configuration — no executable code paths, no injection surfaces, no credential handling, no authorization changes, and no supply-chain exposure.

File	Change	Security verdict
`plugins/toolchain/.claude-plugin/plugin.json`	Version bump `0.10.0` → `0.10.1`	No impact
`plugins/toolchain/CHANGELOG.md`	Release notes text	No impact
`plugins/toolchain/reference/ecosystems/python.yaml`	Added `pyrightconfig.json` to `globs`; simplified `opt-in` string	No impact
`plugins/toolchain/skills/check/context/python.md`	Added prerequisite paragraph for pyright	No impact

Rationale per category checked:

Injection surfaces — globs values ("pyrightconfig.json") are file-detection patterns matched by the skill runtime, not passed to a shell. The opt-in and check-cmd fields are unchanged command strings with no new interpolated variables. The cd "$PROJECT_DIR" && uv run pyright snippet in python.md is pre-existing (line 34) and not modified by this PR.
Credential / secret handling — no new variables, environment references, or external calls introduced.
Authorization / access-control — no permission widening. The opt-in simplification removes a clause, narrowing rather than broadening activation scope.
GitHub Actions / supply-chain — no workflow files touched; no dependency pins added or changed. The install-hint is pre-existing and unchanged.
Command execution surface — check-cmd (uv run ruff check . --no-fix && uv run ruff format . --check && uv run pyright) is pre-existing and unchanged. The new glob only affects which file changes trigger the skill — it does not alter what the skill executes.
Path traversal — "pyrightconfig.json" is a simple filename with no path components or traversal sequences (../).

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d6099c72ab

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

… skip the runner never performs (#2092) ## Summary Discharges review thread `PRRT_kwDOTCGFQM6TyjYS` (PR #1025) on `plugins/toolchain/skills/check/context/python.md:37`. The doc claimed that a ruff-configured project with pyright absent reports a whole-ecosystem missing-tool `skip`, "dropping ruff coverage too". That is not what the runner does. The preflight probes the tool the ecosystem's commands are invoked through — `uv` — and pyright is never probed anywhere in the plugin. With `uv` installed, nothing skips: the two ruff commands run and pass, `uv run pyright` then exits 2, and the Lint cell reports **`FAIL`**. ### Which discharge branch, and why The reviewer offered two: *add a pyright availability probe*, or *document the actual failure behavior*. **This PR documents the actual behavior.** A probe is a contract change, not a bug fix — `SKILL.md:120` explicitly declines partial skips for opaque compound commands ("`check-cmd` is a single opaque string … with no way to run one sub-tool's portion without the other … do not attempt a partial skip"). Adding a per-sub-tool probe would contradict that stated rule and would want its own decision and its own schema work; `SKILL.md:184` already records it as a known limitation with "would need a schema change; not addressed here". Correcting the false claim is the smaller, safer discharge and is the one that removes the actual defect — a doc asserting an outcome the runner never produces. `SKILL.md`'s two gotcha bullets are in scope rather than creep: the "Missing tools → `skip`" bullet is the cross-ecosystem rule `python.md` was mis-inferring from. Correcting only `python.md` would leave the same wrong inference available to the next reader and to every other multi-tool ecosystem. ## Verification **Structural claims, read from the repository:** | Claim | Evidence | | --- | --- | | ruff precedes pyright, chained with `&&` | `reference/ecosystems/python.yaml:8` — `uv run ruff check . --no-fix && uv run ruff format . --check && uv run pyright` | | the preflight probes one tool per ecosystem | `skills/check/SKILL.md:114` — "verify **the tool** is on `PATH`" | | no pyright probe exists | `grep -rn pyright plugins/toolchain/` returns only the yaml command/globs/install-hint and the two doc pages — no probe | | partial skips are declined for opaque compound commands | `skills/check/SKILL.md:120` | **Runtime claim, executed** — disposable temp project, `PATH` scrubbed of the directory holding this machine's `pyright`, `uv` left reachable: ```text $ command -v pyright # under scrubbed PATH pyright NOT on scrubbed PATH $ uv run --no-project pyright error: Failed to spawn: `pyright` Caused by: program not found exit=2 ``` Exit 2 and the exact message the doc now quotes. Nothing on this machine was mutated: the project was a `mktemp -d`, and no installed-plugin state was touched. **Pre-fix control.** The defect here is a doc asserting an outcome the runner does not produce, so the control is the two texts against the established behavior: `origin/main`'s `python.md:37` says *"the whole ecosystem reports a missing-tool `skip` (dropping ruff coverage too)"*, which the `&&` ordering and the uv-only probe both contradict; the branch's text says ruff runs and the ecosystem reports `FAIL`, which the reproduction above confirms. Same runner, two docs, only one of them true. **Gates**, from the worktree root against `origin/main`: `check-changed-skills.sh` (PASS), `check-changelog-parity.sh` (`--check-bump`, `--check-order`), `check-skill-portability.sh` (no unexcused coupling tokens), `markdownlint-cli2` over `plugins/toolchain/**/*.md` (13 files, 0 errors). `SKILL.md` is 185 lines and `python.md` 53 — both well under the 500-line cap. Docs-only; no runtime behavior change. `toolchain` 0.11.1 → 0.11.2. ## Follow-up commit — two review threads, both real `24d54388` addresses both threads filed against the first pass. Neither was noise. **`PRRT_kwDOTCGFQM6XpW6P` — the normative rules disagreed with the new text.** `skills/lint/SKILL.md` said "verify **tools** on `PATH`" and listed missing tools as a `skip` edge case, and `skills/check/SKILL.md:114` said never to report `FAIL` for a missing tool. These markdown skills *are* the executable instructions, so a rule worded three ways is a real classification fork: an agent reading `lint/SKILL.md` could probe pyright and report `skip` for exactly the environment `python.md` now documents as `FAIL`. All three normative statements are now scoped explicitly to the tool an ecosystem's commands are invoked through, so an identical environment cannot be classified two ways depending on which file was read. Correcting `python.md` alone would have left the fork open — the thread was right that the doc change needed the rule change beside it. **`PRRT_kwDOTCGFQM6XpX1E` — `bash.md` lacked the parallel note.** The atomicity gotcha names bash's `shellcheck … && shfmt -d <files>` as the paired example of this exact shape, but only python documented the consequence. A project with ShellCheck present, shfmt absent, and the `.editorconfig` opt-in met hits the identical "nothing skips, spawn error, Lint `FAIL`" outcome. Since this PR's own argument for touching `SKILL.md` was that a `python.md`-only fix leaves the wrong inference available to every other multi-tool ecosystem, leaving bash undocumented would have contradicted it. `context/bash.md` now carries the matching gotcha rather than deferring it to a fast-follow. Re-run after the follow-up: `check-changed-skills.sh` (4 skills checked, 0 failed), `check-skill-portability.sh` (7 skill files, no unexcused coupling tokens), `markdownlint-cli2` (13 files, 0 errors). `check/SKILL.md` 185 lines, `lint/SKILL.md` 161, `bash.md` 43. ## Related N/A No linked issue --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

kyle-sexton added do-not-merge Hard merge gate: do not merge while applied. automated Opened by automation. labels Jul 22, 2026

kyle-sexton mentioned this pull request Jul 22, 2026

ops: loop-lane telemetry — running per-lane status (babysit / triage / work) #502

Closed

kyle-sexton added agent-ready Fully specified and briefed; eligible for autonomous pickup from the frontier. and removed do-not-merge Hard merge gate: do not merge while applied. labels Jul 23, 2026

kyle-sexton mentioned this pull request Jul 24, 2026

Lane telemetry: babysit-loop #1214

Closed

kyle-sexton marked this pull request as ready for review July 25, 2026 15:38

Merge origin/main into fix/1017-toolchain-python-yaml-followups

d6099c7

kyle-sexton merged commit 0b2ca50 into main Jul 25, 2026
26 checks passed

kyle-sexton deleted the fix/1017-toolchain-python-yaml-followups branch July 25, 2026 21:09

chatgpt-codex-connector Bot reviewed Jul 25, 2026

View reviewed changes

Comment thread plugins/toolchain/skills/check/context/python.md

This was referenced Aug 6, 2026

Triage the remaining stranded P2 review findings from the post-merge sweep #1938

Closed

fix(toolchain): document the real pyright-absent outcome instead of a skip the runner never performs #2092

Merged

Navigation Menu

Uh oh!

fix(toolchain): python.yaml pyright skip granularity + config-glob + opt-in wording gaps - #1025

fix(toolchain): python.yaml pyright skip granularity + config-glob + opt-in wording gaps#1025
kyle-sexton merged 2 commits into
mainfrom
fix/1017-toolchain-python-yaml-followups

kyle-sexton commented Jul 22, 2026 •

edited

Loading

Uh oh!

claude Bot commented Jul 22, 2026 •

edited

Loading

Uh oh!

claude Bot commented Jul 22, 2026 •

edited

Loading

Uh oh!

kyle-sexton commented Jul 22, 2026

Uh oh!

claude Bot commented Jul 25, 2026 •

edited

Loading

Uh oh!

claude Bot commented Jul 25, 2026 •

edited

Loading

Uh oh!

claude Bot commented Jul 25, 2026 •

edited

Loading

Uh oh!

claude Bot commented Jul 25, 2026 •

edited

Loading

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

kyle-sexton commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Fix

Verification

Related

Uh oh!

claude Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Review

Site 2 — examples/python.yaml not updated

Site 1 — prerequisite paragraph placement (editorial, not a bug)

Site 3 — opt-in reduction (confirmed correct)

CHANGELOG format

Version bump

Security

Uh oh!

claude Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Security Review — PR #1025

Uh oh!

kyle-sexton commented Jul 22, 2026

Uh oh!

claude Bot commented Jul 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Review

Outstanding gap — examples/python.yaml glob still missing pyrightconfig.json

All three fixes confirmed correct

Uh oh!

claude Bot commented Jul 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Security Review — PR #1025

Uh oh!

claude Bot commented Jul 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Review

Outstanding gap — examples/python.yaml glob still missing pyrightconfig.json

All three fixes confirmed correct

Version and CHANGELOG

Security

Uh oh!

claude Bot commented Jul 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Security Review — PR #1025

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

kyle-sexton commented Jul 22, 2026 •

edited

Loading

claude Bot commented Jul 22, 2026 •

edited

Loading

Site 2 — `examples/python.yaml` not updated

claude Bot commented Jul 22, 2026 •

edited

Loading

claude Bot commented Jul 25, 2026 •

edited

Loading

Outstanding gap — `examples/python.yaml` glob still missing `pyrightconfig.json`

claude Bot commented Jul 25, 2026 •

edited

Loading

claude Bot commented Jul 25, 2026 •

edited

Loading

Outstanding gap — `examples/python.yaml` glob still missing `pyrightconfig.json`

claude Bot commented Jul 25, 2026 •

edited

Loading