You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(source-control): close the docs-only evidence gaps Security & Cost found after #8791 merged #8827
#8791 (security-lane docs-only skip as review evidence) merged at 2026-10-21 04:34Z on the owner's auto-merge. Security & Cost put it on HOLD at f143a26 after the merge armed, and poteto withdrew his OK. The gaps are now on main (plugins/source-control/skills/babysit-prs/scripts/babysit_review_evidence.py):
The stale-marker check (~:247-253) takes min(created_at) over every listed run. It still binds when the reviewing run was deleted and the list holds (C) an earlier draft-skipped run, (D) an earlier rate-limit-failed run with no record, (E) skip, deleted review, skip, or (F) a run with no created_at (the min becomes "" and the check never fires).
The docs allowlist (~:75-81) still counts docs/plugin-philosophy.md (AGENTS.md cites it for code-review rules), docs/upstream/** and docs/architecture/** as docs.
P5: INSTRUCTIONS_RE lacks AGENTS.override, which HIGH_FLOOR covers.
Exploiting 1 needs Actions write (deleting a run). Measured reach of the bind: 0 of the last 100 merged lane PRs would have qualified.
Fix options (S&C)
1: take the min only over runs with a completion record on a completed attempt; unbind on a missing or unparseable created_at; better, require the marker inside a recorded attempt's started_at..completed_at window. (E) needs an append-only per-review record, or refusing the docs-only bind when the lane left any other comment or thread.
2: an explicit allowlist (README/CHANGELOG outside docs/, named docs/ files, deny the rest of docs/), or derive the deny set from what AGENTS.md and REVIEW.md cite.
Decision recorded. Owner, 2026-10-21 ("Lets go w/ recommendations"): revert #8791, as Security & Cost and poteto recommended. As built it bound 0 of the last 100 lane PRs, so reverting costs nothing and removes the deleted-run hiding and the docs/ path bypasses. A docs-only evidence rule comes back only if a real lane needs it, with the recorded-attempt window check and an explicit docs allowlist, and Security & Cost passes it again.
Activity
github-actions commentedon Oct 21, 2026
Thanks for the report. Automated triage handed this issue to a maintainer.
Proposed work class: work-class: structural
Basis: automated intake triage; a maintainer confirms or changes it.
Automated triage. A maintainer reviews it.
kyle-sexton commentedon Oct 21, 2026
Decision recorded. Owner, 2026-10-21 ("Lets go w/ recommendations"): revert #8791, as Security & Cost and poteto recommended. As built it bound 0 of the last 100 lane PRs, so reverting costs nothing and removes the deleted-run hiding and the docs/ path bypasses. A docs-only evidence rule comes back only if a real lane needs it, with the recorded-attempt window check and an explicit docs allowlist, and Security & Cost passes it again.
revert(source-control): stop counting the security lane's docs-only s…