Repository navigation
fix(source-control): make pull-request ready refuse the flip when the verify gate failed on the head #8528
Description
Problem
/source-control:pull-request ready runs the verify gate as its own step: plugins/source-control/skills/pull-request/reference/ready-for-review.md (step 2.5.3) says to run scripts/check-affected.sh --tests and that "exit 1 stops the flip", and makes "the verify gate is clean on git rev-parse HEAD" a completion criterion. That is prose only. The check runs in its own Bash call, so its exit status cannot stop a later call. The flip (step 2.5.4 and the GitHub provider's ready-for-review.md) runs gh pr ready with only check-ready-holds.sh in front of it, and that script never reads a verify result.
Evidence
On #8495 the PR was marked ready at 04:41:54Z on 2026-10-20 after its verify gate failed, with no ready-skip record. It was returned to draft at 04:45:44Z and fixed in 526a296 ("map the extraction packages to their test-node lane").
Fix
The verify step records a result bound to the head commit. A pre-flip script, run in the same shell command as gh pr ready, exits non-zero unless it reads pass for the current HEAD_SHA, or a recorded --skip verify exists for that head. Add a test that a failed or missing result refuses the flip.
🤖 Generated with Claude Code
Activity
github-actions commentedon Oct 20, 2026
Thanks for the report. As I understand it, the verify gate in
/source-control:pull-request readyis only prose. Its result is not tied to the head commit, sogh pr readycan run after a failed check, as happened on #8495. The proposed fix is a pre-flip script, run in the same shell command as the flip. It would require a recordedpassfor the current HEAD SHA or a recorded--skip verify, and a test would cover the refusal. The scope and evidence are clear. I found no exact duplicate. Related, but not the same: #7216 (ready flip racing a push) and #6997 (eval fixture for ready runs). A maintainer will confirm the priority and work class.Automated triage. A maintainer reviews it.