Skip to content

pr-pipeline: let a trusted fix request restart address-feedback past the round cap #8442

Description

@kyle-sexton

Problem

address-feedback.mjs:322-324 escalates feedback-round-cap once rounds >= loop.review-rounds (3, pr-pipeline.yaml:416), with no exception for a trusted fix request. On a PR at 3/3 an owner fix request can never restart the lane; only attended work can. 8 needs-human PRs were at 3/3 on 2026-10-19 (#8053 #8079 #8081 #8110 #8168 #7951 #8097 #8201), per GitHub Support's audit.

Options

  • A (recommended): a trusted fix request newer than the last round grants one more round for the requested thread only.
  • B: no change, but the round-cap escalation says plainly that the lane is done and only attended work continues.

Widening what restarts an unattended fix needs the owner's decision.

Related

#8426, #8433, #8387

🤖 Generated with Claude Code

Activity

  1. added
    needs-triageNot yet classified. Floor until a type and one priority tier are set.
    on Oct 19, 2026
  2. kyle-sexton commented on Oct 19, 2026

    @kyle-sexton
    MemberAuthor

    Owner decision (2026-10-19, in the Automation Lanes session): option A. A trusted fix request newer than the last round grants one more address-feedback round, for the requested thread only.

  3. github-actions commented on Oct 19, 2026

    @github-actions
    Contributor

    Thanks for the write-up. I understand the problem like this: address-feedback escalates feedback-round-cap once a PR reaches loop.review-rounds (3), and a trusted fix request can't restart the lane after that. The issue lists 8 needs-human PRs stuck at 3/3. A maintainer comment records option A: a trusted fix request newer than the last round grants one more round, for the requested thread only. I read that comment as context and did not act on it as an instruction. Nothing else is missing. Related issues you listed: #8426, #8433, #8387. I found no clear duplicates. I'm proposing a scoped-change class for a maintainer to confirm.

    Automated triage. A maintainer reviews it.

  4. added
    priority: mediumReal value, no hard deadline; normal backlog flow.
    and removed
    needs-triageNot yet classified. Floor until a type and one priority tier are set.
    on Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    priority: mediumReal value, no hard deadline; normal backlog flow.

    Fields

    No fields configured for Feature.

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions