Skip to content

fix(source-control): close the remaining capability-check misses and false holds #8273

Open

Description

@kyle-sexton

Refs: #8270

Follow-up from the Automation Lanes review of #8270 (owner decision Q641, 2026-10-18). The capability check in plugins/source-control/skills/babysit-prs/scripts/babysit_risk.py scores a SKILL.md, agents/.md or commands/.md diff HIGH when it changes capability frontmatter. #8270 closes four reproduced bypasses; these remain.

Possible misses (may let a capability change through):

  • A byte-order mark before the opening --- (medium confidence).
  • Nested command files such as commands/sub/x.md are not matched by **/commands/*.md.
  • A multi-line ```! block (unverified).

False HIGHs the reviewer reproduced (fail closed, so safe, but they hold PRs a human then merges):

  • Body edits to nested lists whose hunk shows no key above them.
  • A ! backtick inside a code fence.
  • Prose lines that start with Hooks:.

Done when: each miss scores HIGH and each false-HIGH case scores normally, with a test per case, and hold telemetry shows the false-HIGH rate before and after.

Activity

  1. added
    status: confirmedA maintainer confirmed the item is real and in scope; ready to be worked.
    on Oct 18, 2026
  2. added theissue type on Oct 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    status: confirmedA maintainer confirmed the item is real and in scope; ready to be worked.

    Type

    Fields

    No fields configured for Bug.

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions