Skip to content

disk-hygiene/clean: document per-plugin shell-helper + exit-code divergence as deliberate #820

Description

@kyle-sexton

This was generated by AI during triage.

Two cross-plugin consistency observations share one fork — consolidate into a shared helper vs. document the per-plugin copies as deliberate:

  • The shell assert-helper is duplicated across 5 plugins (source-control, repo-hygiene, claude-ops, guardrails, work-items) and check-skill-portability.test.sh opted out with bespoke PASS/FAIL counters.
  • Per-script exit-code taxonomies diverge (gate 0/1/3/4 vs batch 0/1/2/5/7 vs portability 0/1/2) with no shared usage/exit helper.

Decision defaulted: document the per-plugin copies + per-script exit taxonomies as deliberate rather than extracting a shared helper — veto before merge. Grounded in the repo's plugin-portability posture (#531: plugins stay self-contained/portable); a cross-plugin shared test/exit helper would couple otherwise-independent plugins and break drop-in portability, and the exit-code taxonomies encode genuinely different per-script contracts. Maintainer-vetoable alternative: extract a single shared guard/assert helper and accept the coupling.

Acceptance: each duplicated assert-helper copy and each script's exit-code taxonomy carries a short note (at the copy site or in the plugin's convention doc) stating the per-plugin duplication/divergence is intentional for portability; no shared helper is introduced unless the veto is exercised.

Sweep-converted from #657.

Work-class: C2 (mechanical) — attended triage 2026-07-23, operator-ratified. 🤖

Metadata

Metadata

Assignees

Labels

agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.do-not-mergeHard merge gate: do not merge while applied.priority: mediumReal value, no hard deadline; normal backlog flow.status: readyTriaged, unblocked, and fully specified; eligible to pick up.work-class: mechanicalDeterministic, trivially reversible maintenance: dependency bumps, lint/format, sync.

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions