Repository navigation
fix(planning): forbid questions embedded in interview recommendations and warn on add #7760
Description
Parent
Refs #5893
Depends on
- none: on the frontier now
Outcome
A recommendation never hides a second question. Reported case: Q123's recommendation ended "Also tell me which rung you intend"; the user pressed Accept with no note, which settled the headline but not the embedded question, so the session had to add another question. The skill forbids an embedded question (ask it as its own question), and add warns on one without refusing.
Owner decision recorded on #5893 (2026-10-12): "Item 5: how to handle a question embedded in a recommendation?" → Forbid it in the skill text and have add warn.
Key interfaces
- Interview skill question-authoring rules (
surface.mdor SKILL.md, wherever recommendations are specified). round.pyadd(andreviseif it sets the recommendation). The detection heuristic is chosen in this item; it warns and never refuses.
Done when
- The skill text states that a recommendation carries no question to the user.
-
addwarns on a recommendation that asks the user something, such as the reported "Also tell me which rung you intend" (test). -
adddoes not warn on an ordinary recommendation (test). - The planning Python and surface test suites pass.
Out of scope
- Refusing on a text heuristic.
Activity
kyle-sexton commentedon Oct 17, 2026
Ratified in the owner's batch of decomposed children (2026-10-17).
kyle-sexton commentedon Oct 18, 2026
Agent Brief
Type: Bug
Summary: Forbid questions embedded in interview recommendations, and warn on one at add.
Current behavior:
A recommendation can end with a second question ('Also tell me which rung you intend'); Accept settles the headline but not the embedded question.
Desired behavior:
The interview surface rules state that a recommendation carries no question to the user; a second question is asked as its own question.
add(andrevisewhen it sets the recommendation) warns, never refuses, on a recommendation that asks the user something. The detection heuristic is chosen in this change.Key interfaces:
recommendation(the context surface spoke, not SKILL.md).round.pyaddandrevise: a warn-only check.Acceptance criteria:
test_round.pygains a case whereaddwarns on 'Also tell me which rung you intend' and a case where an ordinary recommendation draws no warning, andscripts/run-test-file.sh plugins/planning/surface/test_round.pyexits 0.scripts/check-changelog-fragments.shexits 0.Out of scope:
This was generated by AI during backlog shaping. Held, not admitted: this brief is drafted and checked, but the issue lane would stop on it today. It is admitted, by adding
agent-ready, once the lane can run the skill-quality check scripts (Automation Lanes' PR #7912). Held under the owner's 2026-10-18 lane-narrowing course correction.