Skip to content

fix(planning): pin interview source-text links to a commit SHA #7752

Closed

Description

@kyle-sexton

Parent

Refs #5795

Depends on

  • none: on the frontier now

Outcome

A source-text link on an interview question keeps pointing at the quoted lines after main moves. Links carry a commit SHA instead of main. Today 9 of 85 repo source anchors in one session pointed at lines that no longer hold the quote.

Owner decisions recorded on #5795 (2026-10-12): "Source anchors: link source quotes to a commit SHA, or re-check anchors against main when a question is posted?" → Link to a commit SHA (permalink).

Key interfaces

  • Whichever layer builds the source URL: the interview skill's question-authoring rules (surface.md) and the add/revise ops in round.py, or the page if it builds the link. This item finds the layer and fixes it there.

Done when

  • A source link produced through the interview flow names a commit SHA, not a branch (test at the layer that builds it).
  • If the session writes the URL: the skill states the permalink rule, and add/revise warns on a blob/<branch> source link (test).
  • The planning surface test suite passes.

Out of scope

  • Linking repo paths in recommendations and commitments (sibling item, which builds on this one).

Activity

  1. added
    needs-humanHuman-in-the-loop required; autonomous sessions must not resolve items carrying this.
    on Oct 17, 2026
  2. added theissue type on Oct 17, 2026
  3. kyle-sexton commented on Oct 17, 2026

    @kyle-sexton
    MemberAuthor

    Ratified in the owner's batch of decomposed children (2026-10-17).

  4. removed
    needs-humanHuman-in-the-loop required; autonomous sessions must not resolve items carrying this.
    on Oct 17, 2026
  5. kyle-sexton commented on Oct 18, 2026

    @kyle-sexton
    MemberAuthor

    Agent Brief

    Type: Bug
    Summary: Pin interview source-text links to a commit SHA and warn on a branch link.

    Current behavior:
    The session writes source-text links into a question's facts, and they point at blob/main, so after main moves some links no longer land on the quoted lines.

    Desired behavior:
    The interview surface rules for a Source block require a link pinned to a commit SHA. The add and revise ops warn, without refusing, on a source link of the form blob/<branch>, naming the question.

    Key interfaces:

    • Interview surface question-authoring rules for the Source block (the context surface spoke, not SKILL.md).
    • round.py add and revise: a warning on a branch source link.

    Acceptance criteria:

    • The surface spoke's Source rule requires a commit-SHA link (read from the diff); the interview SKILL.md is not edited.
    • test_round.py gains cases asserting add and revise warn on a blob/main source link and do not warn on a SHA link, and scripts/run-test-file.sh plugins/planning/surface/test_round.py exits 0.
    • A planning changelog fragment is added and scripts/check-changelog-fragments.sh exits 0.

    Out of scope:


    This was generated by AI during backlog shaping. Held, not admitted: this brief is drafted and checked, but the issue lane would stop on it today. It is admitted, by adding agent-ready, once the lane can run the skill-quality check scripts (Automation Lanes' PR #7912). Held under the owner's 2026-10-18 lane-narrowing course correction.

  6. added
    needs-humanHuman-in-the-loop required; autonomous sessions must not resolve items carrying this.
    agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.
    work-class: scopedA briefed fix or small feature; blast radius bounded by the brief, tests exist.
    and removed
    needs-humanHuman-in-the-loop required; autonomous sessions must not resolve items carrying this.
    on Oct 18, 2026
  7. melodic-automation-lanes commented on Oct 18, 2026

    @melodic-automation-lanes
    Contributor

    The work-resolve-issue run that agent-ready started failed before it reported, or the token broker refused it because its workflow files differ from main's. work-unblock removed and added agent-ready back to start a fresh run on main's workflow files. It does this once per version of those files, so if this run fails the same way, a person looks at it.

  8. added
    agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.
    and removed
    agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.
    on Oct 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.priority: mediumReal value, no hard deadline; normal backlog flow.work-class: scopedA briefed fix or small feature; blast radius bounded by the brief, tests exist.

    Type

    Fields

    No fields configured for Bug.

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions