Repository navigation
pr-merge: per-PR live smoke of changed skills before unattended merge (owner decision 16) #7529
Closed as not planned
Description
Decision
Owner decision 16 (2026-10-14): a per-PR live smoke of changed skills (behavior probes plus claude plugin eval) is required merge evidence before the first unattended merge of any PR touching plugins/*/skills/** or plugins/*/agents/**. Until it exists, those PRs are excluded from auto-merge. Decision 73: review, security review, ci-status and the skill smoke always run in CI.
The #6202 Amendment now points at this decision in place of its earlier "no smoke check" line.
Work
- Design and build the per-PR smoke in CI for changed skills and agents.
- Make
pr-mergeexclude PRs touching those paths until the smoke exists and passes.
Refs: #6202
Activity
github-actions commentedon Oct 15, 2026
Proposed work class: work-class: structural
Basis: automated intake triage; the lanes App applied this class.
Size: Large
Complexity: High
Uncertainty: Knowable
Flags: none
Blocked by: #7719
#7529 (comment)
This decision settles the open questions. The smoke is parked under #7719 (D2), so nothing is built until that re-evaluation. The
pr-mergeexclusion line is dropped, because D2 says not to re-add the globs. The credential question is answered when the smoke is designed. I've left the existing structural class for a maintainer to confirm.Automated triage, applied by the lanes App.
kyle-sexton commentedon Oct 18, 2026
Decision recorded.
Question: Owner decision 16 kept skill and agent PRs out of unattended merge until a per-PR smoke passed. Q624 later removed all path denials, so those PRs now merge on the verifier verdict alone. Options: (a) re-add
plugins/*/skills/**andplugins/*/agents/**to denied-paths now, then build the smoke; (b) Q624 supersedes it, close; (c) build the smoke as pr-verify evidence with no path denial.Owner's answer: defer under #7719 Do not re-add the globs: #7719 lists "the denied paths" and "Q582's requirement that the verifier run a changed skill" as restrictions removed on purpose, to be re-evaluated against what the drain shows. A paid eval per PR also needs D10's credential answer first. Basis: #7719 body; docs/conventions/pr-pipeline.yaml:322-332.
The owner accepted this recommendation as item D2 of a 21-decision batch in an attended backlog-shaping session on 2026-10-18. The batch question: "Accept all 21 batch 7 decisions, with my change to D13 (#6008 goes to the lane, but you merge its PR because it edits AGENTS.md)? I post a 'Decision recorded.' comment on each issue." The owner answered: "Accept, with my D13 change (Recommended)".
Posted by AI from the owner's answer in that session.
kyle-sexton commentedon Oct 24, 2026
Released for re-triage under the owner's 2026-10-24 rule: an issue stops for a person only for an intent or vision question, a security call, a host or attended run, or spend outside prepaid credit. The hold label came off and intake triage runs again now; it re-applies a hold, with a numbered question, when one of those applies.
To hold this issue again, add
needs-human(orstatus: needs-decision) and say why in a comment.kyle-sexton commentedon Oct 25, 2026
Decision recorded. The owner deferred this work under #7719 on 2026-10-18 and ruled out re-adding the path denials. Nothing new is decided here. Intake's triage (#7529 (comment)) asked two questions: Q1 (keep open as parked, or close) is answered by "defer under #7719" below, so the issue stays open and parked; Q2 (is the smoke still wanted as pr-verify evidence) waits on #7719's re-evaluation and D10.
Sources, quoted verbatim:
The body's second work line ("Make
pr-mergeexclude PRs touching those paths until the smoke exists and passes") is replaced by this decision. On origin/main,docs/conventions/pr-pipeline.yamlsetsdenied-paths: []today.No lane work: the decision's only checkable part,
denied-paths: []with no skill or agent globs, already holds on main (docs/conventions/pr-pipeline.yaml:980). This issue stays parked under #7719.Checks a person runs:
claude plugin evalper PR) before any smoke is built.17 remaining items
melodic-automation-lanes commentedon Oct 27, 2026
Not admitted to the issue lane: no trusted-human acceptance criteria: a listed human must put the confirmed
- [ ]criteria in the body or post them as their own comment, or, on an issue a listed human filed, intake's newest refinement comment must hold them unedited; Size large: the split into sub-issues at intake is pending (owner Q93). Admission takes the issue once each of those is met, when intake triages it again (.github/actions/resolve-config/admission-rules.json).melodic-automation-lanes commentedon Oct 29, 2026
The work-resolve-issue lane did not start this issue (
split-required). Its Size is too large for one run: split it into smaller issues with/work-items:decompose.Run: https://github.com/melodic-software/claude-code-plugins/actions/runs/40960985708
To retry, remove
needs-humanand addagent-readyagain.kyle-sexton commentedon Oct 29, 2026
Scope narrowed: excluding PRs that touch skill paths from auto-merge, and requiring the smoke as merge evidence, are path holds. The owner removed path holds (owner decisions Q15/Q16, 2026-10-29: "There should be no path restrictions. We can add that in later."), so that part is deferred until open issues and open PRs reach 0. Building the per-PR skill smoke as a CI test stays in scope.
kyle-sexton commentedon Nov 1, 2026
Cordoned to the
After zeromilestone by the Issue Triage session; not closed, andneeds-humanremoved. The 2026-10-29 comment on this issue records the skill-path auto-merge exclusion and the merge-evidence smoke as path holds "deferred until open issues and open PRs reach 0", and #7719 lists the changed-skill verifier run among the restrictions removed for throughput. Standing direction §10 defers that hardening to after zero; the per-PR skill smoke is built then.kyle-sexton commentedon Nov 5, 2026
Closed at the owner's direction (2026-11-05, hub session): hardening issues close now and are rediscovered and reopened one at a time at the hardening pass.