Repository navigation
source-control: bound the GitHub read cost of inline promotion evidence before pr-merge adopts it #7517
Closed as not planned
Description
resolve-promotion-evidence.mjs --inline runs the publisher's collect() on every call. collect() pages every closed PR on the default branch (pulls?state=closed&sort=created&direction=asc, publish-promotion-evidence.mjs) and makes one GraphQL call per merge in the window, plus issue-event, check and post-merge-run reads, each a separate spawnSync("gh") with no timeout. origin/main had about 3,800 merges in the last 90 days, so an epoch near the 85-day limit costs thousands of calls per merge decision. A live smoke run took about 4.5 minutes. It fails closed (github-read-failed) on a rate limit, so this is availability, not safety.
Options to evaluate before wiring pr-merge.yml:
- page by
sort=updated&direction=descand stop atsince; note this order is not stable while paging, which the created-ascending choice avoids, so a PR updated mid-read could be skipped (fail-open risk); - skip the per-PR GraphQL read for merges that cannot matter, without losing unclassed autonomous merges;
- a
timeouton the publisher'sspawnSync, and a test asserting gh call counts for N merges.
Found by the ready-for-review code and security reviews of #7516.
Activity
fix(source-control): state inline-mode limits found in the ready review
github-actions commentedon Oct 15, 2026
Thanks for the report. Automated triage handed this issue to a maintainer.
Automated triage. A maintainer reviews it.
kyle-sexton commentedon Oct 18, 2026
Decision recorded.
Question: The issue would bound
--inlinebefore pr-merge adopted it. pr-merge no longer reads promotion evidence. Options: (a) close as not planned and fix the stale docs; (b) keep it and add the timeout now; (c) keep it parked.Owner's answer: (a), and also delete
--inlinemode. No workflow or script calls it.git grep -- --inlinefinds only the script, its test and the reference doc. Less code with the same behavior. Basis: babysit_merge.py:101-102 ("no promotion evidence is read"); promotion-evidence-resolution.md:60 (stale).The owner accepted this recommendation as item D16 of a 21-decision batch in an attended backlog-shaping session on 2026-10-18. The batch question: "Accept all 21 batch 7 decisions, with my change to D13 (#6008 goes to the lane, but you merge its PR because it edits AGENTS.md)? I post a 'Decision recorded.' comment on each issue." The owner answered: "Accept, with my D13 change (Recommended)".
Posted by AI from the owner's answer in that session.
kyle-sexton commentedon Oct 18, 2026
Closed as not planned per the 2026-10-18 decision (D16): pr-merge reads no promotion evidence, so the unused --inline mode was deleted instead of bounded. Removed in #8242.