Skip to content

display-redaction: linear-time mask test times out at 5000 ms in CI #7273

Open

Description

@kyle-sexton

plugins/display-redaction/hooks/mask.test.ts:256 ("runs each of the worst accepted extra patterns in time linear in the text length") failed in merge-queue run 38185144497 (check-plugins). It took 5438 ms against the test runner's 5000 ms default timeout. The queue then removed #7172, which does not touch display-redaction (failed_checks, 2026-10-11T23:43:48Z).

The test measures wall time on a shared hosted runner, so a slow runner fails it even when the patterns are linear. Possible fixes: compare against a measured baseline in the same run rather than a fixed budget, give the test an explicit, larger timeout, or measure step counts instead of time.

Refs: #7221

🤖 Generated with Claude Code

Activity

  1. added
    needs-triageNot yet classified. Floor until a type and one priority tier are set.
    on Oct 11, 2026
  2. github-actions commented on Oct 11, 2026

    @github-actions
    Contributor

    Thanks for the detailed report. I understand this as: the linear-time pattern-matching test in plugins/display-redaction/hooks/mask.test.ts asserts against a fixed 5000 ms wall-clock budget, and it exceeded that (5438 ms) on a shared hosted runner during merge-queue run 38185144497, causing the queue to fail and remove an unrelated PR (#7172). The three suggested fixes (compare against a measured in-run baseline, use a larger explicit timeout, or assert on step counts instead of wall time) all sound reasonable; a maintainer will need to pick the approach.

    No duplicates found for this specific test/timeout combination. It references #7221, which introduced the mask.ts module and its test suite.

    Automated triage. A maintainer reviews it.

  3. added theissue type on Oct 15, 2026
  4. removed
    needs-triageNot yet classified. Floor until a type and one priority tier are set.
    on Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    priority: mediumReal value, no hard deadline; normal backlog flow.

    Type

    Fields

    No fields configured for Bug.

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions