Repository navigation
fix(guardrails): report when check-bash-file-changes skips or truncates #6709
Description
Refs: #6690
Problem
plugins/guardrails/hooks/check-bash-file-changes.mjs stays silent when it does not examine a change, so a reader of its output cannot tell "checked and clean" from "not checked". A security review of #6708 found:
- It examines at most 20 changed files, sorted by path (MAX_FILES, ~line 383):
touch a{01..20} && echo PAYLOAD > zz.shleaveszz.shunexamined. git statusreturning more than MAX_STATUS_ENTRIES (~line 139), or running past the time budget (~line 391), skips the whole check.- A Bash call with
run_in_background: truewrites after the PostToolUse check has run. - A file written and then deleted in the same command, or a newly created symlink (lstat skip, ~line 276), is never examined.
- The snapshot can silently fail (status timeout, hook timeout, a failed write to the data directory), and the check then has nothing to compare.
Proposed
Report every truncation or skip in the hook's output ("N changed files not examined: ") instead of exiting quietly, and report newly appeared untracked symlinks. Land the must-report tests first.
🤖 Generated with Claude Code
Activity
github-actions commentedon Oct 10, 2026
Thanks for the report. This describes several cases where
plugins/guardrails/hooks/check-bash-file-changes.mjsexits quietly instead of noting that a change went unexamined: files past the 20-file cap, agit statusover the entry limit or past the time budget, background-command writes, a create-then-delete or new symlink, and a failed snapshot. The proposed fix is to surface each skip or truncation in the hook's output ("N changed files not examined: ") and to report newly appeared untracked symlinks, with must-report tests landing first.The report is specific (file, approximate line numbers, and a concrete repro for the file-cap case) and references the originating issue (#6690) and the review that found it (#6708). I didn't find an existing open issue duplicating this one; #6689 is a related but distinct follow-up about narrowing
block-hook-bypassrather than this hook's reporting.No missing information that I can see.
Automated triage. A maintainer reviews it.