Skip to content

babysit classifier: count_classified counts stale pipe-row classifications from non-thread review-summary comments #642

Description

@kyle-sexton

Found by the control tower's merge digest of PR #634 (shared babysit classifier, #534).

count_classified in plugins/source-control/skills/babysit-prs/scripts/babysit_classify.py counts self-authored classification pipe-rows in ANY comment, including PR-level review-summary comments that are never thread-resolved. A stale classification posted outside a review thread keeps counting after its finding is discounted by the thread-state guard, so classified can be inflated past a fresh open finding — a fail-open path for READINESS_OK.

Requires a specific posting pattern (classification rows in non-thread comments), so lower likelihood than the truncation defect fixed on #634, but same gate surface and same failure direction. Candidate fix: only count pipe-rows that live inside review-thread comments, or apply thread-state discounting to the comment container before counting.

Related: #534, PR #634 (digest thread), #465 (open-state discount).

Metadata

Metadata

Assignees

No one assigned

    Labels

    priority: highSignificant impact, or blocks an imminent release; staff this cycle.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions