wizard: write_env follow-ups from the #6275 verification (symlinked parent dir, key refusal gaps) #6391
Copy link
Copy link
Closed
Labels
needs-humanHuman-in-the-loop required; autonomous sessions must not resolve items carrying this.Human-in-the-loop required; autonomous sessions must not resolve items carrying this.needs-triageNot yet classified. Floor until a type and one priority tier are set.Not yet classified. Floor until a type and one priority tier are set.
Description
Follow-ups from a fresh-context security verification of #6275 at 8a2c8c7 (plugins/wizard/skills/generate/template.sh). The verifier rated the PR ship; none of these block it.
- Medium: a symlinked parent directory bypasses the outside-project prompt.
_check_env_targetchecks only the final path component for a symlink. WithENV_FILE=sub/.envwheresublinks to a directory outside the project,write_envwrites through without asking. The default.envis unaffected. Fix: resolve the full path (parent directory included) before the inside-project test. - Low: the drift test does not derive every global. Its grep skips indented assignments, so the colour globals (
BOLDand the rest) are hardcoded in the refusal list rather than derived from the library. - Low: refusal tests pass vacuously on code without the function. A missing function also exits non-zero, so on the pre-fix code only the ordinary-key accept test failed. Assert the refusal message, not just the exit code.
- Low: shell special variables are accepted as keys.
PATH,IFSand similar are not refused by_assignable_key.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
needs-humanHuman-in-the-loop required; autonomous sessions must not resolve items carrying this.Human-in-the-loop required; autonomous sessions must not resolve items carrying this.needs-triageNot yet classified. Floor until a type and one priority tier are set.Not yet classified. Floor until a type and one priority tier are set.
Type
Fields
No fields configured for issues without a type.
Activity
github-actions commentedon Oct 4, 2026
Thanks for the report. Automated triage handed this issue to a maintainer.
Automated triage. A maintainer reviews it.