test(source-control): run the worktree-root-doctor and worktree-add-containment-gate suites on Windows Git Bash

[kyle-sexton]

Refs #3138

Summary

Two source-control test suites fail on Windows Git Bash and are host-skipped there until this lands:

• plugins/source-control/scripts/worktree-root-doctor.test.sh: 9 failures (measured 2026-08-23)
• plugins/source-control/hooks/worktree-add-containment-gate.test.sh: 2 failures

Reproducing and fixing them needs a Windows host with Git Bash; an agent on Linux or WSL cannot run them.

Fix

On a Windows Git Bash host, run each suite, classify each failure (path form, drive-letter or /c/ translation, symlink or junction behavior, uname reporting), fix the script or the test fixture, and delete the Windows host-skip from both suites.

Verification

Both suites pass on Windows Git Bash with the host-skip removed, and still pass on Linux.

Related

• chore: follow-ups surfaced by the setup-contract campaign (toolchain pin, CLAUDE_PLUGIN_ROOT liveness, Windows worktree test failures) #3138 (owner decision of 2026-09-29, item 3: host-skip now, child issue for real Windows support)
• scripts: affected-tests.sh --run reports 23 failing suites on Windows Git Bash (pre-existing, unrelated to the hang fix) #3966 and scripts: affected-tests.sh --run hangs on check-changed-skills.test.sh on Windows Git Bash #3797 (closed; concern affected-tests.sh, not these suites)

[kyle-sexton]

Resolution (2026-09-29, owner-approved consensus)

Not resolved. Both suites still fail on Windows Git Bash with the host-skip removed. Measured, not fixed. The fix stays in this repo.

Host and setup. melo-desk-001, native Windows lane, Git for Windows bash (MINGW64_NT-10.0-26200 3.6.9), git 2.55.0.windows.3, jq 1.8.2. ssh.exe melo-desk-001 from WSL to its own host fails Host key verification failed, so I used the same-machine interop route (powershell.exe from WSL, console account). Nothing global changed and nothing needed credentials or elevation. Scratch copy: git archive origin/main plugins/source-control (56e4800) extracted to %TEMP%\claude-5350, never the working checkout. In that copy only, I deleted the MINGW*|MSYS*|CYGWIN* skip line from both suites.

$ "C:\Program Files\Git\bin\bash.exe" run.sh   # bash scripts/worktree-root-doctor.test.sh; bash hooks/worktree-add-containment-gate.test.sh
doctor rc=1   (13 FAIL lines, 50 cases)
gate rc=1     (4 FAIL lines, 48 cases)

Note: the counts are 13 and 4, not the 9 and 2 measured on 2026-08-23. The suites have grown since.

Gate failures (4). Cases 34, 36, 39, 40, for example:

FAIL: [40] the containment gate rewrote worktreeroot.path — expected /tmp/tmp.Bwj5M7TnqH/legacy-root got C:/Users/KYLESE~1/AppData/Local/Temp/tmp.Bwj5M7TnqH/legacy-root
FAIL: [34] the message names the git-key root — expected /tmp/tmp.Bwj5M7TnqH/key-root in: BLOCKED: ...

Doctor failures (13). Cases 14, 17, 19, 22, 24 have the same shape:

FAIL: [19] the doctor rewrote worktreeroot.path at the origin — expected /tmp/tmp.7PshMpACXX/wt-root-legacy got C:/Users/KYLESE~1/AppData/Local/Temp/tmp.7PshMpACXX/wt-root-legacy

Cases 28, 29, 30, 38, 39, 40, 42, 43 are includeIf failures:

info: includeIf "gitdir/i:**/increpo-fixture/.git" -> /tmp/tmp.7PshMpACXX/identity-work.inc — did not contribute values here
FAIL: [38] a plain value shadowing an include is a finding (exit 1) — exit expected 1 got 0

Classification (from the log text; the code was not yet traced):

Class	Cases	Cause
Path form / drive translation	gate 34, 36, 39, 40; doctor 14, 17, 19, 22, 24	mktemp yields MSYS /tmp/.... The script hands it to native git.exe, which returns C:/Users/KYLESE~1/AppData/Local/Temp/... (8.3 short name). The string comparisons expect the MSYS form.
includeIf path	doctor 28, 29, 30, 38, 39, 40, 42, 43	The fixture's include path is an MSYS /tmp/... path that native git does not follow, so the include never contributes. This is likely path form too; symlink/junction and uname do not appear in the logs.

Against the acceptance criteria

• Both suites pass on Windows Git Bash with the skip removed: NOT met (13 + 4 failures).
• Both still pass on Linux: not run here, and it is only meaningful after a fix.
• Failures classified: met, at log level.

What remains. A fix PR in this repo that normalizes path form in the two suites (compare with cygpath -m, or write fixture paths in the form native git returns) and in the scripts where the include path is handed to native git. It also needs to delete both host-skips, and to be re-run on Windows Git Bash the same way as above. Removing needs-human and adding agent-ready because the remaining work is code and tests only. The scratch dir %TEMP%\claude-5350 on melo-desk-001 (about the size of plugins/source-control, holds the two logs) is still there: a guardrails hook refused the delete. Remove it by hand.