Skip to content

work-items: gitea adapter label-walk silently accepts a non-array 200 response #3439

Description

@kyle-sexton

Context

Found by the repo-wide /code-tidying:batch-simplify sweep (62 groups / 986 files, branch claude/repo-code-tidying-batch-twhddw). The sweep's doctrine files latent defects instead of fixing them mid-sweep, because the fix changes observable behavior; this issue is that filing.

The gitea adapter's label walk treats any 200 body as iterable; a non-array 200 (proxy error page, auth redirect body) is silently accepted, yielding an empty/garbage label set instead of an error.

Proposed work

  • Type-check the decoded response (jq 'type == "array"') and fail closed otherwise.

Acceptance criteria

  • A non-array 200 fixture produces an explicit adapter error.

References

  • plugins/work-items/tools/work-item-tracker/adapters/gitea/common.sh

Filed by the /code-tidying:batch-simplify closeout (Phase 8).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions