repo-hygiene: fleet-sweep field report umbrella — guard, perf, batch, verification (session fee18cc2)

[kyle-sexton]

Context

First real 82-repo fleet run of /repo-hygiene:clean ALL (Windows 11, ghq layout, 9-10 concurrent agent sessions) surfaced a coherent set of defects and gaps. Full field ledger + measurements live in the session running-retro; each finding is filed separately:

Children

• repo-hygiene: destructive-guard PreToolUse hook inert on Windows — bash resolves to WSL relay, fail-open #992 destructive-guard hook inert on Windows (fail-open) — P1 safety
• repo-hygiene: clean-build/clean-caches run ~10 unpruned full-tree find walks per repo — measured 40x overhead #993 ~10 unpruned find walks per repo, measured 40x — P1 perf
• repo-hygiene: no batch mode for caches/build/git tiers — fleet sweep forces hand-rolled orchestration #994 no batch mode for caches/build/git tiers
• repo-hygiene: dry-run emits no sizes and apply re-enumerates — no manifest, no resume, gate pays the walk twice #995 no dry-run sizes / manifest / resume — gate pays walk twice
• repo-hygiene: no stash lifecycle handling — audit/age/triage absent from every tier #996 no stash lifecycle handling
• repo-hygiene: git-branch-audit candidate logic counts branches checked out in linked worktrees — deletion would break them #997 branch audit counts worktree-checked-out branches
• repo-hygiene: fleet preflight has no no-upstream classification — never-pushed branches invisible in ahead/behind reporting #998 preflight blind to no-upstream (never-pushed) branches
• repo-hygiene: clean-build --apply runs dotnet clean then removes bin/obj wholesale — driver is pure overhead #999 dotnet clean driver redundant in apply
• repo-hygiene: resolve-clean-action consumes only the action token — multi-arg intent (questions, constraints) has no channel #1000 resolver drops multi-arg intent
• loop worktrees: teardown leaves empty husk directories behind (11 of 15 entries were dead) #1001 loop-worktree teardown leaves husk dirs (routing TBD)
• repo-hygiene: clean apply emits no per-repo success/fail summary — verification requires manual log scans #1002 apply emits no success/fail summary
• melodic-software/medley#1626 gitignore hole found by the sweep

Fix-order recommendation

992/993 first (safety + the latency everything else sits on), then 995+1002 together (manifest+summary share shape), then 994 (batch consumes manifest), then the rest independently.

[kyle-sexton]

Umbrella complete — all 12 children resolved

Child	Resolution
#992 guard fail-open (P1)	PR #1006 — shell-form hook (Git Bash resolved by the harness) + jq-missing degraded mode fails closed
#993 unpruned walks (P1, 40x)	PR #1023 — single pruned walk per tier (clean_enumerate)
#995 manifest/sizes/resume	PR #1023 — dry-run manifest w/ sizes; apply consumes it (staleness + containment guards); resume = re-apply
#999 dotnet clean driver	PR #1023 — driver dropped from the rm path
#1002 apply summary	PR #1023 — Summary: removed=N failed=M bytes=K, exit 1 on failures
#994 batch tiers	PR #1064 — clean-batch.sh orchestrator, batch-plan-as-gated-set, path normalization, common-dir dedup
#996 stash lifecycle	PR #1066 — git-stash-audit.sh, advisory-only, common-dir deduped
#997 worktree branches	PR #1066 — WORKTREE bucket subtracted from deletion candidates
#998 no-upstream preflight	PR #1066 — own REVIEW class incl. fail-closed when origin/<default> is absent
#1000 resolver multi-arg	PR #1066 — Note: channel, fleet-intent preserved
#1001 loop husks	Closed/routed upstream — creator is the harness built-in /loop; no user-fixable seam
medley#1626 gitignore	medley PR #1627 — directory-level [Bb]in/ rule in the customization zone

Bonus fixed en route: #1011 (scan.sh migrated onto the single-walk engine, PR #1066). Plugin version 0.4.5 → 0.7.0.

Field bugs caught by the review loop and fixed in-flight: fsutil draining the apply loop's stdin on Windows (every manifest entry after the first silently skipped), symlinked-ancestor containment escape, gone-branch deletion candidacy without a provable default-branch comparison.

Follow-ups filed (deliberately deferred, not dangling): #1056 (custom .NET output paths vs fixed-name registry), #1075 (symlink assertion/guard ordering inherited from #1023), #1076 (clean-build manifest tier scoping), #1081 (batch apply --tier vs plan validation).